[Bug 226348] New: Merge Review: python-virtinst

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226348

Summary: Merge Review: python-virtinst
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: python-virtinst

http://cvs.fedora.redhat.com/viewcvs/devel/python-virtinst/
Initial Owner: [e-mail]

[Bug 226348] Merge Review: python-virtinst

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: python-virtinst

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226348

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]

[Bug 226348] Merge Review: python-virtinst

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: python-virtinst

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226348

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2007-05-03 18:25 EST -------
Review based on
http://koji.fedoraproject.org/packages/python-virtinst/0.103.0/3.fc7/src/pyt...

Specfile looks ok overall. Small comments

- Not strictly necessary here, but we encourage people to use %global instead of
%define in spec files
(http://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define)

- Source0 needs to be a complete URL to the released source tarball

- Should the provide of virtinst be versioned ?

rpmlint says:

E: python-virtinst non-executable-script
/usr/lib/python2.5/site-packages/virtinst/ParaVirtGuest.py 0644
  E: python-virtinst non-executable-script
/usr/lib/python2.5/site-packages/virtinst/DistroManager.py 0644
  E: python-virtinst non-executable-script
/usr/lib/python2.5/site-packages/virtinst/Guest.py 0644
  E: python-virtinst non-executable-script
/usr/lib/python2.5/site-packages/virtinst/FullVirtGuest.py 0644
  E: python-virtinst non-executable-script
/usr/lib/python2.5/site-packages/virtinst/util.py 0644

Strip the #!/usr/bin/python from those files; seems unnecessary, anyway

W: python-virtinst obsolete-not-provided python-xeninst

Should be fixed

[Bug 226348] Merge Review: python-virtinst

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: python-virtinst

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226348

------- Additional Comments From [e-mail]  2007-05-03 19:25 EST -------
(In reply to comment #1)
> Should the provide of virtinst be versioned ?

Can't hurt.
> W: python-virtinst obsolete-not-provided python-xeninst 
> Should be fixed

python-xeninst _isn't_ provided, though.  That API was 'import xeninst'.  At
this point, we can probably just drop the obsolete entirely, though. 
python-xeninst was the name before we made it more generic as virtinst.  But
that was only ever in rawhide.

[Bug 226348] Merge Review: python-virtinst

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: python-virtinst

https://bugzilla.redhat.com/show_bug.cgi?id=226348

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2008-01-10 18:34 EST -------
Cole, could you take care of the above spec changes so we can get the review
finished ?

[Bug 226348] Merge Review: python-virtinst

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: python-virtinst

https://bugzilla.redhat.com/show_bug.cgi?id=226348

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

------- Additional Comments From [e-mail]  2008-01-10 21:06 EST -------
These fixes will be in the new rawhide build python-virtinst-0_300_2-1_fc9

[Bug 226348] Merge Review: python-virtinst

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226348

Mark McLoughlin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
                 CC|                            |[e-mail]
         Resolution|                            |CURRENTRELEASE

--- Comment #5 from Mark McLoughlin   2009-02-12 09:20:06 EDT ---
closing