https://bugzilla.redhat.com/show_bug.cgi?id=1688799
Bug ID: 1688799 Summary: Review Request: python-keras-applications Product: Fedora Version: 30 Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: ruslanpisarev@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3...
Description: Keras Applications are deep learning models that are made available alongside pre-trained weights. These models can be used for prediction, feature extraction, and fine-tuning.
PyPI: https://pypi.org/project/Keras-Applications/ Documentation: https://keras.io/applications/
https://bugzilla.redhat.com/show_bug.cgi?id=1688799
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@gmail.com
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Please remove the Python 2 subpackage.
https://bugzilla.redhat.com/show_bug.cgi?id=1688799
--- Comment #2 from ruslan ruslanpisarev@gmail.com --- The Python 2 subpackage was removed:
https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3... https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3...
https://bugzilla.redhat.com/show_bug.cgi?id=1688799
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |quantum.analyst@gmail.com Flags| |fedora-review?
--- Comment #3 from Elliott Sales de Andrade quantum.analyst@gmail.com --- - Remove Group tag - Using %{python3_sitelib}/* globbing is no longer acceptable. - Remove rm -rf %{buildroot} - You can remove the manual Requires and use the automatic generator. You can also enable it on older releases if you are building there as well:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatic... - You are using the GitHub tarball, so there's no need to download the LICENSE file separately. - Similarly, tests are available in the GitHub tarball, why not run them? - You do not need an explicit dependency on python-rpm-macros - Why the dependency on fdupes?
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 - Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. Note: Unversionned Python dependency found. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Python/#_dependencies
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated". 24 files have unknown license. Detailed output of licensecheck in 1688799-python-keras-applications/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-keras-applications-1.0.7-4.fc30.noarch.rpm python-keras-applications-1.0.7-4.fc30.src.rpm python3-keras-applications.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee python3-keras-applications.noarch: W: spelling-error %description -l en_US archictures -> architectures, architecture, caricatures python-keras-applications.src: W: spelling-error %description -l en_US pre -> per, ore, pee python-keras-applications.src: W: spelling-error %description -l en_US archictures -> architectures, architecture, caricatures 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_CA.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_CA.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_CA.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). sh: /usr/bin/python: No such file or directory python3-keras-applications.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee python3-keras-applications.noarch: W: spelling-error %description -l en_US archictures -> architectures, architecture, caricatures python3-keras-applications.noarch: W: invalid-url URL: https://github.com/keras-team/keras-applications <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Requires -------- python3-keras-applications (rpmlib, GLIBC filtered): python(abi) python3.7dist(h5py) python3.7dist(numpy) python3dist(h5py) python3dist(numpy)
Provides -------- python3-keras-applications: python3-keras-applications python3.7dist(keras-applications) python3dist(keras-applications)
Source checksums ---------------- https://github.com/keras-team/keras-applications/archive/1.0.7.tar.gz : CHECKSUM(SHA256) this package : 8580a885c8abe4bf8429cb0e551f23e79b14eda73d99138cfa1d355968dd4b0a CHECKSUM(SHA256) upstream package : 8580a885c8abe4bf8429cb0e551f23e79b14eda73d99138cfa1d355968dd4b0a https://raw.githubusercontent.com/keras-team/keras-applications/1.0.7/LICENS... : CHECKSUM(SHA256) this package : 82e4461dcead03930115f469fd487dc1e60421119e36b25c5be707f1dba08170 CHECKSUM(SHA256) upstream package : 82e4461dcead03930115f469fd487dc1e60421119e36b25c5be707f1dba08170
Generated by fedora-review 0.6.1 (29df316) last change: 2019-03-10 Command line :/home/elliott/code/FedoraReview/try-fedora-review -m fedora-rawhide-x86_64 -b 1688799 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, BATCH, EPEL7, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1688799
--- Comment #4 from ruslan ruslanpisarev@gmail.com --- Hi Elliott, Thanks for your notices. I've fixed spec and rebuilt it again:
https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3... https://copr-be.cloud.fedoraproject.org/results/rpisarev/tensorflow/fedora-3...
https://bugzilla.redhat.com/show_bug.cgi?id=1688799
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #5 from Elliott Sales de Andrade quantum.analyst@gmail.com --- You do not need to BR python3-rpm-macros either.
What is your FAS username? It looks like you need a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=1688799
--- Comment #6 from ruslan ruslanpisarev@gmail.com --- Hi Elliott, My FAS username is rpisarev. I think I need some sponsor, yes
https://bugzilla.redhat.com/show_bug.cgi?id=1688799
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
--- Comment #7 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Please block FE-NEEDSPONSOR if you require a sponsor.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1688799
--- Comment #8 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Were you able to find a sponsor? This spec is almost finished, but there are a few minor issues:
Summary is too long. Also, there's a typo: Absel -> Abseil.
%{?python_enable_dependency_generator} is no longer needed, as the releases that needed it are EOL now.
It doesn't look like you're running tests; is that possible?
https://bugzilla.redhat.com/show_bug.cgi?id=1688799
--- Comment #9 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Please ignore the previous comment; that was for your other review. This spec is basically correct, except there are a couple of old things that can be removed now:
BuildRequires: python3-rpm-macros %{?python_enable_dependency_generator}
https://bugzilla.redhat.com/show_bug.cgi?id=1688799
--- Comment #10 from Ben Cotton bcotton@redhat.com --- This message is a reminder that Fedora 30 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 30 on 2020-05-26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '30'.
Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version.
Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 30 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above.
Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
https://bugzilla.redhat.com/show_bug.cgi?id=1688799
Ben Cotton bcotton@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |EOL Last Closed| |2020-05-26 18:17:42
--- Comment #11 from Ben Cotton bcotton@redhat.com --- Fedora 30 changed to end-of-life (EOL) status on 2020-05-26. Fedora 30 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug.
If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug.
Thank you for reporting this bug and we are sorry it could not be fixed.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com