[Bug 552564] New: Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

https://bugzilla.redhat.com/show_bug.cgi?id=552564

Summary: Merge Review: perl-IO-stringy - I/O on in-core objects
                    like strings and arrays for Perl
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

SRPM:
http://kojipkgs.fedoraproject.org/packages/perl-IO-stringy/2.110/11.fc13/src...
Spec:
http://koji.fedoraproject.org/koji/fileinfo?rpmID=1735817&filename=perl-...
Description: This toolkit primarily provides Perl modules for performing both
traditional and object-oriented I/O) on things *other* than normal filehandles;
in particular, IO::Scalar, IO::ScalarArray, and IO::Lines.

[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=552564

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=552564

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Parag AN(पराग)  2010-01-15 01:52:08 EST ---

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1923072
- rpmlint is NOT silent for SRPM and for RPM.
perl-IO-stringy.noarch: W: spurious-executable-perm
/usr/share/doc/perl-IO-stringy-2.110/examples/IO_Scalar_synopsis
perl-IO-stringy.noarch: W: doc-file-dependency
/usr/share/doc/perl-IO-stringy-2.110/examples/IO_Scalar_synopsis /usr/bin/perl

+ source files match upstream url (sha1sum)
3ef94404e51e3a6276ddddcce9ba7bbdd6b76a1f  IO-stringy-2.110.tar.gz
+ package meets naming and packaging guidelines.
+ make test gave
All tests successful.
Files=6, Tests=116,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.18 cusr  0.02
csys =  0.24 CPU)
+ Package perl-IO-stringy-2.110-11.fc13.noarch =>
Provides: perl(IO::AtomicFile) = 2.110 perl(IO::InnerFile) = 2.110
perl(IO::Lines) = 2.110 perl(IO::Scalar) = 2.110 perl(IO::ScalarArray) = 2.110
perl(IO::Stringy) = 2.110 perl(IO::Wrap) = 2.110 perl(IO::WrapTie) = 2.110
perl(IO::WrapTie::Master) perl(IO::WrapTie::Slave)
Requires: /usr/bin/perl perl >= 0:5.002 perl >= 0:5.004 perl >= 0:5.005
perl(Carp) perl(Exporter) perl(FileHandle) perl(IO::File) perl(IO::Handle)
perl(IO::Scalar) perl(IO::ScalarArray) perl(IO::WrapTie) perl(Symbol)
perl(overload) perl(strict) perl(vars)

Suggestions:
1) please use macros everywhere so replace rm in following with its macro
/usr/bin/find %{buildroot} -type f -name .packlist -exec rm -f {} ';'

2)change line
%{__chmod} -R u+w %{buildroot}/*
to
%{_fixperms} %{buildroot}/*

3) Fix rpmlint message by adding following to %prep
chmod 644 examples/IO_Scalar_synopsis

APPROVED.

[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=552564

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

--- Comment #2 from Marcela Mašláňová  2010-01-15 07:23:36 EST ---
Thanks, macros in this spec are really strange. Fixed.

[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=552564

--- Comment #3 from Paul Howarth  2010-01-15 08:46:27 EST ---
(In reply to comment #1)
> rpmlint is NOT silent for SRPM and for RPM.
>
> perl-IO-stringy.noarch: W: spurious-executable-perm
> /usr/share/doc/perl-IO-stringy-2.110/examples/IO_Scalar_synopsis
> perl-IO-stringy.noarch: W: doc-file-dependency
> /usr/share/doc/perl-IO-stringy-2.110/examples/IO_Scalar_synopsis /usr/bin/perl

...
> Fix rpmlint message by adding following to %prep
>
> chmod 644 examples/IO_Scalar_synopsis

The rpmlint warnings don't really need fixing; having the example executable
makes it easier to try, and the /usr/bin/perl dependency isn't adding anything
that isn't already required by the package.

[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=552564

--- Comment #4 from Parag AN(पराग)  2010-01-15 08:52:25 EST ---
(In reply to comment #3)
> (In reply to comment #1)
> > rpmlint is NOT silent for SRPM and for RPM.
> >
> > perl-IO-stringy.noarch: W: spurious-executable-perm
> > /usr/share/doc/perl-IO-stringy-2.110/examples/IO_Scalar_synopsis
> > perl-IO-stringy.noarch: W: doc-file-dependency
> > /usr/share/doc/perl-IO-stringy-2.110/examples/IO_Scalar_synopsis /usr/bin/perl
>
> ...
> > Fix rpmlint message by adding following to %prep
> >
> > chmod 644 examples/IO_Scalar_synopsis
>
> The rpmlint warnings don't really need fixing; having the example executable
> makes it easier to try, and the /usr/bin/perl dependency isn't adding anything
> that isn't already required by the package.

Just thought lets keep rpmlint silent. And yes I agree keeping it executable is
easier to try.

Thanks for committing the changes. But Just wonder do you see macros in SPEC
are more recommended for perl packages?

[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=552564

--- Comment #5 from Paul Howarth  2010-01-15 09:01:29 EST ---
I think it's just a matter of maintainer preference, as long as usage is
consistent.

One thing I added that you missed in the review is that there is the bit that
ties the package to a compatible version of perl:

Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))

All perl packages should have this; its absence causes problems like the ones
tracked by Bug #454257.

[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=552564

--- Comment #6 from Marcela Mašláňová  2010-01-15 09:05:51 EST ---
Wow how we missed the module compat. Added. Thanks for your comments.

[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=552564

--- Comment #7 from Parag AN(पराग)  2010-01-15 09:08:24 EST ---
Ah! how come I missed that requires.....

Thanks Paul.

[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=552564

Mathieu Bridon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Mathieu Bridon  2011-01-19 04:13:27 EST ---
This package is in EPEL5, but not in EPEL6. Is there any reason for that?

I would like to see this package in EPEL6, and I am willing to help co-maintain
it.

[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=552564

--- Comment #9 from Mathieu Bridon  2011-01-19 04:40:38 EST ---
Nevermind, I just saw it's in the RHEL6 Client repository (I was only looking
at the Server one).

Sorry for the spam.

[Bug 552564] Merge Review: perl-IO-stringy - I/O on in-core objects like strings and arrays for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=552564

--- Comment #10 from Marcela Mašláňová  2011-01-19 04:44:43 EST ---
I found perl-IO-stringy in optional packages in RHEL-6. Not sure if these can
be built in EPEL-6 or not.