Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=454134
Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lxtnow@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-shar... SRPM URL: http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-shar...
Description: GnomeDesktop is a .NET language binding for assorted GNOME libraries from the desktop release.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono
https://bugzilla.redhat.com/show_bug.cgi?id=454134
dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |dan@danny.cz Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono
https://bugzilla.redhat.com/show_bug.cgi?id=454134
------- Additional Comments From dan@danny.cz 2008-07-05 08:13 EST ------- formal review is here, see notes on the end
OK source files match upstream: b99729f7a7265fb1cecf09ced31e009e3ccd66bb gnome-desktop-sharp-2.20.1.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. BAD license field matches the actual license. OK license is open source-compatible (LGPLv2+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. N/A compiler flags are appropriate. OK %clean is present. OK package builds in koji (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. BAD final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths, correct scriptlets exist OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK pkgconfig files are in devel subpackage OK no libtool .la droppings. OK not a GUI app.
* are you sure about the LGPLv2+ license tag? I was able to find only LGPLv2 references in the sources * this package should obsolete the standalone gtksourceview2-sharp package * the NEWS file can be removed from %doc as there is no real content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono
https://bugzilla.redhat.com/show_bug.cgi?id=454134
------- Additional Comments From lxtnow@gmail.com 2008-07-05 09:39 EST ------- Correct, it's a LGPLv2.1 with a shortname LGPLv2. was confusing with a couple of opened files from previous release gnome-sharp.
SPEC: http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-shar... SRPM: http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-shar...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono
https://bugzilla.redhat.com/show_bug.cgi?id=454134
dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From dan@danny.cz 2008-07-05 10:12 EST ------- All issues are fixed now, this PACKAGE is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono
https://bugzilla.redhat.com/show_bug.cgi?id=454134
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From lxtnow@gmail.com 2008-07-05 10:29 EST ------- Thanks Dan.
New Package CVS Request ======================= Package Name: gnome-desktop-sharp Short Description: .Net language binding for mono Owners: laxathom Branches: F-9 EL-5 InitialCC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono
https://bugzilla.redhat.com/show_bug.cgi?id=454134
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-07-05 14:11 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono
https://bugzilla.redhat.com/show_bug.cgi?id=454134
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From lxtnow@gmail.com 2008-07-05 15:52 EST ------- Thanks Kevin.
imported and built on rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono
https://bugzilla.redhat.com/show_bug.cgi?id=454134
michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michel.sylvan@gmail.com
------- Additional Comments From michel.sylvan@gmail.com 2008-07-06 18:38 EST ------- Will this be pushed to F-9 and EL-5 soon? It's needed to update gnome-do -- thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono
https://bugzilla.redhat.com/show_bug.cgi?id=454134
------- Additional Comments From alexl@users.sourceforge.net 2008-07-06 19:34 EST ------- (In reply to comment #7)
Will this be pushed to F-9 and EL-5 soon? It's needed to update gnome-do --
thanks!
The update of gnome-sharp to 2.20 (which is required for gnome-desktop-sharp to be added to F-9) caused a huge amount of collateral damage in rawhide necessitating rebuilding many mono apps such as f-spot, banshee, muine and others, see the relevant threads on fedora-devel-list:
http://www.redhat.com/archives/fedora-devel-list/2008-July/msg00159.html http://www.redhat.com/archives/fedora-devel-list/2008-July/msg00170.html
Some are still not yet rebuilding because the jump to 2.20 affects many packages across the entire mono stack in unanticipated ways.
I think it's wise to let the dust settle in rawhide before pushing this to F-9, gnome-do users can wait.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono
https://bugzilla.redhat.com/show_bug.cgi?id=454134
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
package-review@lists.fedoraproject.org