https://bugzilla.redhat.com/show_bug.cgi?id=966630
Bug ID: 966630 Summary: Review Request: openstack-java-sdk - OpenStack Java SDK Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fsimonce@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://fsimonce.fedorapeople.org/openstack-java-sdk/openstack-java-sdk.spec SRPM URL: http://fsimonce.fedorapeople.org/openstack-java-sdk/openstack-java-sdk-3.0.0... Description: OpenStack client implementation in Java Fedora Account System Username: fsimonce
https://bugzilla.redhat.com/show_bug.cgi?id=966630
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mizdebsk@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=966630
--- Comment #1 from Federico Simoncelli fsimonce@redhat.com --- SRPM URL: http://fsimonce.fedorapeople.org/openstack-java-sdk/openstack-java-sdk-3.0.0...
https://bugzilla.redhat.com/show_bug.cgi?id=966630
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #2 from Mikolaj Izdebski mizdebsk@redhat.com --- Package Review ==============
Legend: [x] = Pass, [-] = Not applicable
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Large documentation must go in a -doc subpackage. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces.
Java: [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build
Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Pom files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define.
Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI
Rpmlint ------- openstack-java-ceilometer-client.noarch: W: no-documentation openstack-java-glance-client.noarch: W: no-documentation openstack-java-keystone-client.noarch: W: no-documentation openstack-java-nova-client.noarch: W: no-documentation openstack-java-quantum-client.noarch: W: no-documentation openstack-java-swift-client.noarch: W: no-documentation
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5417774
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=966630
Federico Simoncelli fsimonce@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Federico Simoncelli fsimonce@redhat.com --- New Package SCM Request ======================= Package Name: openstack-java-sdk Short Description: OpenStack Java SDK Owners: fsimonce Branches: f18 f19 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=966630
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? | Flags| |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=966630
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=966630
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fsimonce@redhat.com Flags| |needinfo?(fsimonce@redhat.c | |om)
--- Comment #5 from Mikolaj Izdebski mizdebsk@redhat.com --- What's the status of this bug? If there are no problems with the package then please close this bug with resolution NEXTRELEASE.
https://bugzilla.redhat.com/show_bug.cgi?id=966630
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|mizdebsk@redhat.com |nobody@fedoraproject.org
--- Comment #6 from Mikolaj Izdebski mizdebsk@redhat.com --- Submitter unresponsive. Reassigning to nobody.
https://bugzilla.redhat.com/show_bug.cgi?id=966630
Matthias Runge mrunge@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |mrunge@redhat.com Resolution|--- |CURRENTRELEASE Last Closed| |2014-04-29 06:58:17
--- Comment #7 from Matthias Runge mrunge@redhat.com ---
bodhi -L openstack-java-sdk: f19-updates-candidate openstack-java-sdk-3.0.4-1.fc19 f19-updates openstack-java-sdk-3.0.2-1.fc19 f19-updates-testing openstack-java-sdk-3.0.2-1.fc19 f20-updates-candidate openstack-java-sdk-3.0.4-1.fc20 f20-updates-testing openstack-java-sdk-3.0.2-1.fc20 f20-updates openstack-java-sdk-3.0.2-1.fc20
It looks imported, built and pushed. Closing this one.
https://bugzilla.redhat.com/show_bug.cgi?id=966630
Federico Simoncelli fsimonce@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fsimonce@redhat.c | |om) |
package-review@lists.fedoraproject.org