Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: apache-commons-daemon - rename of jakarta-commons-daemon
https://bugzilla.redhat.com/show_bug.cgi?id=592208
Summary: Review Request: apache-commons-daemon - rename of jakarta-commons-daemon Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sochotni@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Note that this is a re-review of existing package
Spec URL: http://sochotni.fedorapeople.org/apache-commons-daemon.spec SRPM URL: http://sochotni.fedorapeople.org/apache-commons-daemon-1.0.2-1.fc12.src.rpm Description:
The scope of this package is to define an API in line with the current Java(tm) Platform APIs to support an alternative invocation mechanism which could be used instead of the public static void main(String[]) method. This specification covers the behavior and life cycle of what we define as Java(tm) daemons, or, in other words, non interactive Java(tm) applications.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
Stanislav Ochotnicky sochotni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |588764
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |fedora@matbooth.co.uk
--- Comment #1 from Mat Booth fedora@matbooth.co.uk 2010-05-17 19:02:46 EDT --- I can do this one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |akurtako@redhat.com
--- Comment #2 from Alexander Kurtakov akurtako@redhat.com 2010-05-21 08:13:04 EDT --- (In reply to comment #1)
I can do this one.
when you take a package you're supposed to change the status to Assigned
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
--- Comment #3 from Stanislav Ochotnicky sochotni@redhat.com 2010-05-21 08:33:36 EDT --- Also set the fedora-review flag to '?' :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
--- Comment #4 from Mat Booth fedora@matbooth.co.uk 2010-05-21 08:46:26 EDT --- Ugh, could have sworn I did that, what a half-job i'm doing. Good job nobody's paying me to do this :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
--- Comment #5 from Mat Booth fedora@matbooth.co.uk 2010-05-31 12:43:12 EDT --- Does the final argument to %add_to_maven_depmap need to be %{short_name} like the other commons packages? And does it also need to contain the legacy depmap for backwards compatibility?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
--- Comment #6 from Stanislav Ochotnicky sochotni@redhat.com 2010-06-01 03:20:11 EDT --- You were correct on both accounts. Fixed in r2 together with few other tweaks:
SRPM URL: http://sochotni.fedorapeople.org/apache-commons-daemon-1.0.2-2.fc13.src.rpm Spec URL: http://sochotni.fedorapeople.org/apache-commons-daemon.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
--- Comment #7 from Mat Booth fedora@matbooth.co.uk 2010-06-03 17:51:04 EDT --- This package looks good. I'm happy that all the rpmlint output is false, unless you really want to capitalise the (TM) trademark symbol...
The only thing I'd say is that it looks to me like only the jsvc sub-package contains anything arch-specific. The base package and the javadoc sub-package could (should?) be noarch. If you do that for release 3, then consider this package APPROVED!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
Mat Booth fedora@matbooth.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
Stanislav Ochotnicky sochotni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Stanislav Ochotnicky sochotni@redhat.com 2010-06-04 03:18:23 EDT --- I wanted to make only jsvc subpackage arch specific, but apparently there is no way to instruct rpm to do this. You can either have whole package (and subpackages) arch specific or noach. There is no way to mix-and-match. At least that's what I was told when I asked the RPM guys. If there is a way to do this, it's probably a hack...
As for the TM, according to our guidelines it should not even be there (https://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or...). So I will remove it before commiting to CVS.
In good faith that I explained those two issues...Requesting CVS:
Thanks. Requesting CVS:
New Package CVS Request ======================= Package Name: apache-commons-daemon Short Description: Defines API to support an alternative invocation mechanism Owners: sochotni Branches: InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
--- Comment #9 from Mat Booth fedora@matbooth.co.uk 2010-06-04 04:43:00 EDT --- (In reply to comment #8)
I wanted to make only jsvc subpackage arch specific, but apparently there is no way to instruct rpm to do this. You can either have whole package (and subpackages) arch specific or noach. There is no way to mix-and-match. At least that's what I was told when I asked the RPM guys. If there is a way to do this, it's probably a hack...
It's no hack. With version 4.6.0 RPM supports sub-packages being noarch by just adding "BuildArch: noarch" to their sub-package section in the spec file.
Please do so for at least the javadoc package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
--- Comment #10 from Stanislav Ochotnicky sochotni@redhat.com 2010-06-04 05:05:39 EDT --- Ah, you are(In reply to comment #9)
(In reply to comment #8)
I wanted to make only jsvc subpackage arch specific, but apparently there is no way to instruct rpm to do this. You can either have whole package (and subpackages) arch specific or noach. There is no way to mix-and-match. At least that's what I was told when I asked the RPM guys. If there is a way to do this, it's probably a hack...
It's no hack. With version 4.6.0 RPM supports sub-packages being noarch by just adding "BuildArch: noarch" to their sub-package section in the spec file.
Yes, but what is really needed here is to have main package noarch, and one subpackage arch specific...and that is apparently not possible now.
Please do so for at least the javadoc package.
This is true, and fixed in r3
SRPM URL: http://sochotni.fedorapeople.org/apache-commons-daemon-1.0.2-3.fc13.src.rpm Spec URL: http://sochotni.fedorapeople.org/apache-commons-daemon.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
--- Comment #11 from Mat Booth fedora@matbooth.co.uk 2010-06-04 05:40:24 EDT --- Ok, thanks. :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
--- Comment #12 from Kevin Fenzi kevin@tummy.com 2010-06-07 16:53:36 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592208
Stanislav Ochotnicky sochotni@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #13 from Stanislav Ochotnicky sochotni@redhat.com 2010-06-08 04:06:15 EDT --- Package built on koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2237470
Thanks all.
package-review@lists.fedoraproject.org