https://bugzilla.redhat.com/show_bug.cgi?id=2183863
Bug ID: 2183863 Summary: Review Request: rust-x11rb-protocol - Rust bindings to X11 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: alebastr89@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-x11rb-protocol/... SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-x11rb-protocol/... Copr: https://copr.fedorainfracloud.org/coprs/alebastr/rust-alacritty/ Description: Rust bindings to X11.
Fedora Account System Username: alebastr
https://bugzilla.redhat.com/show_bug.cgi?id=2183863
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Flags| |fedora-review? Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Status|NEW |ASSIGNED
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- The latest version of this crate is v0.11.1. Please verify that you explicitly need v0.10.0.
https://bugzilla.redhat.com/show_bug.cgi?id=2183863
--- Comment #2 from Aleksei Bavshin alebastr89@gmail.com --- Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-x11rb-protocol/... SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-x11rb-protocol/...
Changes: * Update to 0.11.1 * Patch metadata to compile with nix 0.26
---
The latest version of this crate is v0.11.1. Please verify that you explicitly need v0.10.0.
Well, x11-clipboard compiles with 0.11.x if you bump the dep in Cargo.toml. The changelog mentioned some breaking changes, so I've just been wary of taking the latest version.
https://bugzilla.redhat.com/show_bug.cgi?id=2183863
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- If you'd need to bump dependencies it's usually fine to package a slightly older version ... but if you've already confirmed that just bumping from 0.10 to 0.11 still compiles then we might as well do that 😅 I'll continue the review later today once I'm back at my PC.
https://bugzilla.redhat.com/show_bug.cgi?id=2183863
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - patch is documented and justified - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora ~ license files are included with %license in %files (manually included from upstream repo) - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2183863
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-x11rb-protocol
https://bugzilla.redhat.com/show_bug.cgi?id=2183863
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e79d31f7b9 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e79d31f7b9
https://bugzilla.redhat.com/show_bug.cgi?id=2183863
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-05-02 03:46:24
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e79d31f7b9 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org