[Bug 249590] New: Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

Summary: Review Request: and - Auto nice daemon
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://www.herr-schmitt.de/pub/and/and.spec
SRPM URL: http://www.herr-schmitt.de/pub/and/and-1.2.2-1.src.rpm
Description:
The auto nice daemon renices and even kills jobs according to their CPU time,
owner, and command name. This is especially useful on production machines with
lots of concurrent CPU-intensive jobs and users that tend to forget to
nice their jobs.

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

------- Additional Comments From [e-mail]  2007-07-26 10:57 EST -------
Some Improvements:

Spec URL: http://www.herr-schmitt.de/pub/and/and.spec
SRPM URL: http://www.herr-schmitt.de/pub/and/and-1.2.2-2.src.rpm

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

------- Additional Comments From [e-mail]  2007-07-29 00:08 EST -------
For some reason, attempting to fetch the -2 package redirects me to the -1 package:

Connecting to www.herr-schmitt.de|82.165.107.151|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: http://www.herr-schmitt.de/pub/and/and-1.2.2-1.src.rpm [following]

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

------- Additional Comments From [e-mail]  2007-07-29 13:54 EST -------
I have uploaded the package again and tested the download on my own machine.

The download should works now.

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

------- Additional Comments From [e-mail]  2007-07-29 14:51 EST -------
I'm still getting redirected:
> wget http://www.herr-schmitt.de/pub/and/and-1.2.2-2.src.rpm

--13:49:51--  http://www.herr-schmitt.de/pub/and/and-1.2.2-2.src.rpm
Resolving www.herr-schmitt.de... 82.165.107.151
Connecting to www.herr-schmitt.de|82.165.107.151|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: http://www.herr-schmitt.de/pub/and/and-1.2.2-1.src.rpm [following]
--13:49:52--  http://www.herr-schmitt.de/pub/and/and-1.2.2-1.src.rpm
Connecting to www.herr-schmitt.de|82.165.107.151|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 33569 (33K) [audio/x-pn-realaudio-plugin]
Saving to: `and-1.2.2-1.src.rpm'

100%[=====================================================================================>]
33,569      86.7K/s   in 0.4s

13:49:53 (86.7 KB/s) - `and-1.2.2-1.src.rpm' saved [33569/33569]

Firefox gets redirected as well.

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

------- Additional Comments From [e-mail]  2007-07-29 15:06 EST -------
OK. I have delete and recreate the and directory.

Now, you may get the 301 respone from the server, but the right package.

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-07-29 15:57 EST -------
Nope:
> wget http://www.herr-schmitt.de/pub/and/and-1.2.2-2.src.rpm

--14:53:28--  http://www.herr-schmitt.de/pub/and/and-1.2.2-2.src.rpm
Resolving www.herr-schmitt.de... 82.165.107.151
Connecting to www.herr-schmitt.de|82.165.107.151|:80... ^[[6~connected.
HTTP request sent, awaiting response... 300 Multiple Choices
Length: unspecified [text/html]
Saving to: `and-1.2.2-2.src.rpm'

[ <=>                                                                      
           ] 475         --.-K/s   in 0s

14:53:28 (36.9 MB/s) - `and-1.2.2-2.src.rpm' saved [475]

The 475 bytes I get are:

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<HTML><HEAD>
<TITLE>300 Multiple Choices</TITLE>
</HEAD><BODY>
<H1>Multiple Choices</H1>
The document name you requested (<code>/pub/and/and-1.2.2-2.src.rpm</code>)
could not be found on this server.
However, we found documents with names similar to the one you
requested.<p>Available documents:
<ul>
<li><a
href="/pub/and/and-1.2.2-2.fc7.src.rpm">/pub/and/and-1.2.2-2.fc7.src.rpm</a>
(common basename)
</ul>
</BODY></HTML>

Oh, the links aren't correct.  It really shouldn't be this difficult to put up a
couple of files for downloading.  I think I have managed to fetch the proper
file now.

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

------- Additional Comments From [e-mail]  2007-07-30 11:07 EST -------
At first, I'm very sorry for any inconvenience caused by this technical issue.

I have found out, that my ISP has installed a mechanism which try to guess the
rigth name of the document on the webserver if you type in a wrong URL.

The following URL should works properly:

Spec URL: http://www.herr-schmitt.de/pub/and/and.spec
SRPM URL: http://www.herr-schmitt.de/pub/and/and-1.2.2-2.fc7.src.rpm

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-07-30 14:15 EST -------
I think something is wrong with your scriptlet dependencies; post does not call
/sbin/service.  I think perhaps you meant
  Requires(postun):  /sbin/service

Since this is just a two-character typo and is the only thing I see wrong with
this package, I'll go ahead and approve it and you can fix it when you check in.

Review:
* source files match upstream:
   d34a09d7a396bcf19beb0002195c5862b62292b04fd1fb5a83ae382955f28118
   and-1.2.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none)
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   config(and) = 1.2.2-2.fc8
   and = 1.2.2-2.fc8
  =
   /bin/sh
   /sbin/chkconfig
   /sbin/service
   config(and) = 1.2.2-2.fc8
* %check is not present; no test suite upstream.  I installed the package and 
   made sure the service would start and stop properly.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
X scriptlets look OK but dependencies are slightly off.
* init script looks good and seems to conform to LSB requirements.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED, just fix the %postun scriptlet dependency.

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-07-30 14:35 EST -------
New Package CVS Request
=======================
Package Name: and
Short Description: Auto nice daemon
Owners: [e-mail]
Branches: F-7
InitialCC:

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-07-30 14:39 EST -------
CVS done.

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

------- Additional Comments From [e-mail]  2007-07-31 18:51 EST -------
and-1.2.2-3.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

------- Additional Comments From [e-mail]  2007-08-06 13:55 EST -------
and-1.2.2-3.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

[Bug 249590] Review Request: and - Auto nice daemon

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: and - Auto nice daemon

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |ERRATA
   Fixed In Version|                            |1.2.2-3.fc7