[Bug 443303] New: Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=443303

Summary: Review Request: notification-daemon-engine-nodoka
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://mso.fedorapeople.org/packages/SPECS/notification-daemon-engine-nodoka...
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/notification-daemon-engine-nodoka...
Description: The Nodoka theme engine/theme for the notification daemon

Additional info: I am also upstream for this package. To enable the engine (e.g. for testing purposes) one needs to set gconf key "/apps/notification-daemon/theme" to "nodoka".

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

------- Additional Comments From [e-mail]  2008-05-16 08:20 EST -------
Taking this.

First note: due to defective libsexy requires, it needs a

BuildRequires: libxml2-devel

see bug 446842

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

------- Additional Comments From [e-mail]  2008-05-16 08:21 EST -------
With that fix, it builds fine, and rpmlint has nothing to complain in the
generated packages.

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

------- Additional Comments From [e-mail]  2008-05-16 08:27 EST -------
it seems to work fine, we just need to work out where to set the gconf key
/apps/notification-daemon/theme to enable this by default.

Formal review in a bit, when I get to the office.

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2008-05-16 11:05 EST -------
formal review:

package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec file language: ok
spec file legible: extremely
buildable: yes
ExcludeArch: n/a
upstream sources: ok
BuildRequires: need to add libxml2-devel
locale handling: n/a
ldconfig: ok
relocatable: n/a
directory ownership: ok
duplicate files: ok
file permissions: ok
%clean: ok
macro use: consistent
content: permissible
large docs: n/a
%doc: ok
headers: ok
static libs: ok
pc files: ok
shared libs: ok
devel package: n/a
la files: ok
gui apps: ok
directory ownership: ok
%install: ok
utf8 filenames: ok

Summary, fix the BuildRequires, then it is fine.

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

------- Additional Comments From [e-mail]  2008-05-16 11:46 EST -------
Thanks for pointing that out. Fixed:

SPEC:
http://mso.fedorapeople.org/packages/SPECS/notification-daemon-engine-nodoka...
SPRM:
http://mso.fedorapeople.org/packages/SRPMS/notification-daemon-engine-nodoka...

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

------- Additional Comments From [e-mail]  2008-05-16 14:11 EST -------
Approved. One thing we need to figure out is how to make sure that users get
this theme. We can probably patch the default gconf value in notification-daemon
for now, but longer-term it would be nicer if the metatheme spec had a field for
notification themes, and the appearance capplet handled it

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

------- Additional Comments From [e-mail]  2008-05-16 18:17 EST -------
(In reply to comment #6)
> Approved. One thing we need to figure out is how to make sure that users get
> this theme. We can probably patch the default gconf value in notification-daemon
> for now, but longer-term it would be nicer if the metatheme spec had a field for
> notification themes, and the appearance capplet handled it

Yeah, that would be nice. I was playing with a thought of making a simple app
for selecting notification-daemon engine, but having it in the appearance
capplet (and metatheme) would be better. Perhaps would be good to consult it
with the notification-daemon developer(s) as well :)

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-05-16 18:21 EST -------
New Package CVS Request
=======================
Package Name: notification-daemon-engine-nodoka
Short Description: Nodoka Notificaton Daemon Engine
Owners: mso
Branches: F-8, F-9
InitialCC: 
Cvsextras Commits: yes

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-05-17 16:35 EST -------
cvs done.

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

------- Additional Comments From [e-mail]  2008-05-17 19:28 EST -------
notification-daemon-engine-nodoka-0.1.0-2.fc9 has been submitted as an update for Fedora 9

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

------- Additional Comments From [e-mail]  2008-05-17 19:31 EST -------
notification-daemon-engine-nodoka-0.1.0-2.fc8 has been submitted as an update for Fedora 8

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2008-05-20 09:44 EST -------
It should be available in rawhide by now. Closing.

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

------- Additional Comments From [e-mail]  2008-05-21 07:00 EST -------
notification-daemon-engine-nodoka-0.1.0-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |CLOSED
         Resolution|RAWHIDE                     |CURRENTRELEASE
   Fixed In Version|                            |0.1.0-2.fc9

[Bug 443303] Review Request: notification-daemon-engine-nodoka

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: notification-daemon-engine-nodoka

https://bugzilla.redhat.com/show_bug.cgi?id=443303

------- Additional Comments From [e-mail]  2008-06-03 03:33 EST -------
notification-daemon-engine-nodoka-0.1.0-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.