[Bug 197688] New: Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688

Summary: Review Request: inotify-tools - Command line utilities
                    for inotify
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://fedora.pl/~gajownik/inotify-tools.spec
SRPM URL: http://fedora.pl/~gajownik/inotify-tools-2.1-1.src.rpm
Description: inotify-tools is a set of command line utilities for the Linux inotify
filesystem change notification system.

This is quite simple package so review should be easy ;-) I only don't know how to fix this build warning:

In file included from inotifywait.c:17:
inotify-syscalls.h: In function 'inotify_init':
inotify-syscalls.h:55: warning: implicit declaration of function 'syscall'

inotify-syscalls.h includes sys/syscall.h and unistd.h. Have I missed something?

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inotify-tools - Command line utilities for inotify

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2006-07-06 00:17 EST -------
Not an official review as I'm not yet sponsored
Mock build for development i386 is sucessfull
MUST Items:
     - MUST: rpmlint shows no error. 
     - MUST: dist tag is present.
     - MUST: The package is named according to the Package Naming Guidelines.
     - MUST: The spec file name matching the base package inotify-tools, in the
format inotify-tools.spec.
      - MUST: This package meets the Packaging Guidelines.
      - MUST: The package is licensed with an open-source compatible license GPL.
      - MUST: This package includes License file COPYING.
      - MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct (8053f441fc3fe0f0c73cf483399da17b)
      - MUST: This package owns all directories that it creates. 
      - MUST: This package did not contain any duplicate files in the %files
listing.
      - MUST: This package  have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
      - MUST: This package used macros.
      - MUST: Document files are included like README.
      - MUST: Package did NOT contained any .la libtool archives.
      * Source URL is present and working.
      * BuildRoot is correct BuildRoot:       
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
      * BuildRequires is correct

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inotify-tools - Command line utilities for inotify

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688

------- Additional Comments From [e-mail]  2006-07-06 04:52 EST -------
Thanks for the review!

Today was released new version so here's an updated package:

http://fedora.pl/~gajownik/inotify-tools.spec
http://fedora.pl/~gajownik/inotify-tools-2.2-1.src.rpm

* Thu Jul  6 2006 Dawid Gajownik <gajownik[AT]gmail.com> - 2.2-1
- New version 2.2
- Update URL and description
- Add man pages

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inotify-tools - Command line utilities for inotify

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688

------- Additional Comments From [e-mail]  2006-07-06 06:00 EST -------
== Not an official review as I'm not yet sponsored ==
   Mock build for development i386 is sucessfull

* MUST Items:
     - MUST: rpmlint shows no error. 
     - MUST: dist tag is present.
     - MUST: The package is named according to the Package Naming Guidelines.
     - MUST: The spec file name matching the base package inotify-tools, in the
format inotify-tools.spec.
      - MUST: This package meets the Packaging Guidelines.
      - MUST: The package is licensed with an open-source compatible license GPL.
      - MUST: This package includes License file COPYING.
      - MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct (0ca1dd7a9bb0c6d0bbd084d8436b850f)
      - MUST: This package owns all directories that it creates. 
      - MUST: This package did not contain any duplicate files in the %files
listing.
      - MUST: This package  have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
      - MUST: This package used macros.
      - MUST: Document files are included like README.
      - MUST: Package did NOT contained any .la libtool archives.
      * Source URL is present and working.
      * BuildRoot is correct BuildRoot:       
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
      * BuildRequires is correct

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inotify-tools - Command line utilities for inotify

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688

------- Additional Comments From [e-mail]  2006-07-06 09:28 EST -------
I've e-mailed upstream about this compilation warning and he gave me
instructions how to fix it :-)

http://fedora.pl/~gajownik/inotify-tools.spec
http://fedora.pl/~gajownik/inotify-tools-2.2-2.src.rpm

* Thu Jul  6 2006 Dawid Gajownik <gajownik[AT]gmail.com> - 2.2-2
- Fix compilation warnings

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inotify-tools - Command line utilities for inotify

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-07-19 04:29 EST -------
I will do the review for this submission.

Review for release 2:

* RPM name is OK
* Source inotify-tools-2.2.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint looks OK
* File list looks OK

Notes:

You should use http://download.sourceforge.com/ and not one of the mirrors. e.g.

Source0: http://download.sourceforge.com/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar.g...

Fix that up and I can't see any reason for not approving this.

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inotify-tools - Command line utilities for inotify

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688

------- Additional Comments From [e-mail]  2006-07-31 15:30 EST -------
Sorry for the delay - I was on a vacation.

I chose mirror because there are sometimes problems with connecting to
download.sourceforge.net.

* Mon Jul 31 2006 Dawid Gajownik <gajownik[AT]gmail.com> - 2.2-3
- Fix URL

http://gajownik.zspswidwin.pl/inotify-tools.spec
http://gajownik.zspswidwin.pl/inotify-tools-2.2-3.src.rpm

Thanks for the review!

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inotify-tools - Command line utilities for inotify

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-08-01 01:13 EST -------
Looks good. APPROVED.

Please remember to close this review request once imported into CVS and built.

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: inotify-tools - Command line utilities for inotify

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197688

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-08-01 12:06 EST -------
Package was built fine in devel :)

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197688

Mark McKinstry  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|                            |fedora-cvs?

--- Comment #9 from Mark McKinstry  2010-11-21 23:08:42 EST ---
Package Change Request
======================
Package Name: inotify-tools
New Branches: el5 el6
Owners: drago01 mmckinst
InitialCC: drago01

I emailed Adel about an EPEL 5 and 6 version of inotify-tools. He's not a RHEL
or CentOS user but I am so I'll take care of the EPEL 5 and 6 branch. The
kernel for EPEL 4 (2.6.9) does not have inotify support which was added in
2.6.13 so leaving el4 off the branch list is intentional.

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197688

Adel Gadllah  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Adel Gadllah  2010-11-22 10:19:44 EST ---
(In reply to comment #9)
> Package Change Request
>
> Package Name: inotify-tools
> New Branches: el5 el6
> Owners: drago01 mmckinst
> InitialCC: drago01
>
> I emailed Adel about an EPEL 5 and 6 version of inotify-tools. He's not a RHEL
> or CentOS user but I am so I'll take care of the EPEL 5 and 6 branch. The
> kernel for EPEL 4 (2.6.9) does not have inotify support which was added in
> 2.6.13 so leaving el4 off the branch list is intentional.

Which means that this line
> Owners: drago01 mmckinst

Should be
> Owners: mmckinst drago01

(i.e having you as the primary maintainer)

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197688

--- Comment #11 from Jason Tibbitts  2010-11-22 10:25:33 EST ---
I've processed the request with the owners switched around.

Git done (by process-git-requests).

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197688

--- Comment #12 from Fedora Update System  2011-01-17 22:30:03 EST ---
inotify-tools-3.14-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/inotify-tools-3.14-1.el5

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197688

--- Comment #13 from Fedora Update System  2011-02-04 13:27:20 EST ---
inotify-tools-3.14-1.el5 has been pushed to the Fedora EPEL 5 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197688

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |inotify-tools-3.14-1.el5
         Resolution|NEXTRELEASE                 |ERRATA

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197688

--- Comment #14 from Fedora Update System  2011-02-25 09:40:42 EST ---
inotify-tools-3.13-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/inotify-tools-3.13-3.el6

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197688

--- Comment #15 from Fedora Update System  2011-03-02 20:18:43 EST ---
Package inotify-tools-3.14-1.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 updates-testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing inotify-tools-3.14-1.el6'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/inotify-tools-3.14-1.el6
then log in and leave karma (feedback).

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197688

--- Comment #16 from Fedora Update System  2011-03-18 15:26:10 EDT ---
inotify-tools-3.14-1.el6 has been pushed to the Fedora EPEL 6 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 197688] Review Request: inotify-tools - Command line utilities for inotify

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197688

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|inotify-tools-3.14-1.el5    |inotify-tools-3.14-1.el6