Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: maven-doap-plugin - Plugins which generate a DOAP file from information in a POM
https://bugzilla.redhat.com/show_bug.cgi?id=600236
Summary: Review Request: maven-doap-plugin - Plugins which generate a DOAP file from information in a POM Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: yyang@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://yyang.fedorapeople.org/maven2/maven-doap-plugin.spec SRPM URL: http://yyang.fedorapeople.org/maven2/maven-doap-plugin-1.0-1.src.rpm Description: Maven 2 DOAP Plugin is used to generate compliant Description of a Project (DOAP) file from a POM. The main goal is to be able to provide DOAP files for Semantic Web systems that use them as primary input but that would also alleviate the burden of maintaining two sets of metadata.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600236
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |akurtako@redhat.com AssignedTo|nobody@fedoraproject.org |akurtako@redhat.com Flag| |fedora-review?
--- Comment #1 from Alexander Kurtakov akurtako@redhat.com 2010-06-04 11:16:30 EDT --- I'll take this one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600236
--- Comment #2 from Alexander Kurtakov akurtako@redhat.com 2010-06-04 11:36:27 EDT --- Review:
OK: rpmlint must be run on every package. Output: maven-doap-plugin.noarch: W: spelling-error Summary(en_US) Plugins -> Plug ins, Plug-ins, Plugging maven-doap-plugin.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsus maven-doap-plugin.noarch: W: no-documentation maven-doap-plugin.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-doap-plugin
False positives.
OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: All filenames in rpm packages must be valid UTF-8. OK: Provides/Obsoletes are good.
FIXIT: You should use %global not %define. And why do you need this project_version? It's the same as the version tag. It would be best to remove it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600236
--- Comment #3 from Yang Yong yyang@redhat.com 2010-06-06 23:07:08 EDT --- Remove %project_version, please review again.
Spec URL: http://yyang.fedorapeople.org/maven2/maven-doap-plugin.spec SRPM URL: http://yyang.fedorapeople.org/maven2/maven-doap-plugin-1.0-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600236
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Alexander Kurtakov akurtako@redhat.com 2010-06-07 01:36:54 EDT --- This package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600236
Yang Yong yyang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Yang Yong yyang@redhat.com 2010-06-07 02:52:37 EDT --- New Package CVS Request ======================= Package Name: maven-doap-plugin Short Description: Plugins which generate a DOAP file from information in a POM Owners: yyang Branches: devel InitialCC: huwang liweinan akurtako dbhole
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600236
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #6 from Kevin Fenzi kevin@tummy.com 2010-06-07 17:27:37 EDT --- cvs done, except liweinan account doesn't exist.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600236
--- Comment #7 from Yang Yong yyang@redhat.com 2010-06-08 07:35:22 EDT --- Hi Kevin, cvs is not done yet after 12 hours passed, may be caused by wrong CC, please create cvs again and leave CC blank, thanks.
New Package CVS Request ======================= Package Name: maven-doap-plugin Short Description: Plugins which generate a DOAP file from information in a POM Owners: yyang Branches: devel InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600236
Yang Yong yyang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600236
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=600236
Yang Yong yyang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #8 from Yang Yong yyang@redhat.com 2010-06-09 01:24:38 EDT --- http://koji.fedoraproject.org/koji/buildinfo?buildID=177405
package-review@lists.fedoraproject.org