[Bug 1550655] New: Review Request: <main package name here> - < short summary here>

https://bugzilla.redhat.com/show_bug.cgi?id=1550655

Bug ID: 1550655
           Summary: Review Request: <main package name here> - <short
                    summary here>
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://wakko666.fedorapeople.org/python-tree-format/python-tree-format.spec
SRPM URL:
https://wakko666.fedorapeople.org/python-tree-format/python-tree-format-0.1....
Description:  Python library to generate nicely formatted trees, like the UNIX
tree command
Fedora Account System Username: wakko666

[Bug 1550655] Review Request: python-tree-format - Python library to generate nicely formatted trees, like the UNIX tree command

https://bugzilla.redhat.com/show_bug.cgi?id=1550655

Yanko Kaneti  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Review Request: <main       |Review Request:
                   |package name here> - <short |python-tree-format - Python
                   |summary here>               |library to generate nicely
                   |                            |formatted trees, like the
                   |                            |UNIX tree command

[Bug 1550655] Review Request: python-tree-format - Python library to generate nicely formatted trees, like the UNIX tree command

https://bugzilla.redhat.com/show_bug.cgi?id=1550655

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Robert-André Mauchin  ---
You're missing the python provides, see
https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro

%package     -n python2-%{pkgname}
Summary:        %{summary}
%{?python_provide:%python_provide python2-%{pkgname}}
%description -n python2-%{pkgname}
Python library to generate nicely formatted trees, like the UNIX `tree` command

%if %{with python3}
%package     -n python3-%{pkgname}
Summary:        %{summary}
%{?python_provide:%python_provide python3-%{pkgname}}
%description -n python3-%{pkgname}
Python library to generate nicely formatted trees, like the UNIX `tree` command
%endif # with python3

[Bug 1550655] Review Request: python-tree-format - Python library to generate nicely formatted trees, like the UNIX tree command

https://bugzilla.redhat.com/show_bug.cgi?id=1550655

--- Comment #2 from Brett Lentz  ---
Spec & SRPM updated. Same URL as in Comment #1

[Bug 1550655] Review Request: python-tree-format - Python library to generate nicely formatted trees, like the UNIX tree command

https://bugzilla.redhat.com/show_bug.cgi?id=1550655

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #3 from Robert-André Mauchin  ---
Package approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 5 files have unknown license. Detailed output of licensecheck
     in /home/bob/packaging/review/python-tree-format/review-python-tree-
     format/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -tree-format , python3-tree-format
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: python2-tree-format-0.1.2-1.fc29.noarch.rpm
          python3-tree-format-0.1.2-1.fc29.noarch.rpm
          python-tree-format-0.1.2-1.fc29.src.rpm
python2-tree-format.noarch: W: no-documentation
python3-tree-format.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

[Bug 1550655] Review Request: python-tree-format - Python library to generate nicely formatted trees, like the UNIX tree command

https://bugzilla.redhat.com/show_bug.cgi?id=1550655

--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-tree-format. You may commit to the
branch "f27" in about 10 minutes.