Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=448650
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: smparrish@shallowcreek.net QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://tuxbrewr.fedorapeople.org/gmm++.spec SRPM URL: http://tuxbrewr.fedorapeople.org/gmm++-3.0-1.fc9.src.rpm Description: Generic C++ library for sparse, dense and skyline matrices
These headers are needed in order to build "Step" in kdeedu package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From smparrish@shallowcreek.net 2008-05-27 22:29 EST ------- Kevin & Rex. This is just the straight package. No changes to the gmm-config script yet. Will work on that in tomorrow. Just wanted to get this out there since I know part of kdeedu depend on it.
Steven
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From kevin@tigcc.ticalc.org 2008-05-28 01:47 EST ------- You should leave the main package empty and put everything into %package devel like eigen is doing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From rc040203@freenet.de 2008-05-28 02:12 EST ------- This is inconsistent: ... ./configure --prefix=/usr ... %files %{_includedir}/gmm/
Please use %configure instead of "./configure ..." such %{_includedir} gets propagated to the package's guts.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From smparrish@shallowcreek.net 2008-05-28 03:36 EST ------- Done and done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From rc040203@freenet.de 2008-05-28 06:23 EST ------- Any particular reason to call this package gmm++?
The upstream tarball is called gmm, which according to Fedora conventions, would mean the package must be called "gmm" and not "gmm++".
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From smparrish@shallowcreek.net 2008-05-28 09:17 EST ------- gmm++ is the official project name, as such it falls within the Fedora naming scheme.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From rdieter@math.unl.edu 2008-05-28 09:23 EST ------- Ralf's sentiments are right on, and including the ++'s need to be justified. To that end, 1. I concur with Steven that upstream indeed does call it gmm++ everywhere on it's upstream website. Tho, makes one wonder why the tarball name is different. 2. Using just gmm could lead to confusion, e.g. with http://www.datalab.uci.edu/resources/gmm/ ??
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From rc040203@freenet.de 2008-05-28 09:51 EST ------- (In reply to comment #7)
- I concur with Steven that upstream indeed does call it gmm++ everywhere on
it's upstream website.
Not quite. They call it "Gmm++" on their website.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From rdieter@math.unl.edu 2008-05-28 10:03 EST ------- Heh, ok, would you prefer Gmm++ ? (I don't think anyone would). :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From rc040203@freenet.de 2008-05-28 10:16 EST ------- (In reply to comment #9)
Heh, ok, would you prefer Gmm++ ? (I don't think anyone would). :)
I would prefer this package to be called "gmm", because that's what the FPG mandates it to be named (after the tarball).
Besides this, yes, I'd prefer "Gmm++" over "gmm++", because size - pardon - case matters: Coke is something different than coke.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm++ - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |rdieter@math.unl.edu Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From rdieter@math.unl.edu 2008-05-28 10:31 EST ------- OK, let's go with gmm (it is friendlier, after-all). That said, please add to -devel: Provides: gmm++-devel = %{version}-%{release} and we'll proceed from there.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: gmm++ - C++ |Review Request: gmm - C++ |library for sparse, dense |library for sparse, dense |and skyline matrices |and skyline matrices
------- Additional Comments From rdieter@math.unl.edu 2008-05-28 10:34 EST ------- I took the liberty of making said change, and issued a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=633206
fwiw, http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/gmm/gmm.spec http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/gmm/gmm-3.0-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From rdieter@math.unl.edu 2008-05-28 11:13 EST ------- rpmlint *.rpm gmm.src:26: W: setup-not-quiet gmm.src: W: invalid-license GPLv2.1+ gmm-devel.noarch: W: no-documentation gmm-devel.noarch: W: invalid-license GPLv2.1+
item 1; MUST fix license tag, License: LGPLv2+
item 2: SHOULD use -q flag on %setup
The rest of the contents are just headers, in their own folder/namespace, simple and harmless.
Source verified: e543571d8812357374699491014abd58 gmm-3.0.tar.gz
naming: ok (hopefully now) scriptlets: n/a macros: ok
APPROVED.
(fixing the items above are mostly trivial, I'll trust you'll do that before building).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
smparrish@shallowcreek.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs+
------- Additional Comments From smparrish@shallowcreek.net 2008-05-28 11:30 EST ------- New Package CVS Request ======================= Package Name: gmm Short Description: C++ library for sparse, dense and skyline matrices Owners: tuxbrewr Branches: F-8 F-9 InitialCC: rdieter Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
smparrish@shallowcreek.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-05-30 16:23 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From updates@fedoraproject.org 2008-05-30 18:28 EST ------- gmm-3.0-3.fc8 has been submitted as an update for Fedora 8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From updates@fedoraproject.org 2008-05-30 18:30 EST ------- gmm-3.0-3.fc9 has been submitted as an update for Fedora 9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From updates@fedoraproject.org 2008-06-03 03:35 EST ------- gmm-3.0-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |CURRENTRELEASE Fixed In Version| |3.0-3.fc8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gmm - C++ library for sparse, dense and skyline matrices
https://bugzilla.redhat.com/show_bug.cgi?id=448650
------- Additional Comments From updates@fedoraproject.org 2008-06-03 03:36 EST ------- gmm-3.0-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org