[Bug 752089] New: Review Request: rubygem-wirble - Handful of common Irb features, made easy

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-wirble - Handful of common Irb features, made easy

https://bugzilla.redhat.com/show_bug.cgi?id=752089

Summary: Review Request: rubygem-wirble - Handful of common Irb
                    features, made easy
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---

Spec URL: http://mcpierce.fedorapeople.org/rpms/rubygem-wirble.spec
SRPM URL:
http://mcpierce.fedorapeople.org/rpms/rubygem-wirble-0.1.3-1.fc15.src.rpm
Description: Handful of common Irb features, made easy.

[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=752089

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=752089

--- Comment #1 from Mamoru Tasaka  2011-12-21 10:04:40 EST ---
Taking.

[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=752089

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

--- Comment #2 from Mamoru Tasaka  2011-12-21 11:01:21 EST ---
 License
  - The "main" license should be MIT as COPYING says so.
    setup.rb is written by Minero Aoki and it seems
    this script is used not only by this software
    (by searching with google), so this script is not directly
    this software's product.

So for now I think the license tag should be "MIT" or
    "MIT and LGPLv2" (not LGPLv2+, setup.rb is version 2.1
    specific).

* Documents
  - The following files should be moved to -doc
---------------------------------------------------
%{geminstdir}/Rakefile
%{geminstdir}/setup.rb
%{geminstdir}/wirble.gemspec
---------------------------------------------------
  - The following files can be marked as %doc.
---------------------------------------------------
%{geminstdir}/_irbrc
---------------------------------------------------

* Macros
  - %ruby_sitelib is just defined but not used anywhere.

Other things seems okay.

[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=752089

--- Comment #3 from Darryl L. Pierce  2011-12-21 11:24:03 EST ---
(In reply to comment #2)
> License
>
> The "main" license should be MIT as COPYING says so.
> setup.rb is written by Minero Aoki and it seems
> this script is used not only by this software
> (by searching with google), so this script is not directly
> this software's product.
>
> So for now I think the license tag should be "MIT" or
> "MIT and LGPLv2" (not LGPLv2+, setup.rb is version 2.1
> specific).

Fixed.
> Documents
> The following files should be moved to -doc
>
> %{geminstdir}/Rakefile
> %{geminstdir}/setup.rb
> %{geminstdir}/wirble.gemspec

Done.
> The following files can be marked as %doc.
>
> %{geminstdir}/_irbrc

Done.
> Macros
> %ruby_sitelib is just defined but not used anywhere.

Removed.
> Other things seems okay.

Updated Spec: http://mcpierce.fedorapeople.org/rpms/rubygem-wirble.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/rubygem-wirble-0.1.3-2.fc16.src.rpm

[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=752089

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Mamoru Tasaka  2011-12-21 23:37:48 EST ---
Approving.

-----------------------------------------------------------
    This package (rubygem-wirble) is APPROVED by mtasaka
-----------------------------------------------------------

[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=752089

Darryl L. Pierce  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #5 from Darryl L. Pierce  2011-12-22 08:08:34 EST ---
Thank you!

New Package SCM Request
=======================
Package Name:      rubygem-wirble
Short Description: Handful of common IRB features, made easy
Owners:            mcpierce
Branches:          f15 f16 el6
InitialCC:

[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=752089

--- Comment #6 from Jon Ciesla  2011-12-22 08:55:47 EST ---
Git done (by process-git-requests).

[Bug 752089] Review Request: rubygem-wirble - Handful of common Irb features, made easy

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=752089

Darryl L. Pierce  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE
        Last Closed|                            |2011-12-22 09:26:37

--- Comment #7 from Darryl L. Pierce  2011-12-22 09:26:37 EST ---
Thank you, Jon and Mamoru!