https://bugzilla.redhat.com/show_bug.cgi?id=2138983
Bug ID: 2138983 Summary: Review Request: rust-finl_unicode - Library for handling Unicode functionality for finl (categories and grapheme segmentation) Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: dcavalca@fb.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-finl_unicode/rust-finl_unicode... SRPM URL: https://dcavalca.fedorapeople.org/review/rust-finl_unicode/rust-finl_unicode...
Description: Library for handling Unicode functionality for finl (categories and grapheme segmentation).
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2138983
--- Comment #1 from Davide Cavalca dcavalca@fb.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=93641698
https://bugzilla.redhat.com/show_bug.cgi?id=2138983
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1984198
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1984198 [Bug 1984198] Review Request: rust-termwiz - Terminal Wizardry for Unix and Windows
https://bugzilla.redhat.com/show_bug.cgi?id=2138983
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review? CC| |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Please remove the "criterion" dev-dependency. It is only used in benchmarks, and vastly inflates the dependency tree and build time.
It also looks like this crate contains large amounts of code that's generated from Unicode data - but the package is missing the Unicode license in its metadata and does only include this statement in its readme:
## Unicode copyright notice
This package incorporates data from Unicode Inc. Copyright © 1991–2022 Unicode, Inc. All rights reserved.
https://bugzilla.redhat.com/show_bug.cgi?id=2138983
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(davide@cavalca.na | |me)
package-review@lists.fedoraproject.org