[Bug 1785967] New: Review Request: python-apply-defaults - Apply values to optional params

https://bugzilla.redhat.com/show_bug.cgi?id=1785967

Bug ID: 1785967
           Summary: Review Request: python-apply-defaults - Apply values
                    to optional params
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/appl...

SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/appl...

Description:
Apply default values to functions.Makes configuration easy! Application 
settings come from a config file into your code cleanly.

Fedora Account System Username: nonamedotc

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=39893100

[Bug 1785967] Review Request: python-apply-defaults - Apply values to optional params

https://bugzilla.redhat.com/show_bug.cgi?id=1785967

Mukundan Ragavan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

[Bug 1785967] Review Request: python-apply-defaults - Apply values to optional params

https://bugzilla.redhat.com/show_bug.cgi?id=1785967

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1785970

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1785970
[Bug 1785970] Review Request: python-jsonrpcserver - Process JSON-RPC requests

[Bug 1785967] Review Request: python-apply-defaults - Apply values to optional params

https://bugzilla.redhat.com/show_bug.cgi?id=1785967

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
%{python3_sitelib}/apply_defaults → %{python3_sitelib}/apply_defaults/

%description is repeated, defining it once as a macro using %{expand:} would 
be nice.

%description is incomprehensible ;( I assume this is something about rewriting
python function signatures... but the description should be more explicit.

+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ latest version
+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK

Package is APPROVED.

[Bug 1785967] Review Request: python-apply-defaults - Apply values to optional params

https://bugzilla.redhat.com/show_bug.cgi?id=1785967

--- Comment #2 from Mukundan Ragavan  ---
Thanks for the review. I will update the spec and will try and improve the
description. :)

[Bug 1785967] Review Request: python-apply-defaults - Apply values to optional params

https://bugzilla.redhat.com/show_bug.cgi?id=1785967

--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-apply-defaults

[Bug 1785967] Review Request: python-apply-defaults - Apply values to optional params

https://bugzilla.redhat.com/show_bug.cgi?id=1785967

Mukundan Ragavan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2020-01-04 12:49:14

--- Comment #4 from Mukundan Ragavan  ---
Built on rawhide.