https://bugzilla.redhat.com/show_bug.cgi?id=1786207
Bug ID: 1786207 Summary: Review Request: python-aiozmq - ZeroMQ integration with asyncio Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: nonamedotc@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/aioz... SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/aioz...
Description: asyncio (PEP 3156) support for ZeroMQ, a messaging library. Features: * Implements create_zmq_connection() coroutine for making 0MQ connections. * Provides ZmqTransport and ZmqProtocol * Provides RPC Request-Reply, Push-Pull and Publish-Subscribe patterns for remote calls.
Fedora Account System Username: nonamedotc
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39899386
https://bugzilla.redhat.com/show_bug.cgi?id=1786207
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl Doc Type|--- |If docs needed, set a value
--- Comment #1 from Mukundan Ragavan nonamedotc@gmail.com --- Turns out the master branch of aiozmq has lots of fixes for building on recent versions of python.
The spec/srpm above uses the master branch for the package. v0.8.0 was released in Dec 2016 and upstream has not released newer versions although there has been activity in the git repo.
https://bugzilla.redhat.com/show_bug.cgi?id=1786207
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- http://aiozmq.readthedocs.org → https://
In general it is nicer to download the tarball directly from github (easier upgrades): %global commit 4e6703c7c56e07c58898228f5d4cf5cb56065a26 %{?commit:%global shortcommit %(c=%{commit}; echo ${c:0:7})} Source0: https://github.com/aio-libs/aiozmq/archive/%%7Bcommit%7D/%%7Bname%7D-%%7Bsho... ... %prep %autosetup %{?commit:-n %{name}-%{commit}}
%{python3_sitelib}/%{pypi_name}, %{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info → add trailing slash
Looks good, but FTI: - nothing provides python3.8dist(pyzmq) < 17.1.2 needed by python3-aiozmq-0.8.0-2.20191223git56065a26.fc32.noarch
The requirements specified in the sources are inconsistent, so maybe it does work with newer versions after all: aiozmq-0.8.0/requirements.txt: pyzmq>=14.2.0 aiozmq-0.8.0/setup.py: install_requires = ['pyzmq>=13.1,<17.1.2']
It would be useful to run the tests. If the test line is uncommented, it just says that the command is deprecated and does not run any tests. Using pytest seems to work fine, except that one test fails with "SocketOperation on a closed socket" or something like that. I'll attach a diff that makes the tests and installation pass for me.
https://bugzilla.redhat.com/show_bug.cgi?id=1786207
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Created attachment 1647742 --> https://bugzilla.redhat.com/attachment.cgi?id=1647742&action=edit spec patch
https://bugzilla.redhat.com/show_bug.cgi?id=1786207
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1785970
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1785970 [Bug 1785970] Review Request: python-jsonrpcserver - Process JSON-RPC requests
https://bugzilla.redhat.com/show_bug.cgi?id=1786207
--- Comment #4 from Mukundan Ragavan nonamedotc@gmail.com --- Modified SPEC URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/aioz... Modified SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/aioz...
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40041174
So, the shortcommit uses first seven chars from the commit and gitrev variable uses the last eight. I am not sure which one should be used. My understanding is last eight but I could be wrong.
https://bugzilla.redhat.com/show_bug.cgi?id=1786207
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl ---
shortcommit uses first seven chars from the commit and gitrev variable uses the last eight
The first seven (or eight) is appropriate. That snippet is supposed to uniquely identify the commit. So what matters is what git accepts. And git accepts any prefix of the sha1 hash, as long as it is unique. Something like 7 or 8 characters is usually unique, and 7 was the default abbreviation in git for a long time iirc.
+ package name is OK + latest version (recent git snapshot) + license is acceptable for Fedora (BSD) + license is specified correctly + builds and installs OK + BR/R/P look OK
rpmlint has only bogus hints.
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1786207
--- Comment #6 from Mukundan Ragavan nonamedotc@gmail.com --- Thanks for the review and clarification! I will change gitrev to match the shortcommit when I import.
https://bugzilla.redhat.com/show_bug.cgi?id=1786207
--- Comment #7 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-aiozmq
https://bugzilla.redhat.com/show_bug.cgi?id=1786207
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2020-01-07 23:17:27
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com