Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928482
Bug ID: 928482 Summary: Review Request: schroedinger-cat-kde-theme - Schrödinger's Cat KDE Theme Product: Fedora Version: rawhide Component: Package Review Severity: unspecified Priority: unspecified Assignee: nobody@fedoraproject.org Reporter: mbriza@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://mbriza.fedorapeople.org/schroedinger-cat-kde-theme.spec SRPM URL: http://mbriza.fedorapeople.org/schroedinger-cat-kde-theme-18.91.0-1.fc18.src... Description: This is Schrödinger's Cat KDE Theme Artwork containing KDM theme, KSplash theme and Plasma Workspaces theme. Fedora Account System Username: mbriza
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928482
--- Comment #1 from Martin Bříza mbriza@redhat.com --- Fixed the preview screenshots, bumped upstream version:
Spec URL: http://mbriza.fedorapeople.org/schroedinger-cat-kde-theme.spec SRPM URL: http://mbriza.fedorapeople.org/schroedinger-cat-kde-theme-18.91.1-1.fc18.src...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928482
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jreznik@redhat.com Assignee|nobody@fedoraproject.org |jreznik@redhat.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928482
--- Comment #2 from Jaroslav Reznik jreznik@redhat.com --- Name: ok, follows schroedinger-cat-backgrounds package name Summary: ok Group is not needed anymore License: ok URL: ok Sources: ok Build root is not needed anymore (and rm -rf %{buildroot} in %install section) Requires: ok Provides: ok
Package builds: ok
rpmlint schroedinger-cat-kde-theme-18.91.1-1.fc18.src.rpm schroedinger-cat-kde-theme.src: W: spelling-error Summary(en_US) Schrödinger's -> Schrodinger's, Schlesinger's, Schwinger's
Spelling is correct, ok
schroedinger-cat-kde-theme.src:61: W: macro-in-comment %{buildroot} schroedinger-cat-kde-theme.src:61: W: macro-in-comment %{_kde4_appsdir}
Just TODO comments, ok
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
rpmlint /home/jreznik/rpmbuild/RPMS/noarch/schroedinger-cat-kde-theme-18.91.1-1.fc14.noarch.rpm schroedinger-cat-kde-theme.noarch: W: unexpanded-macro dependency schroedinger-cat-backgrounds-kde >= %{backgrounds-kde-version} %{backgrounds schroedinger-cat-kde-theme.noarch: W: spelling-error Summary(en_US) Schrödinger's -> Schrodinger's, Schlesinger's, Schwinger's schroedinger-cat-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/SchroedingerCat/2048x1536/schroedinger-cat.jpg ../../../../../../backgrounds/schroedinger-cat/default/standard/schroedinger-cat.jpg schroedinger-cat-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/SchroedingerCat/1280x1024/Schroedinger_Cat.jpg ../../../../../../backgrounds/schroedinger-cat/default/normalish/schroedinger-cat.jpg schroedinger-cat-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/SchroedingerCat/1920x1200/Schroedinger_Cat.jpg ../../../../../../backgrounds/schroedinger-cat/default/wide/schroedinger-cat.jpg schroedinger-cat-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/SchroedingerCat/system-logo-white.png ../../../../../pixmaps/system-logo-white.png schroedinger-cat-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/SchroedingerCat/2048x1536/logo.png ../../../../../../pixmaps/system-logo-white.png 1 packages and 0 specfiles checked; 0 errors, 7 warnings.
Symlinks are known, it's ok, provided by required package.
Btw. KSplash description in System Settings does not show correctly (maybe UTF-8 or ').
Otherwise it's fairly simple packages, based on previously approved one.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928482
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |928303
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928482
--- Comment #3 from Martin Bříza mbriza@redhat.com --- Fixed the description in ksplash and the unexpanded-macro warning:
Spec URL: http://mbriza.fedorapeople.org/schroedinger-cat-kde-theme.spec SRPM URL: http://mbriza.fedorapeople.org/schroedinger-cat-kde-theme-18.91.3-1.fc18.src...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928482
Jaroslav Reznik jreznik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #4 from Jaroslav Reznik jreznik@redhat.com --- Thanks -> APPROVED.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928482
Martin Bříza mbriza@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Martin Bříza mbriza@redhat.com --- New Package SCM Request ======================= Package Name: schroedinger-cat-kde-theme Short Description: Schrödinger's Cat KDE Theme Owners: mbriza jreznik Branches: f19 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928482
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? | Flags| |fedora-cvs+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928482
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928482
Martin Bříza mbriza@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2013-04-03 04:33:02
package-review@lists.fedoraproject.org