Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Catalyst-Engine-Apache - Catalyst Apache Engines
https://bugzilla.redhat.com/show_bug.cgi?id=471429
Summary: Review Request: perl-Catalyst-Engine-Apache - Catalyst Apache Engines Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: iarnell@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://iarnell.fedorapeople.org/perl-Catalyst-Engine-Apache.spec SRPM URL: http://iarnell.fedorapeople.org/perl-Catalyst-Engine-Apache-1.12-2.fc9.src.r... Description: These classes provide mod_perl support for Catalyst.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora-perl-devel-list@redh | |at.com
--- Comment #1 from Iain Arnell iarnell@gmail.com 2008-11-13 12:44:04 EDT --- Another one from the Task::Catalyst list.
There should be nothing too surprising here. t/03podcoverage.t is skipped because the test fails; and the MP13 and MP19 modules are removed because we don't have the corresponding apache httpd versions.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cweyl@alumni.drew.edu AssignedTo|nobody@fedoraproject.org |cweyl@alumni.drew.edu Flag| |fedora-review+
--- Comment #2 from Chris Weyl cweyl@alumni.drew.edu 2008-11-13 14:41:32 EDT --- Everything looks good.
I note that the author has a rather decent test suite, but has not chosen to enable it, for whatever reason. (Makefile.PL explicitly specifies the tests as being only 't/0*.t'.) They all pass when I run them independently (with minor patches to change 01use.t to 02pod.t), but as upstream has them disabled, it's not a blocker. (I would suggest filing a bug upstream, asking if this is intentional, however.)
http://koji.fedoraproject.org/koji/taskinfo?taskID=931745
Spec looks sane, clean and consistent; license is correct (perl); make test passes cleanly.
00d89cac86ed977428468433389f4c6e Catalyst-Engine-Apache-1.12.tar.gz 00d89cac86ed977428468433389f4c6e Catalyst-Engine-Apache-1.12.tar.gz.srpm
=====> perl-Catalyst-Engine-Apache-1.12-2.fc9.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Catalyst-Engine-Apache-1.12-2.fc9.noarch.rpm perl(Catalyst::Engine::Apache) = 1.12 perl(Catalyst::Engine::Apache2) perl(Catalyst::Engine::Apache2::MP20) perl-Catalyst-Engine-Apache = 1.12-2.fc9 ====> requires for perl-Catalyst-Engine-Apache-1.12-2.fc9.noarch.rpm perl(:MODULE_COMPAT_5.10.0) perl(APR::Table) perl(Apache2::Connection) perl(Apache2::Const) perl(Apache2::RequestIO) perl(Apache2::RequestRec) perl(Apache2::RequestUtil) perl(Apache2::Response) perl(Apache2::URI) perl(Catalyst::Runtime) perl(File::Spec) perl(URI) perl(URI::http) perl(URI::https) perl(base) perl(constant) perl(strict) perl(warnings)
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
--- Comment #3 from Iain Arnell iarnell@gmail.com 2008-11-15 04:36:02 EDT --- That rather decent test suite is from Catalyst::Runtime. Proving t/live_*.t just tests Catalyst itself. The scripts in t/optional set things up to really test Engine::Apache, but anything that tests redirection is failing for me (looks like a problem with LWP - even though Catalyst::Test sets things up with LWP::UserAgent->new(max_redirect => 0), LWP still follows the first redirect automatically).
Will go ahead with the package as is and enable additional tests later when I can get them to work.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Iain Arnell iarnell@gmail.com 2008-11-15 04:39:16 EDT --- New Package CVS Request ======================= Package Name: perl-Catalyst-Engine-Apache Short Description: Catalyst Apache Engines Owners: iarnell Branches: F-9 F-10 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2008-11-16 15:04:05 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2008-11-17 12:52:36 EDT --- perl-Catalyst-Engine-Apache-1.12-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Catalyst-Engine-Apache-1.12-2.fc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2008-11-17 12:52:39 EDT --- perl-Catalyst-Engine-Apache-1.12-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-Catalyst-Engine-Apache-1.12-2.fc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2008-11-19 09:53:07 EDT --- perl-Catalyst-Engine-Apache-1.12-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Catalyst-Engine-Apache'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-9755
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2008-11-22 11:57:35 EDT --- perl-Catalyst-Engine-Apache-1.12-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Catalyst-Engine-Apache'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/f10/FEDORA-2008-10000
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2008-12-06 23:20:20 EDT --- perl-Catalyst-Engine-Apache-1.12-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471429
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2008-12-06 23:32:40 EDT --- perl-Catalyst-Engine-Apache-1.12-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org