https://bugzilla.redhat.com/show_bug.cgi?id=1953817
Bug ID: 1953817 Summary: Review Request: perl-PPIx-Utils - Utility functions for PPI Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rc040203@freenet.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-PPIx-Utils.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-PPIx-Utils-0.003-1.fc35.src.... Description: PPIx::Utils is a collection of utility functions for working with PPI documents. The functions are organized into submodules, and may be imported from the appropriate submodule or via this module.
Fedora Account System Username: corsepiu
This package is a new requirement of perl-Perl-MinimumVersion > 1.40
https://bugzilla.redhat.com/show_bug.cgi?id=1953817
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1952554 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1952554 [Bug 1952554] Upgrade perl-Perl-MinimumVersion to 1.40
https://bugzilla.redhat.com/show_bug.cgi?id=1953817
Peter Oliver mavit@mavit.org.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mavit@mavit.org.uk Assignee|nobody@fedoraproject.org |mavit@mavit.org.uk Whiteboard| |AwaitingSubmitter Flags| |fedora-review? | |needinfo?(rc040203@freenet. | |de)
--- Comment #1 from Peter Oliver mavit@mavit.org.uk --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - URL points to http://search.cpan.org/, but https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_url_tag says it should be to https://metacpan.org/ - Source0 redirects from http:// to https://, so we may as well specify https:// in the first place.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "The Perl 5 License GNU General Public License, version 1", "*No copyright* [generated file]", "The Perl 5 License". 14 files have unknown license. Detailed output of licensecheck in /home/mavit/src/fedora-review/1953817-perl-PPIx- Utils/licensecheck.txt [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/PPIx(perl-PPIx-Regexp, perl-PPIx- EditorTools, perl-PPIx-Utilities, perl-PPIx-QuoteLike) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned.
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: perl-PPIx-Utils-0.003-1.fc34.noarch.rpm perl-PPIx-Utils-0.003-1.fc34.src.rpm perl-PPIx-Utils.noarch: W: spelling-error %description -l en_US submodules -> sub modules, sub-modules, modules perl-PPIx-Utils.noarch: W: spelling-error %description -l en_US submodule -> sub module, sub-module, subtle perl-PPIx-Utils.src: W: spelling-error %description -l en_US submodules -> sub modules, sub-modules, modules perl-PPIx-Utils.src: W: spelling-error %description -l en_US submodule -> sub module, sub-module, subtle 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (installed packages) ---------------------------- perl-PPIx-Utils.noarch: W: spelling-error %description -l en_US submodules -> sub modules, sub-modules, modules perl-PPIx-Utils.noarch: W: spelling-error %description -l en_US submodule -> sub module, sub-module, module 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Source checksums ---------------- http://www.cpan.org/authors/id/D/DB/DBOOK/PPIx-Utils-0.003.tar.gz : CHECKSUM(SHA256) this package : 2a9bccfc8ead03be01b67248fe8e152522040f798286fa4ef4432b7f2efdba11 CHECKSUM(SHA256) upstream package : 2a9bccfc8ead03be01b67248fe8e152522040f798286fa4ef4432b7f2efdba11
Requires -------- perl-PPIx-Utils (rpmlib, GLIBC filtered): perl(:MODULE_COMPAT_5.32.1) perl(B::Keywords) perl(Exporter) perl(PPI) perl(PPI::Document::Fragment) perl(PPI::Token::Quote::Single) perl(PPIx::Utils::Classification) perl(PPIx::Utils::Language) perl(PPIx::Utils::Traversal) perl(PPIx::Utils::_Common) perl(Scalar::Util) perl(strict) perl(warnings)
Provides -------- perl-PPIx-Utils: perl(PPIx::Utils) perl(PPIx::Utils::Classification) perl(PPIx::Utils::Language) perl(PPIx::Utils::Traversal) perl(PPIx::Utils::_Common) perl-PPIx-Utils
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review --bug=1953817 -v --mock-config=fedora-34-x86_64 Buildroot used: fedora-34-x86_64 Active plugins: Perl, Generic, Shell-api Disabled plugins: R, Ocaml, Java, C/C++, fonts, PHP, Haskell, Python, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1953817
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(rc040203@freenet. | |de) |
--- Comment #2 from Ralf Corsepius rc040203@freenet.de --- Thanks, updated package:
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-PPIx-Utils.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-PPIx-Utils-0.003-2.fc35.src....
https://bugzilla.redhat.com/show_bug.cgi?id=1953817
Peter Oliver mavit@mavit.org.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|AwaitingSubmitter | Flags|fedora-review? |fedora-review+
--- Comment #3 from Peter Oliver mavit@mavit.org.uk --- Accepted!
https://bugzilla.redhat.com/show_bug.cgi?id=1953817
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-PPIx-Utils
https://bugzilla.redhat.com/show_bug.cgi?id=1953817
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |jplesnik@redhat.com Fixed In Version| |perl-PPIx-Utils-0.003-2.fc3 | |5 Resolution|--- |RAWHIDE Last Closed| |2021-05-11 08:09:44
--- Comment #5 from Jitka Plesnikova jplesnik@redhat.com --- Built by corsepiu
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com