[Bug 1946041] New: Review Request: python-itemloaders -Library that helps you collect data from HTML and XML sources.
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
Bug ID: 1946041 Summary: Review Request: python-itemloaders -Library that helps you collect data from HTML and XML sources. Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: echevemaster@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://echevemaster.fedorapeople.org/python-itemloaders/python-itemloaders.... SRPM URL: https://echevemaster.fedorapeople.org/python-itemloaders/python-itemloaders-... Description:itemloaders is a library that helps you collect data from HTML and XML sources.
It comes in handy to extract data from web pages, as it supports data extraction using CSS and XPath Selectors.
It's specially useful when you need to standardize the data from many sources. For example, it allows you to have all your casting and parsing rules in a single place. Fedora Account System Username: echevemaster
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Use pypi_source:
Source0: %{pypi_source %pkg_name}
- This is not needed anymore:
%{?python_provide:%python_provide python3-%{pkg_name}}
Please refer to: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_pr...
- I think this should be handled automatically by the dependency generator:
Requires: python3-jmespath Requires: python-itemadapter
See: rpm -q --requires -p python3-itemloaders-1.0.4-1.fc35.noarch.rpm | sort -f | uniq -c 1 python(abi) = 3.9 1 python3.9dist(itemadapter) >= 0.1 1 python3.9dist(jmespath) >= 0.9.5 1 python3.9dist(parsel) >= 1.5 1 python3.9dist(w3lib) >= 1.17
- Split the description to stay below 80 characters and use a common description:
%global common_description %{expand: Itemloaders is a library that helps you collect data from HTML and XML sources.
It comes in handy to extract data from web pages, as it supports data extraction using CSS and XPath Selectors.
It's specially useful when you need to standardize the data from many sources. For example, it allows you to have all your casting and parsing rules in a single place.}
- Don't put a period at the end of the Summary
- jmespath in Fedora is only 0.9.4:
DEBUG util.py:444: - nothing provides python3.9dist(jmespath) >= 0.9.5 needed by python3-itemloaders-1.0.4-1.fc35.noarch
But I see you have: https://src.fedoraproject.org/rpms/python-jmespath/pull-request/4#request_di...
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-clause "New" or "Revised" License", "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-itemloaders/review- python-itemloaders/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-itemloaders-1.0.4-1.fc35.noarch.rpm python-itemloaders-1.0.4-1.fc35.src.rpm python3-itemloaders.noarch: W: summary-ended-with-dot C Library that helps you collect data from HTML and XML sources. python3-itemloaders.noarch: E: description-line-too-long C It comes in handy to extract data from web pages, as it supports data extraction using CSS and XPath Selectors. python3-itemloaders.noarch: E: description-line-too-long C It's specially useful when you need to standardize the data from many sources. For example, it allows python-itemloaders.src: W: summary-ended-with-dot C Library that helps you collect data from HTML and XML sources. python-itemloaders.src: E: description-line-too-long C It comes in handy to extract data from web pages, as it supports data extraction using CSS and XPath Selectors. python-itemloaders.src: E: description-line-too-long C It's specially useful when you need to standardize the data from many sources. For example, it allows 2 packages and 0 specfiles checked; 4 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
--- Comment #2 from Eduardo Echeverria echevemaster@gmail.com --- Hi Robert, i made changes based on your suggestions. Can you check out it again?
Thanks for your review. I appreciate it!
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - You need to split the description to stay below 80 characters per line:
%global desc %{expand: Itemloaders is a library that helps you collect data from HTML and XML sources.
It comes in handy to extract data from web pages, as it supports data extraction using CSS and XPath Selectors.
It's specially useful when you need to standardize the data from many sources. For example, it allows you to have all your casting and parsing rules in a single place.}
Package approved, please fix the aforementioned issue before import.
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
Eduardo Echeverria echevemaster@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |python-itemloaders -Library |python-itemloaders - |that helps you collect data |Library that helps you |from HTML and XML sources. |collect data from HTML and | |XML sources.
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
--- Comment #4 from Eduardo Echeverria echevemaster@gmail.com --- Thanks Robert https://pagure.io/releng/fedora-scm-requests/issue/33360
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
--- Comment #5 from Tomas Hrcka thrcka@redhat.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-itemloaders
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-a762513ae2 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a762513ae2
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-36c6548dee has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-36c6548dee
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-36c6548dee has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-36c6548dee *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-36c6548dee
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-a762513ae2 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a762513ae2 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a762513ae2
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2021-06-01 01:02:46
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-a762513ae2 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1946041
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-36c6548dee has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com