[Bug 1684603] New: Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

Bug ID: 1684603
           Summary: Review Request: bCNC - GRBL CNC command sender,
                    autoleveler and G-code editor
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52-0.1.beta.fc29.src.rpm
Description: GRBL CNC command sender, autoleveler, G-code editor, digitizer,
CAM and swiss army knife for all your CNC needs.
Fedora Account System Username: jskarvad

It's python2 only, but python3 port is actively worked on:
https://github.com/vlachoudis/bCNC/issues/228

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Miro Hrončok  ---
You need a FESCo exception for python2 only.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
I think it'd make sense to wait for the python3 version and possibly give
upstream a hand with the transition to python3.
Packaging a python2-only project at this time seems like a waste of effort.

Package name should be lower-case.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #3 from Jaroslav Škarvada  ---
I will probably wait for the python3 version.

needinfo canceled: [Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

Product: Fedora
Version: rawhide
Component: Package Review

Jaroslav Škarvada  has canceled Package Review
's request for Jaroslav Škarvada
's needinfo:
Bug 1684603: Review Request: bCNC - GRBL CNC command sender, autoleveler and
G-code editor
https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #5 from Jaroslav Škarvada  ---
I am still going to handle it.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

Jaroslav Škarvada  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(jskarvad@redhat.c |
                   |om)                         |

--- Comment #5 from Jaroslav Škarvada  ---
I am still going to handle it.

needinfo canceled: [Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

Product: Fedora
Version: rawhide
Component: Package Review

Jaroslav Škarvada  has canceled Package Review
's request for Jaroslav Škarvada
's needinfo:
Bug 1684603: Review Request: bCNC - GRBL CNC command sender, autoleveler and
G-code editor
https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #7 from Jaroslav Škarvada  ---
I am going to handle it and probably also port it.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

Jaroslav Škarvada  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(jskarvad@redhat.c |
                   |om)                         |

--- Comment #7 from Jaroslav Škarvada  ---
I am going to handle it and probably also port it.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

Didik Supriadi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|                            |NotReady
                 CC|                            |[e-mail]

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #8 from Jaroslav Škarvada  ---
Upstream already ported the code to the Python 3. This review request needs
updated package.

I am going to update it.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #9 from Jaroslav Škarvada  ---
New version, python3 ready:
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52-0.2.20210908git36896e5...

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

Didik Supriadi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|NotReady                    |

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

Zdenek Dohnal  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|needinfo?(jskarvad@redhat.c |
                   |om)                         |

--- Comment #11 from Zdenek Dohnal  ---
jskarvad's request is still valid, clearing the NEEDINFO for him because he's
on vacation.

needinfo canceled: [Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

Product: Fedora
Version: rawhide
Component: Package Review

Zdenek Dohnal  has canceled Package Review
's request for Jaroslav Škarvada
's needinfo:
Bug 1684603: Review Request: bCNC - GRBL CNC command sender, autoleveler and
G-code editor
https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #11 from Zdenek Dohnal  ---
jskarvad's request is still valid, clearing the NEEDINFO for him because he's
on vacation.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

Benson Muite  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?
                 CC|                            |[e-mail]

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #12 from Benson Muite  ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "MIT License",
     "GNU General Public License, Version 2", "*No copyright* GNU General
     Public License, Version 2", "GNU General Public License v2.0 or
     later". 348 files have unknown license. Detailed output of
     licensecheck in
     /home/FedoraPackaging/reviews/bCNC/1684603-bCNC/licensecheck.txt
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/icons/hicolor,
     /usr/share/icons/hicolor/256x256,
     /usr/share/icons/hicolor/256x256/apps
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[?]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[ ]: Python eggs must not download any dependencies during the build
     process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[?]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Spec file according to URL is the same as in SRPM.

Installation errors
-------------------
INFO: mock.py version 3.1 starting (python version = 3.10.7, NVR =
mock-3.1-1.fc36)...
Start(bootstrap): init plugins
INFO: selinux enabled
Finish(bootstrap): init plugins
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Start(bootstrap): chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start(bootstrap): cleaning package manager metadata
Finish(bootstrap): cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 3.1
INFO: Mock Version: 3.1
Finish(bootstrap): chroot init
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 3.1
INFO: Mock Version: 3.1
Finish: chroot init
INFO: installing package(s):
/builddir/bCNC-0.9.14.52-0.2.20210908git36896e5f.fc38.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 9eced9ac9ba04e9390184e94847bdab3 -D
/var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock
--bind=/tmp/mock-resolv.g4wonmyc:/etc/resolv.conf --console=pipe
--setenv=TERM=vt100 --setenv=SHELL=/bin/bash
--setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir
--setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin
--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"
--setenv=PS1=<mock-chroot> \s-\v$  --setenv=LANG=C.UTF-8
--setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot
/var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 38
--setopt=deltarpm=False --allowerasing --disableplugin=local
--disableplugin=spacewalk --disableplugin=versionlock install
/builddir/bCNC-0.9.14.52-0.2.20210908git36896e5f.fc38.noarch.rpm
--setopt=tsflags=nocontexts

Rpmlint
-------
Cannot parse rpmlint output:

Source checksums
----------------
https://github.com/vlachoudis/bCNC/archive/36896e5fee627b4760d0c2378cc0463f7...
:
  CHECKSUM(SHA256) this package     :
74da90544b1c4554095284a861d1e02bd95804bb2ca7d3b914675438186ecc53
  CHECKSUM(SHA256) upstream package :
74da90544b1c4554095284a861d1e02bd95804bb2ca7d3b914675438186ecc53

Requires
--------
bCNC (rpmlib, GLIBC filtered):
    /usr/bin/python3
    config(bCNC)
    python(abi)
    python3.11dist(numpy)
    python3.11dist(opencv-python)
    python3.11dist(pillow)
    python3.11dist(pyserial)

Provides
--------
bCNC:
    application()
    application(bCNC.desktop)
    bCNC
    config(bCNC)
    python3.11dist(bcnc)
    python3dist(bcnc)

Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 1684603
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Shell-api, Generic
Disabled plugins: C/C++, PHP, fonts, SugarActivity, Perl, R, Haskell, Ruby,
Ocaml, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Initial Comments:
a) See Python packaging guidelines,
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/ consider
naming slightly differently
b) Builds on all architectures:
https://copr.fedorainfracloud.org/coprs/fed500/bCNC/build/4944630/
c) Installation failure likely due to the issue
https://bugzilla.redhat.com/show_bug.cgi?id=2132574
d) Tests are included in the software, can they be run?
e) Newer tag is available, perhaps this can be packaged? One of the tags is
PyPi, rather than a numeric tag, perhaps check with upstream why this was done.
f) Add a license breakdown:
*No copyright* GNU General Public License, Version 2
----------------------------------------------------
bCNC-36896e5fee627b4760d0c2378cc0463f7bf3c3e9/setup.py

BSD 3-Clause License
--------------------
bCNC-36896e5fee627b4760d0c2378cc0463f7bf3c3e9/LICENSE.BSD3
bCNC-36896e5fee627b4760d0c2378cc0463f7bf3c3e9/bCNC/lib/ttf.py

GNU General Public License v2.0 or later
----------------------------------------
bCNC-36896e5fee627b4760d0c2378cc0463f7bf3c3e9/bCNC/lib/imageToGcode.py

GNU General Public License, Version 2
-------------------------------------
bCNC-36896e5fee627b4760d0c2378cc0463f7bf3c3e9/LICENSE.md
bCNC-36896e5fee627b4760d0c2378cc0463f7bf3c3e9/bCNC/lib/svgcode.py

MIT License
-----------
bCNC-36896e5fee627b4760d0c2378cc0463f7bf3c3e9/LICENSE.MIT
bCNC-36896e5fee627b4760d0c2378cc0463f7bf3c3e9/tests/arduino-loopback/test-loopback.py

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #13 from Jaroslav Škarvada  ---
Thanks for the review.
> Initial Comments:
> a) See Python packaging guidelines,
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/
> consider naming slightly differently

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_nami...
"This rule does not apply to applications."
> b) Builds on all architectures:
> https://copr.fedorainfracloud.org/coprs/fed500/bCNC/build/4944630/

What's wrong? It seems it builds OK.
> c) Installation failure likely due to the issue
> https://bugzilla.redhat.com/show_bug.cgi?id=2132574

Probably nothing to fix here on our side.
> d) Tests are included in the software, can they be run?

I will check.
> e) Newer tag is available, perhaps this can be packaged? One of the tags is

I will check, it's quite long time this review request was submitted.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #14 from Jaroslav Škarvada  ---
New version:
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20210908git36896e5f-1....

Regarding the tests, the upstream test suite is broken - it uses PIP to install
specific package versions which will not work in Fedora and we also don't have
this specific versions. Maybe I will try to fix it later, but I think it isn't
currently prio.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #15 from Jaroslav Škarvada  ---
Regarding the version, I could refresh the snapshot.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #16 from Jaroslav Škarvada  ---
New snapshot:
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20221017git523f1ec7-1....

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #17 from Benson Muite  ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "MIT License",
     "GNU General Public License, Version 2", "*No copyright* GNU General
     Public License, Version 2", "GNU General Public License v2.0 or
     later". 351 files have unknown license. Detailed output of
     licensecheck in
     /home/FedoraPackaging/reviews/bCNC/1684603-bCNC/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[?]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/icons/hicolor/256x256,
     /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[?]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[?]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Spec file according to URL is the same as in SRPM.

Installation errors
-------------------
INFO: mock.py version 3.1 starting (python version = 3.10.7, NVR =
mock-3.1-1.fc36)...
Start(bootstrap): init plugins
INFO: selinux enabled
Finish(bootstrap): init plugins
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Start(bootstrap): chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start(bootstrap): cleaning package manager metadata
Finish(bootstrap): cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 3.1
INFO: Mock Version: 3.1
Finish(bootstrap): chroot init
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 3.1
INFO: Mock Version: 3.1
Finish: chroot init
INFO: installing package(s):
/builddir/bCNC-0.9.14.52~20221017git523f1ec7-1.fc38.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 10ca26a7e1054986bfdb064967e38030 -D
/var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock
--bind=/tmp/mock-resolv.qpdgwf8_:/etc/resolv.conf --console=pipe
--setenv=TERM=vt100 --setenv=SHELL=/bin/bash
--setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir
--setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin
--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"
--setenv=PS1=<mock-chroot> \s-\v$  --setenv=LANG=C.UTF-8
--setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot
/var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 38
--setopt=deltarpm=False --allowerasing --disableplugin=local
--disableplugin=spacewalk --disableplugin=versionlock install
/builddir/bCNC-0.9.14.52~20221017git523f1ec7-1.fc38.noarch.rpm
--setopt=tsflags=nocontexts

Rpmlint
-------
Cannot parse rpmlint output:

Source checksums
----------------
https://github.com/vlachoudis/bCNC/archive/523f1ec75d839de5d599420bb5b751f90...
:
  CHECKSUM(SHA256) this package     :
0b50925fe298ddf474c3e8ad1e193a91d3cd3ea55c037446ccc2082ef75f6737
  CHECKSUM(SHA256) upstream package :
0b50925fe298ddf474c3e8ad1e193a91d3cd3ea55c037446ccc2082ef75f6737

Requires
--------
bCNC (rpmlib, GLIBC filtered):
    /usr/bin/python3
    config(bCNC)
    python(abi)
    python3.11dist(numpy)
    python3.11dist(opencv-python)
    python3.11dist(pillow)
    python3.11dist(pyserial)

Provides
--------
bCNC:
    application()
    application(bCNC.desktop)
    bCNC
    config(bCNC)
    python3.11dist(bcnc)
    python3dist(bcnc)

Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 1684603
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: Ocaml, Java, R, Perl, Haskell, C/C++, Ruby, fonts, PHP,
SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comments:
a) Installation seems like an error with Fedora-review,
https://bugzilla.redhat.com/show_bug.cgi?id=2132574, but checking
b) A typical warning in the build log
writing manifest file 'bCNC.egg-info/SOURCES.txt'
/usr/lib/python3.11/site-packages/setuptools/command/build_py.py:202:
SetuptoolsDeprecationWarning:  
   Installing 'bCNC.controllers' as data is deprecated, please list it in
`packages`.
    !!
    ############################
    # Package would be ignored #
    ############################
    Python recognizes 'bCNC.controllers' as an importable package,
    but it is not listed in the `packages` configuration of setuptools.
    'bCNC.controllers' has been automatically added to the distribution only
    because it may contain data files, but this behavior is likely to change
    in future versions of setuptools (and therefore is considered deprecated).
    Please make sure that 'bCNC.controllers' is included as a package by using
    the `packages` configuration field or the proper discovery methods
    (for example by using `find_namespace_packages(...)`/`find_namespace:`
    instead of `find_packages(...)`/`find:`).
    You can read more about "package discovery" and "data files" on setuptools
    documentation page.
!!
  check.warn(importable)

c) Please add a comment in the spec file about the tests not working at
present, so that this can be checked when updates are made.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #18 from Jaroslav Škarvada  ---
Comments:
> a) Installation seems like an error with Fedora-review,
> https://bugzilla.redhat.com/show_bug.cgi?id=2132574, but checking

Probably.
> b) A typical warning in the build log
> writing manifest file 'bCNC.egg-info/SOURCES.txt'
> /usr/lib/python3.11/site-packages/setuptools/command/build_py.py:202:
> SetuptoolsDeprecationWarning:  
>    Installing 'bCNC.controllers' as data is deprecated, please list it in
> `packages`.
>     !!
>     ############################
>     # Package would be ignored #
>     ############################
>     Python recognizes 'bCNC.controllers' as an importable package,
>     but it is not listed in the `packages` configuration of setuptools.
>     'bCNC.controllers' has been automatically added to the distribution only
>     because it may contain data files, but this behavior is likely to change
>     in future versions of setuptools (and therefore is considered
> deprecated).
>     Please make sure that 'bCNC.controllers' is included as a package by
> using
>     the `packages` configuration field or the proper discovery methods
>     (for example by using `find_namespace_packages(...)`/`find_namespace:`
>     instead of `find_packages(...)`/`find:`).
>     You can read more about "package discovery" and "data files" on
> setuptools
>     documentation page.
> !!
>   check.warn(importable)

Fixed.
> c) Please add a comment in the spec file about the tests not working at
> present, so that this can be checked when updates are made.

Added.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #19 from Jaroslav Škarvada  ---
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20221017git523f1ec7-2....

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #20 from Benson Muite  ---
Thanks for updating the package.  When building on Debian, several linux
packages 
are installed, see https://github.com/vlachoudis/bCNC/blob/master/.travis.yml
The Fedora equivalents are:
 libpng-devel
 zlib-dev
 libXtst-devel
 opencv-devel
 socat
 wmctrl
 xdotool
 fluxbox
 scrot
Should these also be listed in BuildRequires? Possibly also Requires? Missing
dependencies can be a reason for a failed installation.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #21 from Benson Muite  ---
For the updated package, following issue is raised:
Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/icons/hicolor/256x256,
     /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #22 from Jaroslav Škarvada  ---
(In reply to Benson Muite from comment #20)
> Thanks for updating the package.  When building on Debian, several linux
> packages 
> are installed, see https://github.com/vlachoudis/bCNC/blob/master/.travis.yml

Adding explicit requirements isn't generally good way to go, the implicit
requirements are usually enough. Moreover, there is bCNC/requirements.txt:
pyserial>=3.5
numpy>=1.12
Pillow>=4.0
opencv-python==4.5.5.62
> libpng-devel
>  zlib-dev
>  libXtst-devel
>  opencv-devel

bCNC is noarch python package, so I really don't understand why it should
require arch devel packages, could you elaborate? The opencv is covered by
python3-opencv.
> socat

fake-grbl.sh, we don't ship it
> wmctrl
>  xdotool
>  scrot

No idea where and if ever it is used. I wasn't able to find in the source code,
thus probably nothing important which should break the package.
> fluxbox

This really shouldn't be explicitly required.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #23 from Jaroslav Škarvada  ---
(In reply to Benson Muite from comment #21)
> For the updated package, following issue is raised:
> Package must own all directories that it creates.
>      Note: Directories without known owners:
>      /usr/share/icons/hicolor/256x256,
>      /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor

Fixed, explicitly owned the dirs.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #24 from Jaroslav Škarvada  ---
(In reply to Jaroslav Škarvada from comment #23)
> (In reply to Benson Muite from comment #21)
> > For the updated package, following issue is raised:
> > Package must own all directories that it creates.
> >      Note: Directories without known owners:
> >      /usr/share/icons/hicolor/256x256,
> >      /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor
>
> Fixed, explicitly owned the dirs.

Well, maybe better fix is to require the hicolor-icon-theme, I fixed it this
way.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #25 from Jaroslav Škarvada  ---
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20221017git523f1ec7-3....

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #26 from Benson Muite  ---
It still fails to install. Tried adding the additional dependencies, and this
did not help. 
Try a copr build with -fedora-review enabled to see this.

Tried using

mock install -r /etc/mock/fedora-rawhide-x86_64.cfg
bCNC-0.9.14.52~20221017git523f1ec7-3.fc38.noarch.rpm

and got

Error: 
 Problem: conflicting requests
  - nothing provides python3.11dist(opencv-python) = 4.5.5.62 needed by
bCNC-0.9.14.52~20221017git523f1ec7-3.fc38.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use
not only best candidate packages)
ERROR: Command failed:

Perhaps check if
https://packages.fedoraproject.org/pkgs/opencv/python3-opencv/
will work, and then relax the requirement for the version and/or file a bug
upstream

It seems python3-opencv is optional
https://github.com/vlachoudis/bCNC#installation-manual
Though it is used in Ubuntu
https://packages.ubuntu.com/jammy/bcnc

As per the Readme, you might consider adding scipy for a better user experience

Can jquery be unbundled and the packaged version used:
https://github.com/vlachoudis/bCNC/tree/master/bCNC/pendant
https://packages.fedoraproject.org/pkgs/js-jquery/js-jquery/
Similarly fastclick
https://www.npmjs.com/package/fastclick
is bundled. Could this be packaged and unbundled?

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #27 from Jaroslav Škarvada  ---
(In reply to Benson Muite from comment #26)
> It still fails to install. Tried adding the additional dependencies, and
> this did not help. 
> Try a copr build with -fedora-review enabled to see this.
>
> Tried using
>
> mock install -r /etc/mock/fedora-rawhide-x86_64.cfg
> bCNC-0.9.14.52~20221017git523f1ec7-3.fc38.noarch.rpm
>
> and got
>
> Error: 
>  Problem: conflicting requests
> nothing provides python3.11dist(opencv-python) = 4.5.5.62 needed by
>
> bCNC-0.9.14.52~20221017git523f1ec7-3.fc38.noarch
> (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to
> use not only best candidate packages)
> ERROR: Command failed:

It seems the setup.py requirements are unnecessary tight. I will relax it.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #28 from Jaroslav Škarvada  ---
python-opencv is for optional webcam streaming

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #29 from Jaroslav Škarvada  ---
I will probably add scipy as recommends.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #30 from Jaroslav Škarvada  ---
(In reply to Benson Muite from comment #26)

Both bundled packages are used for web iface.
> Can jquery be unbundled and the packaged version used:
> https://github.com/vlachoudis/bCNC/tree/master/bCNC/pendant
> https://packages.fedoraproject.org/pkgs/js-jquery/js-jquery/

Unbundled. The bundled version is a quite prehistoric variant, but jQuery is
known for a good backward compatibility. I haven't tested it, because at the
moment I don't have CNC machine handy, so any feedback is welcome.
> Similarly fastclick
> https://www.npmjs.com/package/fastclick
> is bundled. Could this be packaged and unbundled?

I don't think it's worth packaging this abandoned library, moreover it's
already bundled in some Fedora packages, thus I just added the bundled()
keyword. Unfortunately, I wasn't able to figure out the bundled version, thus I
used the unversioned variant.

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #31 from Jaroslav Škarvada  ---
Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20221017git523f1ec7-4....

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #32 from Benson Muite  ---
Some rpmlint warnings:

$ rpmlint bCNC-0.9.14.52~20221017git523f1ec7-4.fc38.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

bCNC.spec:38: W: unversioned-explicit-provides bundled(fastclick)
bCNC.spec:67: W: macro-in-comment %{buildroot}
bCNC.spec:67: W: macro-in-comment %{python3_sitelib}
bCNC.src: W: invalid-license GPL-2.0-only
bCNC.src: W: invalid-license GPL-2.0-or-later
bCNC.src: W: invalid-license BSD-3-Clause
 1 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken
3.8 s

$ rpmlint bCNC-0.9.14.52~20221017git523f1ec7-4.fc38.noarch.rpm
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

bCNC.noarch: W: python-bytecode-without-source
/usr/lib/python3.11/site-packages/bCNC/lib/python_utils/__pycache__/compat.cpython-311.opt-1.pyc
bCNC.noarch: W: python-bytecode-without-source
/usr/lib/python3.11/site-packages/bCNC/lib/python_utils/__pycache__/compat.cpython-311.pyc
bCNC.noarch: E: non-executable-script
/usr/lib/python3.11/site-packages/bCNC/__main__.py 644 /usr/bin/env python3
bCNC.noarch: E: non-executable-script
/usr/lib/python3.11/site-packages/bCNC/bmain.py 644 /usr/bin/env python3
bCNC.noarch: W: no-manual-page-for-binary bCNC
bCNC.noarch: W: invalid-license GPL-2.0-only
bCNC.noarch: W: invalid-license GPL-2.0-or-later
bCNC.noarch: W: invalid-license BSD-3-Clause
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/exclamation.gif
/usr/share/bCNC/icons/debug.gif
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pan.gif
/usr/share/bCNC/icons/move.gif
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pocket.gif
/usr/share/bCNC/icons/offset.gif
bCNC.noarch: W: dangling-symlink
/usr/lib/python3.11/site-packages/bCNC/pendant/jquery-2.1.4.min.js
/usr/share/javascript/jquery/latest/jquery.min.js
 1 packages and 0 specfiles checked; 2 errors, 10 warnings, 2 badness; has
taken 2.3 s

Comments:
a) Dangling symlink seems ok.
b) License warning is spurious

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #33 from Jaroslav Škarvada  ---
(In reply to Benson Muite from comment #32)
> bCNC.noarch: W: python-bytecode-without-source
> /usr/lib/python3.11/site-packages/bCNC/lib/python_utils/__pycache__/compat.
> cpython-311.opt-1.pyc
> bCNC.noarch: W: python-bytecode-without-source
> /usr/lib/python3.11/site-packages/bCNC/lib/python_utils/__pycache__/compat.
> cpython-311.pyc

It seems it's bundled python3-utils and python3-numpy-stl. I tried to unbundle
them (hopefully, I can't test it at the moment). Also it seems there is some
more code bundled. I was able to recognize svgcode 0.2, it's probably not worth
to package it (one class, 80 lines). I added the "bundled" record for it.
> bCNC.noarch: E: non-executable-script
> /usr/lib/python3.11/site-packages/bCNC/__main__.py 644 /usr/bin/env python3
> bCNC.noarch: E: non-executable-script
> /usr/lib/python3.11/site-packages/bCNC/bmain.py 644 /usr/bin/env python3

Dropped the shebangs.
> bCNC.noarch: W: no-manual-page-for-binary bCNC
> bCNC.noarch: W: invalid-license GPL-2.0-only
> bCNC.noarch: W: invalid-license GPL-2.0-or-later
> bCNC.noarch: W: invalid-license BSD-3-Clause

SPDX, probably OK.
> bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/exclamation.gif
> /usr/share/bCNC/icons/debug.gif
> bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pan.gif
> /usr/share/bCNC/icons/move.gif
> bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pocket.gif
> /usr/share/bCNC/icons/offset.gif

Upstream reuses the same icons, I think it's not worth to add hacks/symlinks to
spare few bytes even if upstream could change the icons anytime without prior
notice.
> bCNC.noarch: W: dangling-symlink
> /usr/lib/python3.11/site-packages/bCNC/pendant/jquery-2.1.4.min.js
> /usr/share/javascript/jquery/latest/jquery.min.js

Not clean but intended.

Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20221017git523f1ec7-5....

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

--- Comment #34 from Benson Muite  ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "MIT License",
     "GNU General Public License, Version 2", "*No copyright* GNU General
     Public License, Version 2", "GNU General Public License v2.0 or
     later". 351 files have unknown license. Detailed output of
     licensecheck in /home/fedora-packaging/1684603-bCNC/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[?]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: bCNC-0.9.14.52~20221017git523f1ec7-5.fc38.noarch.rpm
          bCNC-0.9.14.52~20221017git523f1ec7-5.fc38.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpbu_lts6e')]
checks: 31, packages: 2

bCNC.spec:41: W: unversioned-explicit-provides bundled(fastclick)
bCNC.noarch: W: no-manual-page-for-binary bCNC
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/exclamation.gif
/usr/share/bCNC/icons/debug.gif
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pan.gif
/usr/share/bCNC/icons/move.gif
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pocket.gif
/usr/share/bCNC/icons/offset.gif
bCNC.noarch: W: dangling-symlink
/usr/lib/python3.11/site-packages/bCNC/pendant/jquery-2.1.4.min.js
/usr/share/javascript/jquery/latest/jquery.min.js
 2 packages and 0 specfiles checked; 0 errors, 6 warnings, 0 badness; has taken
1.3 s

Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

bCNC.noarch: W: no-manual-page-for-binary bCNC
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/exclamation.gif
/usr/share/bCNC/icons/debug.gif
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pan.gif
/usr/share/bCNC/icons/move.gif
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pocket.gif
/usr/share/bCNC/icons/offset.gif
bCNC.noarch: W: dangling-symlink
/usr/lib/python3.11/site-packages/bCNC/pendant/jquery-2.1.4.min.js
/usr/share/javascript/jquery/latest/jquery.min.js
 1 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken
0.7 s

Source checksums
----------------
https://github.com/vlachoudis/bCNC/archive/523f1ec75d839de5d599420bb5b751f90...
:
  CHECKSUM(SHA256) this package     :
0b50925fe298ddf474c3e8ad1e193a91d3cd3ea55c037446ccc2082ef75f6737
  CHECKSUM(SHA256) upstream package :
0b50925fe298ddf474c3e8ad1e193a91d3cd3ea55c037446ccc2082ef75f6737

Requires
--------
bCNC (rpmlib, GLIBC filtered):
    /usr/bin/python3
    config(bCNC)
    hicolor-icon-theme
    js-jquery
    python(abi)
    python3-numpy-stl
    python3-opencv
    python3-utils
    python3.11dist(numpy)
    python3.11dist(pillow)
    python3.11dist(pyserial)

Provides
--------
bCNC:
    application()
    application(bCNC.desktop)
    bCNC
    bundled(fastclick)
    bundled(svgcode)
    config(bCNC)
    python3.11dist(bcnc)
    python3dist(bcnc)

Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 1684603
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, R, Haskell, fonts, PHP, Perl, C/C++, Ocaml,
SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

$ rpmlint bCNC-0.9.14.52~20221017git523f1ec7-5.fc38.noarch.rpm
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

bCNC.noarch: W: no-manual-page-for-binary bCNC
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/exclamation.gif
/usr/share/bCNC/icons/debug.gif
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pan.gif
/usr/share/bCNC/icons/move.gif
bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pocket.gif
/usr/share/bCNC/icons/offset.gif
bCNC.noarch: W: dangling-symlink
/usr/lib/python3.11/site-packages/bCNC/pendant/jquery-2.1.4.min.js
/usr/share/javascript/jquery/latest/jquery.min.js
 1 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken
20.1 s 
$ rpmlint bCNC-0.9.14.52~20221017git523f1ec7-5.fc38.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1

bCNC.spec:41: W: unversioned-explicit-provides bundled(fastclick)
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken
9.5 s

Comments:
a) Fastclick has been archived: https://github.com/ftlabs/fastclick
It seems ok to bundle, though packaging it separately would be ideal. Where
else is it used in Fedora?
Maybe someone may want to maintain it?
b) SVGcode seemps to be maintained in the repository
https://github.com/vlachoudis/bCNC/tree/master/bCNC/lib
There is a related project on Pypi https://github.com/PadLex/SvgToGcode but
this is not the one that is used
c) The repository has text for MIT and BSD licenses,
https://github.com/vlachoudis/bCNC can these be included?
d) In the spec file, perhaps also add information that the compat folder
includes bytecode, that is why it is
removed.
e) There is a smoke test https://github.com/vlachoudis/bCNC/tree/master/tests
can this be run?

needinfo canceled: [Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

Product: Fedora
Version: rawhide
Component: Package Review

Benson Muite  has canceled Package Review
's request for Benson Muite
's needinfo:
Bug 1684603: Review Request: bCNC - GRBL CNC command sender, autoleveler and
G-code editor
https://bugzilla.redhat.com/show_bug.cgi?id=1684603

[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

https://bugzilla.redhat.com/show_bug.cgi?id=1684603

Benson Muite  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(benson_muite@emai |
                   |lplus.org)                  |