Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221004
Summary: Review Request: jeta - Horde SSH Java Applet Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fedora@theholbrooks.org QAContact: fedora-package-review@redhat.com
Spec URL: http://theholbrooks.org/RPMS/jeta.spec SRPM URL: http://theholbrooks.org/RPMS/jeta-0-1.0.rc2.1.src.rpm
Description: Jeta is the Horde module that provides a Java SSH interface to login to the webserver (or another server with the use of additional relay software).
The Horde Project writes web applications in PHP and releases them under Open Source licenses. For more information (including help with jeta) please visit http://www.horde.org/.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: jeta - Horde SSH Java Applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221004
------- Additional Comments From fedora@theholbrooks.org 2006-12-30 04:56 EST ------- Since JTA explicitly says in several locations that is for "non-commercial use only", I removed all traces of it from this package. It still functions fine with SSHTermApplet (which is the default anyway). One last issue we may need to work out: jeta is currently set to "inactive" in horde's registry.php, but Jeta doesn't show up and won't do anything until that gets changed to "active". Should we programmatically do that upon install or inform our users that they need to do that manually?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: jeta - Horde SSH Java Applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221004
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2007-01-28 02:14 EST ------- I promise not to take so long with this one.
First off, the release should be "0.1.rc2%{?dist}"; you can append ".1" once the package is in the repo and you need to tweak a non-development branch without rebuilding any of the newer branches.
About registry.php, what stops us from just shipping the horde package with jeta enabled in registry.php? I don't think it's worth it to try and change it; that can get rather complicated and it's best to avoid that kind of thing unless it's really trivial to do, and even then it's still usually better to just leave it up to the admin.
I guess the fundamental question is why upstream doesn't enable jeta by default. I suppose it's because it hasn't been released yet. Or do things break if "status" is set to "active" when the application isn't installed?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: jeta - Horde SSH Java Applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221004
------- Additional Comments From fedora@theholbrooks.org 2007-01-28 21:33 EST ------- Before you get too far... I just got an email from horde's announce list that jeta 1.0 final was just released today. Stand by until I get new RPMs up!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: jeta - Horde SSH Java Applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221004
------- Additional Comments From fedora@theholbrooks.org 2007-01-28 22:00 EST ------- Spec URL: http://theholbrooks.org/RPMS/jeta.spec SRPM URL: http://theholbrooks.org/RPMS/jeta-1.0-1.src.rpm
New 1.0 final RPMs. As I'm sure future versions of horde will start shipping jeta pre-enabled, I will do the same in horde's registry.php
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: jeta - Horde SSH Java Applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221004
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2007-02-17 23:40 EST ------- So, first the usual rpmlint errors that we see with these apps:
W: jeta conffile-without-noreplace-flag /etc/horde/jeta/conf.xml W: jeta conffile-without-noreplace-flag /etc/horde/jeta/prefs.php.dist Indeed, these should not be noreplace.
E: jeta non-standard-uid /etc/horde/jeta/prefs.php apache E: jeta non-standard-gid /etc/horde/jeta/prefs.php apache E: jeta non-readable /etc/horde/jeta/prefs.php 0660 E: jeta non-standard-uid /etc/horde/jeta apache E: jeta non-standard-gid /etc/horde/jeta apache E: jeta non-standard-dir-perm /etc/horde/jeta 0770 E: jeta non-standard-uid /etc/horde/jeta/conf.xml apache E: jeta non-standard-gid /etc/horde/jeta/conf.xml apache E: jeta non-readable /etc/horde/jeta/conf.xml 0660 E: jeta non-standard-uid /etc/horde/jeta/prefs.php.dist apache E: jeta non-standard-gid /etc/horde/jeta/prefs.php.dist apache E: jeta non-readable /etc/horde/jeta/prefs.php.dist 0640 Ownerships and permissions are as necessary for this application.
E: jeta htaccess-file /usr/share/horde/jeta/lib/.htaccess Indeed, this is an .htaccess file. I do now understand why rpmlint complains here: it is better to include such restrictions in the apache config file, and then apache can be set to "AllowOverride none", improving performance. Perhaps something to think about for future revisions.
So everything's fine with this package. I had to enable it manually in registry.php, and I think the horde package should just enable it. I imagine upstream will change things in the next horde release now that jeta is officially released.
* source files match upstream: 6abf801d70452f1186af1cd6415cde582dcb41b81fe30a1ef09db575cc46bd70 jeta-h3-1.0.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. * License text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint output is OK. * final provides and requires are sane: jeta-1.0-1.fc7.noarch.rpm config(jeta) = 1.0-1.fc7 jeta = 1.0-1.fc7 = config(jeta) = 1.0-1.fc7 horde >= 3 php >= 4.3.0
* %check is not present; manual testing shows that things work fine. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: jeta - Horde SSH Java Applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221004
fedora@theholbrooks.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From fedora@theholbrooks.org 2007-03-01 01:23 EST ------- New Package CVS Request ======================= Package Name: jeta Short Description: Horde Java SSH Application Owners: fedora@theholbrooks.org Branches: FC-5 FC-6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: jeta - Horde SSH Java Applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221004
petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: jeta - Horde SSH Java Applet
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221004
fedora@theholbrooks.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From fedora@theholbrooks.org 2007-03-03 00:46 EST ------- Imported, tagged, built.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla