https://bugzilla.redhat.com/show_bug.cgi?id=1491712
Bug ID: 1491712 Summary: Review Request: atanua - Real Time Logic Simulator Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: lkundrak@v3.sk QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Depends On: 1491710
Note this is a re-review of a package that used to be in Fedora but was retired because GLee dependency was orphaned.
SPEC: http://pkgs.fedoraproject.org/cgit/rpms/atanua.git/plain/atanua.spec?id=c559... SRPM: https://kojipkgs.fedoraproject.org//packages/atanua/1.3.141220/6.fc26/src/at... mock: https://koji.fedoraproject.org/koji/buildinfo?buildID=840701
Description:
Atanua is a real-time logic simulator, designed to help in learning of basic boolean logic and electronics. It uses OpenGL hardware-accelerated rendering and a custom UI designed for a fast workflow and a very low learning curve, letting the students concentrate on learning the subject instead of spending time learning the tool.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1491710 [Bug 1491710] Review Request: GLee - GL Easy Extension library
https://bugzilla.redhat.com/show_bug.cgi?id=1491712
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |anto.trande@gmail.com
--- Comment #1 from Antonio Trande anto.trande@gmail.com --- Hi.
Is open source version still developed? I don't see any commit since near 3 years.
https://bugzilla.redhat.com/show_bug.cgi?id=1491712
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- All okay, package accepted.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (3 clause)", "*No copyright* zlib/libpng", "Unknown or generated", "zlib/libpng". 273 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/atanua/review-atanua/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in atanua [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in atanua- debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1126400 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: atanua-1.3.141220-6.fc28.x86_64.rpm atanua-debuginfo-1.3.141220-6.fc28.x86_64.rpm atanua-1.3.141220-6.fc28.src.rpm atanua.x86_64: W: spelling-error %description -l en_US boolean -> Boolean, boo lean, boo-lean atanua.x86_64: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce atanua.x86_64: W: only-non-binary-in-usr-lib atanua.x86_64: W: no-manual-page-for-binary atanua atanua.src: W: spelling-error %description -l en_US boolean -> Boolean, boo lean, boo-lean atanua.src: W: spelling-error %description -l en_US workflow -> work flow, work-flow, workforce atanua.src:99: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 99) 3 packages and 0 specfiles checked; 0 errors, 7 warnings.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com