[Bug 1321208] New: Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
Bug ID: 1321208 Summary: Review Request: julietaula-montserrat-fonts - Sans-serif typeface created by Julieta Ulanovsky Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: luya@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://luya.fedorapeople.org/packages/SPECS/julietaula-montserrat-fonts.spe... SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/julietaula-montserrat-fonts-201... Description: A typeface created by Julieta Ulanovsky inspired by signs around the Montserrat area of Buenos Aires, Argentina Fedora Account System Username: luya
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #1 from Luya Tshimbalanga luya@fedoraproject.org --- Scratch build result: http://koji.fedoraproject.org/koji/taskinfo?taskID=13450907
rpmlint result: $ rpmlint rpmbuild/SRPMS/julietaula-montserrat-fonts-20151221-1.fc23.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint rpmbuild/SPECS/julietaula-montserrat-fonts.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #2 from Luya Tshimbalanga luya@fedoraproject.org --- (In reply to Luya Tshimbalanga from comment #1)
Scratch build result: http://koji.fedoraproject.org/koji/taskinfo?taskID=13450907
Disregard the first scratch build because it is older version. http://koji.fedoraproject.org/koji/taskinfo?taskID=13451967
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i.gnatenko.brain@gmail.com
--- Comment #3 from Igor Gnatenko i.gnatenko.brain@gmail.com --- One small note - move appstream-util call to check section.
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #4 from Luya Tshimbalanga luya@fedoraproject.org --- (In reply to Igor Gnatenko from comment #3)
One small note - move appstream-util call to check section.
Done. Here is the updated spec and new srpm: SPEC url: https://luya.fedorapeople.org/packages/SPECS/julietaula-montserrat-fonts.spe...
SRMP url: https://luya.fedorapeople.org/packages/SRPMS/julietaula-montserrat-fonts-201...
Note: appdata guideline was unclear about appstream-util located on %check section, it mentioned either that or %install. Perhaps updating a spec file example for good reference.
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.txt is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
+ license is acceptable (OFL) + license file is present + version is recent (git snapshot) + provides/requires look OK + font packaging guidelines are followed
One question: why do you add separate otf, ttf subdirs? Other font packages don't do that afaics. There's a problem with directory ownership too: No known owner of /usr/share/fonts/julietaula-montserrat/otf, /usr/share/fonts/julietaula-montserrat/ttf.
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #6 from Luya Tshimbalanga luya@fedoraproject.org --- Here is the updated files addressing following issues: - Change %doc to %license - Deleted oft and ttf subdirectories
SPEC url: https://luya.fedorapeople.org/packages/SPECS/julietaula-montserrat-fonts.spe...
SRMP url: https://luya.fedorapeople.org/packages/SRPMS/julietaula-montserrat-fonts-201...
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #7 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- $ appstream-util validate /usr/share/appdata/julietaula-montserrat.metainfo.xml /usr/share/appdata/julietaula-montserrat.metainfo.xml: FAILED: • style-invalid : Not enough <p> tags for a good description Validation of files failed
Would be nice to extend the description with a second paragraph to make gnome-software happy.
No other issues. Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #8 from Luya Tshimbalanga luya@fedoraproject.org --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
$ appstream-util validate /usr/share/appdata/julietaula-montserrat.metainfo.xml /usr/share/appdata/julietaula-montserrat.metainfo.xml: FAILED: • style-invalid : Not enough <p> tags for a good description Validation of files failed
Would be nice to extend the description with a second paragraph to make gnome-software happy.
No other issues. Package is APPROVED.
Thank you, Zbigniew. appstram-util is too picky sometimes. I will do on the next update.
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- julietaula-montserrat-fonts-20151221-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d998681c55
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #10 from Igor Gnatenko i.gnatenko.brain@gmail.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
$ appstream-util validate /usr/share/appdata/julietaula-montserrat.metainfo.xml /usr/share/appdata/julietaula-montserrat.metainfo.xml: FAILED: • style-invalid : Not enough <p> tags for a good description Validation of files failed
validate-relax ;)
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- julietaula-montserrat-fonts-20151221-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2d8a0763ef
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- julietaula-montserrat-fonts-20151221-4.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ae2c22107d
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- julietaula-montserrat-fonts-20151221-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7c72af3d2a
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- julietaula-montserrat-fonts-20151221-4.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7dc6c6d417
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #15 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- (In reply to Igor Gnatenko from comment #10)
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
$ appstream-util validate /usr/share/appdata/julietaula-montserrat.metainfo.xml /usr/share/appdata/julietaula-montserrat.metainfo.xml: FAILED: • style-invalid : Not enough <p> tags for a good description Validation of files failed
validate-relax ;)
The spec file has validate-relax already, and that's the right thing to use for %check. But it's sometimes good to check what the "non-relax" version says.
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- julietaula-montserrat-fonts-20151221-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2d8a0763ef
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- julietaula-montserrat-fonts-20151221-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d998681c55
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- julietaula-montserrat-fonts-20151221-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-03-29 19:20:09
https://bugzilla.redhat.com/show_bug.cgi?id=1321208
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- julietaula-montserrat-fonts-20151221-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla