[Bug 2221358] New: Review Request: rust-rpds - Persistent data structures with structural sharing
https://bugzilla.redhat.com/show_bug.cgi?id=2221358
Bug ID: 2221358 Summary: Review Request: rust-rpds - Persistent data structures with structural sharing Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mattia.verga@proton.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://mattia.fedorapeople.org/rust-rpds/rust-rpds.spec SRPM URL: https://mattia.fedorapeople.org/rust-rpds/rust-rpds-0.13.0-1.fc39.src.rpm Description: Persistent data structures with structural sharing Fedora Account System Username: mattia
https://bugzilla.redhat.com/show_bug.cgi?id=2221358
Mattia Verga mattia.verga@proton.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2179260 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2179260 [Bug 2179260] python-jsonschema-spec-0.2.2 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2221358
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review? CC| |decathorpe@gmail.com
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- This package depends on rust-archery (RHBZ#2221357), which I've just reviewed. I'll continue this review once it's been imported and built for rawhide. PS: If you hadn't noticed the FTI issue, I recommend using the "--postinstall" flag for local mock builds.
https://bugzilla.redhat.com/show_bug.cgi?id=2221358 Bug 2221358 depends on bug 2221357, which changed state.
Bug 2221357 Summary: Review Request: rust-archery - Abstract over the atomicity of reference-counting pointers https://bugzilla.redhat.com/show_bug.cgi?id=2221357
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2221358
--- Comment #3 from Mattia Verga mattia.verga@proton.me --- Reworked specfile with "rust2rpm -p"
BTW, as I'm new to rust packaging, shouldn't the `BuildArch: noarch` tag be set on the main package? We are building the package for all arches and then provide only noarch rpms...
https://bugzilla.redhat.com/show_bug.cgi?id=2221358
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thanks, will review later!
Not having "BuildArch: no arch" apply to the whole package is intentional because we want to test build / run tests on all architectures.
https://bugzilla.redhat.com/show_bug.cgi?id=2221358
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MPL-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2221358
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- If you need help with packaging "Rusty" Python packages, feel free to reach out. Both python-orjson and python-y-py are good examples for such packages, if you want to take a stab at it yourself.
https://bugzilla.redhat.com/show_bug.cgi?id=2221358
--- Comment #7 from Mattia Verga mattia.verga@proton.me --- (In reply to Fabio Valentini from comment #6)
If you need help with packaging "Rusty" Python packages, feel free to reach out. Both python-orjson and python-y-py are good examples for such packages, if you want to take a stab at it yourself.
Yes thanks, I already used them to write down a specfile for rpds-py and it was my intention to ask in some ML to add those examples to Packaging Guidelines for easier reference.
https://bugzilla.redhat.com/show_bug.cgi?id=2221358
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rpds
https://bugzilla.redhat.com/show_bug.cgi?id=2221358
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e4afea439c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e4afea439c
https://bugzilla.redhat.com/show_bug.cgi?id=2221358
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-07-11 18:48:57
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-e4afea439c has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com