[Bug 226514] New: Merge Review: unix2dos

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514

Summary: Merge Review: unix2dos
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: unix2dos

http://cvs.fedora.redhat.com/viewcvs/devel/unix2dos/
Initial Owner: [e-mail]

[Bug 226514] Merge Review: unix2dos

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: unix2dos

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 226514] Merge Review: unix2dos

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: unix2dos

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]      |[e-mail]
                 CC|                            |[e-mail]
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From [e-mail]  2007-02-04 08:06 EST -------
Review for release 26.2.2:
* RPM name is OK
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* BuildRequires: perl should not be included
  (wiki: PackagingGuidelines#Exceptions)
* Preserve timestamps when installing files
* Consider using {?dist} in the Release tag

Notes:
* -Wall is already in RPM_OPT_FLAGS

Rpmlint is not silent:

Source RPM:
W: unix2dos summary-not-capitalized unix2dos - UNIX to DOS text file format converter
     Don't use the name in the Summary
W: unix2dos invalid-license distributable
W: unix2dos no-url-tag
W: unix2dos macro-in-%changelog description
W: unix2dos macro-in-%changelog build
W: unix2dos macro-in-%changelog description

rpmlint of unix2dos-2.2-26:
W: unix2dos summary-not-capitalized unix2dos - UNIX to DOS text file format converter
W: unix2dos invalid-license distributable
W: unix2dos no-url-tag

[Bug 226514] Merge Review: unix2dos

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: unix2dos

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514

------- Additional Comments From [e-mail]  2007-02-06 09:59 EST -------
> Preserve timestamps when installing files

Not sure what I need to change for this.
> W: unix2dos summary-not-capitalized unix2dos - UNIX to DOS text file format 
> converter
>      Don't use the name in the Summary

Got a better summary I can put in there?
> W: unix2dos invalid-license distributable

It comes with its own COPYRIGHT file, which is not a canned license.  What
should I put for 'License:'?
> W: unix2dos no-url-tag

No upstream any more as far as I can tell.

[Bug 226514] Merge Review: unix2dos

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: unix2dos

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?([e-mail])

------- Additional Comments From [e-mail]  2007-02-06 12:31 EST -------
Hi Tim,
> Not sure what I need to change for this.

To preserve timestamps, use install -p or cp -p
> Got a better summary I can put in there?

"UNIX to DOS text file format converter" sounds good to me
One of the guidelines is to not repeat the name of the package in the summary,
that's all.
> It comes with its own COPYRIGHT file, which is not a canned license.  What
> should I put for 'License:'?

I'm not sure what rpmlint thinks are valid licenses.
Distributable will do.
> No upstream any more as far as I can tell.

That's ok.

[Bug 226514] Merge Review: unix2dos

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: unix2dos

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|fedora-review-,             |fedora-review?
                   |needinfo?([e-mail])|

------- Additional Comments From [e-mail]  2007-02-06 12:39 EST -------
Okay, thanks.

Tagged and built as 2.2-27.fc7.

[Bug 226514] Merge Review: unix2dos

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: unix2dos

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-02-06 13:52 EST -------
Ah, Distributable (with a capital D) is a valid license. distributable is not.
DEFAULT_VALID_LICENSES in /usr/share/rpmlint/TagsCheck.py contains a list of valid licenses.

If you can change that, it would be nice.
Since I see no further blockers, this package is approved. Please leave the ticket assigned to yourself.

[Bug 226514] Merge Review: unix2dos

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: unix2dos

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514

------- Additional Comments From [e-mail]  2007-02-07 04:59 EST -------
Tagged and built as 2.2-28.fc7.

Thanks!

[Bug 226514] Merge Review: unix2dos

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: unix2dos

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226514

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE