[Bug 455581] New: Review Request: <php-pecl-ssh2> - <php bindings to the functions of libssh2 > - package-review

List overview All Threads
Download

newer

[Bug 455581] New: Review Request: <php-pecl-ssh2> - <php bindings to the functions of libssh2 >

older

[Bug 456138] New: Review Request:...

[Bug 445537] New: Review Request:...

Red Hat Bugzilla

16 Jul 2008 16 Jul '08

2:43 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

Summary: Review Request: <php-pecl-ssh2> - <php bindings to the functions of libssh2 > Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: itamar@ispbrasil.com.br QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://ispbrasil.com.br/php-pecl-ssh2/php-pecl-ssh2.spec SRPM URL: http://ispbrasil.com.br/php-pecl-ssh2/php-pecl-ssh2-0.10-1.fc9.src.rpm Description: since libssh2 [1] was included in fedora, should be nice to have php-pecl-ssh2 [2], because this will allow write php scripts with ssh2 support.

[1] - https://bugzilla.redhat.com/show_bug.cgi?id=398881 [2] - http://pecl.php.net/package/ssh2

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

16 Jul 16 Jul

2:54 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

https://bugzilla.redhat.com/show_bug.cgi?id=455581

paul@city-fan.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

20 Jul 20 Jul

1:47 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

https://bugzilla.redhat.com/show_bug.cgi?id=455581

ivaxer@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |ivaxer@gmail.com

------- Additional Comments From ivaxer@gmail.com 2008-07-20 07:47 EST ------- I'm not sponsored yet. I can just pre-review it:

This package does not build for me, using rpmbuild:

configure: error: The required libssh2 library was not found. You can obtain that package from http://sourceforge.net/projects/libssh2/ ошибка: Неверный код возврата из /var/tmp/rpm-tmp.85133 (%build)

I think, BuildRequires must have libssh2-devel.

Unofficial package pre-review: ======= $ rpmlint -i <src.rpm> php-pecl-ssh2.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 18) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.

php-pecl-ssh2.src: E: description-line-too-long Provides bindings to the functions of libssh2 which implements the SSH2 protocol. Your description lines must not exceed 79 characters. If a line is exceeding this number, cut it to fit in two lines.

$ rpmlint -i <rpm> php-pecl-ssh2.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.

php-pecl-ssh2.i386: E: description-line-too-long Provides bindings to the functions of libssh2 which implements the SSH2 protocol. Your description lines must not exceed 79 characters. If a line is exceeding this number, cut it to fit in two lines.

- You seem to have mixed tabs and spaces. - Try wraping description. - Package does't have any docs. May be write README or consult reviewer.

Required ======= [x] package is named according to the Package Naming Guidelines. [x] md5sum matches for source from srpm and project page. [-] package licensed with PHP license, but in .spec BSD is written. Why? [x] spec file is legible and written in American English. [-] all build dependencies listed in BuildRequires. [-] tabs and spaces mixed. [x] all filenames in rpm are in UTF-8. [-] description is okay, but needs to be wrapped. [x] no static libraries, no libtool, package does not own files or folders used by other packages, no %doc. [-] package builds and compiles using koji. Fix in BuildRequires needed. [x] consistently used macros. [x] %clean - present.

Optional ======= [?] Packaged non stable sources.

[-] = Problem or suggestion, [x] = Checked, ? = No idea.

Ok, just needs some quick fixes in my opinion.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8:34 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

https://bugzilla.redhat.com/show_bug.cgi?id=455581

------- Additional Comments From itamar@ispbrasil.com.br 2008-07-20 14:34 EST ------- fixed

Spec URL: http://ispbrasil.com.br/php-pecl-ssh2/php-pecl-ssh2.spec SRPM URL: http://ispbrasil.com.br/php-pecl-ssh2/php-pecl-ssh2-0.10-1.fc9.src.rpm

the docs are available only in http://www.php.net/manual/en/ref.ssh2.php , there are no doc's or readme in the source.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

22 Jul 22 Jul

2:20 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

https://bugzilla.redhat.com/show_bug.cgi?id=455581

------- Additional Comments From ivaxer@gmail.com 2008-07-22 08:20 EST ------- Good, this package is okey to me. Thanks.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

17 Aug 17 Aug

4:39 a.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

--- Comment #4 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2008-08-16 22:39:27 EDT --- I have forgot to say "I need a sponsor" :-)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8:39 a.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

manuel wolfshant wolfy@nobugconsulting.ro changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

14 Sep 14 Sep

8:03 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias| |php-pecl-ssh2

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

15 Nov 15 Nov

1:25 a.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 |

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:26 a.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

--- Comment #5 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2008-11-14 19:26:02 EDT --- I am now sponsored, this package is now only waiting for a review.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:48 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

--- Comment #6 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2008-11-15 10:48:48 EDT --- Improved SRPM here, with license and a readme file included.

http://ispbrasil.com.br/php-pecl-ssh2/php-pecl-ssh2.spec http://ispbrasil.com.br/php-pecl-ssh2/php-pecl-ssh2-0.10-2.fc8.src.rpm

rawhide build here:

http://koji.fedoraproject.org/koji/taskinfo?taskID=934542

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

18 Nov 18 Nov

5:56 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

Chris Weyl cweyl@alumni.drew.edu changed:

--- Comment #7 from Chris Weyl cweyl@alumni.drew.edu 2008-11-18 11:55:58 EDT --- The code is explicitly licensed under 2.01 of the PHP License, which indicates that it can be used under the terms of that license or "any future version of this license."

Spec looks sane, clean and consistent; license is correct (PHP); make test passes cleanly. Package complies with PHP-specific guidelines.

Koji scratch build looks good.

Sources match upstream:

95bdbd6a9a0d14cb65c6d6bdc9ee1770 ssh2-0.10.tgz 95bdbd6a9a0d14cb65c6d6bdc9ee1770 ssh2-0.10.tgz.srpm

Final provides/requires looks sane:

** php-pecl-ssh2-0.10-2.fc11.x86_64.rpm == rpmlint == provides config(php-pecl-ssh2) = 0.10-2.fc11 php-pecl(ssh2) = 0.10 ssh2.so()(64bit) php-pecl-ssh2 = 0.10-2.fc11 php-pecl-ssh2(x86-64) = 0.10-2.fc11 == requires /bin/sh /bin/sh /usr/bin/pecl /usr/bin/pecl config(php-pecl-ssh2) = 0.10-2.fc11 libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) libssh2.so.1()(64bit) php(api) = 20041225 php(zend-abi) = 20060613 rtld(GNU_HASH) ** php-pecl-ssh2-debuginfo-0.10-2.fc11.x86_64.rpm == rpmlint == provides php-pecl-ssh2-debuginfo = 0.10-2.fc11 php-pecl-ssh2-debuginfo(x86-64) = 0.10-2.fc11 == requires

APPROVED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:13 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

--- Comment #8 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2008-11-18 13:13:07 EDT --- New Package CVS Request ======================= Package Name: php-pecl-ssh2 Short Description: Bindings to the functions of libssh2 which implements the SSH2 protocol Owners: itamarjp Branches: F-9 F-10 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:14 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

19 Nov 19 Nov

4:50 a.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #9 from Kevin Fenzi kevin@tummy.com 2008-11-18 22:50:19 EDT --- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:23 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

--- Comment #10 from Fedora Update System updates@fedoraproject.org 2008-11-19 07:23:33 EDT --- php-pecl-ssh2-0.10-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/php-pecl-ssh2-0.10-2.fc10

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

22 Nov 22 Nov

5:59 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA

--- Comment #11 from Fedora Update System updates@fedoraproject.org 2008-11-22 11:59:30 EDT --- php-pecl-ssh2-0.10-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-pecl-ssh2'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/f10/FEDORA-2008-10000

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8 Dec 8 Dec

1:59 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

--- Comment #12 from Fedora Update System updates@fedoraproject.org 2008-12-08 07:59:53 EDT --- php-pecl-ssh2-0.10-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:59 p.m.

New subject: [Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=455581

Fedora Update System updates@fedoraproject.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

6071

Age (days ago)

6216

Last active (days ago)

package-review@lists.fedoraproject.org

18 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla