[Bug 590522] New: Review Request: plexus-cipher - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: plexus-cipher  - Plexus Cipher: encryption/decryption Component

https://bugzilla.redhat.com/show_bug.cgi?id=590522

Summary: Review Request: plexus-cipher  - Plexus Cipher:
                    encryption/decryption Component
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: <spec info here>
SRPM URL: <srpm info here>
Description: Plexus Cipher: encryption/decryption Component

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |plexus-cipher  - Plexus     |plexus-cipher-1.4-1  -
                   |Cipher:                     |Plexus Cipher:
                   |encryption/decryption       |encryption/decryption
                   |Component                   |Component

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Alexander Kurtakov  2010-05-10 03:14:47 EDT ---
You haven't put links to your spec and srpm.

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #2 from huwang  2010-05-10 03:26:33 EDT ---
Created an attachment (id=412735)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=412735)
spec file

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #3 from huwang  2010-05-10 03:31:04 EDT ---
Created an attachment (id=412737)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=412737)
SRPM

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #4 from huwang  2010-05-10 04:30:03 EDT ---
(In reply to comment #0)
> Spec URL: http://hotfile.com/dl/42162162/56b2406/plexus-cipher.spec.html
> SRPM URL: http://hotfile.com/dl/42162040/79e5c4c/plexus-cipher-1.4-1.src.rpm.html
> Description: Plexus Cipher: encryption/decryption Component

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

Chen Lei  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #412735|application/octet-stream    |text/plain
          mime type|                            |

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

Mat Booth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]       |
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #5 from Mat Booth  2010-05-12 16:03:49 EDT ---
I will take this.

I'm happy for you to continue putting your SPEC and SRPM on the bug as
attachments, by the way. :-)

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

Mat Booth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #6 from Mat Booth  2010-05-13 17:08:59 EDT ---
Those parent poms, are there any other plexus modules that might need these to
build? I'm just wondering if it is worth getting these poms into the
maven2-common-poms package like we did with the Apache commons-parent pom...

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

Guido Grazioli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Guido Grazioli  2010-05-13 17:31:31 EDT ---
(In reply to comment #6)
> Those parent poms, are there any other plexus modules that might need these to
> build? I'm just wondering if it is worth getting these poms into the
> maven2-common-poms package like we did with the Apache commons-parent pom...

Could be useful, take a look here -> bug 591454

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #8 from Mat Booth  2010-05-13 17:41:11 EDT ---
Ah, well spotted. Huwang, what do you think about making this depend on the
spice-parent package instead of bundling the pom here?

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #9 from huwang  2010-05-13 22:27:36 EDT ---
(In reply to comment #8)
> Ah, well spotted. Huwang, what do you think about making this depend on the
> spice-parent package instead of bundling the pom here?

There are 3 modules depend on spice-parent package: plexus-cipher,
plexus-build-api and plexus-sec-dispatcher. So I added spice-parent package
which is only a pom file.

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #10 from Mat Booth  2010-05-15 08:15:55 EDT ---
Excellent, please update your SPEC/SRPM and I will conduct a full review.

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #11 from Alexander Kurtakov  2010-05-19 09:11:05 EDT ---
huwang, Please do what Mat requested

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #12 from huwang  2010-05-20 04:49:22 EDT ---
(In reply to comment #10)
> Excellent, please update your SPEC/SRPM and I will conduct a full review.

Sorry for the delay, as I updated it to the latest version, please review
again, thanks a lot.

spec URL:
http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=plexus-c...

SRPM URL: 
http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=plexus-c...

Note about this package:
 It built with dist-f14-maven221 target, koji building link is
http://koji.fedoraproject.org/koji/taskinfo?taskID=2198806

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #13 from huwang  2010-05-20 07:26:38 EDT ---
Rebuilt in koji with dist-f14-maven221 target, the link is
http://koji.fedoraproject.org/koji/taskinfo?taskID=2198918

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #14 from Mat Booth  2010-05-21 07:42:21 EDT ---
Hmm, I rebuilt your SPRM again myself, and this time it failed:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2200828

Also, in both our builds, it fails to get this pom file:
JPP/maven2/default_poms/JPP-apache-commons-logging.pom

Seems like it should be finding this one first anyway:
JPP/maven2/poms/JPP-commons-logging.pom

What's going on there?

Also, please provide a valid url in the spec file URL tag.

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

Stanislav Ochotnicky  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Stanislav Ochotnicky  2010-05-21 07:58:00 EDT ---
I am sorry, this is actually a problem in commons-logging. I am fixing it right
now. Sorry for causing trouble...

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #16 from Mat Booth  2010-05-21 08:05:27 EDT ---
No problem, thanks for your attention Stanislav :-)

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #17 from Stanislav Ochotnicky  2010-05-21 08:18:36 EDT ---
Just to explain (might be useful for future):
One of the dependencies that plexus-cipher pulls in is using old
jakarta-commons-logging package I assume. It had wrong groupId (commons-logging
instead of org.apache.commons) so I had to fix it when I renamed package to
apache-commons-logging. I tried to keep backward compatibility but I forgot to
change one call to use correct name...

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #18 from Mat Booth  2010-05-21 11:05:41 EDT ---
Ok the commons-logging thing has been fixed, but it still fails to build for
me:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2201405

[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Internal error in the plugin manager executing goal
'org.apache.maven.plugins:maven-javadoc-plugin:2.4:javadoc': Unable to find the
mojo 'org.apache.maven.plugins:maven-javadoc-plugin:2.4:javadoc' in the plugin
'org.apache.maven.plugins:maven-javadoc-plugin'
org.apache.maven.doxia.logging.LogEnabled
[INFO] ------------------------------------------------------------------------

I'm not sure what "Unable to find the mojo" means, is it a problem with this
package or a problem in the maven javadoc plugin?

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #19 from huwang  2010-05-24 22:43:45 EDT ---
(In reply to comment #18)
> Ok the commons-logging thing has been fixed, but it still fails to build for
> me:
>
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2201405
>
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Internal error in the plugin manager executing goal
> 'org.apache.maven.plugins:maven-javadoc-plugin:2.4:javadoc': Unable to find the
> mojo 'org.apache.maven.plugins:maven-javadoc-plugin:2.4:javadoc' in the plugin
> 'org.apache.maven.plugins:maven-javadoc-plugin'
> org.apache.maven.doxia.logging.LogEnabled
> [INFO] ------------------------------------------------------------------------
>
> I'm not sure what "Unable to find the mojo" means, is it a problem with this
> package or a problem in the maven javadoc plugin?

I think this isn't this package's problem. I built again, it isn't failed, the
link is http://koji.fedoraproject.org/koji/taskinfo?taskID=2207394

spec URL:
http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=plexus-c...

SRPM URL: 
http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=plexus-c...

please review again, thanks.

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #20 from Alexander Kurtakov  2010-05-28 03:25:22 EDT ---
Mat, 
Can you finish this?
If not please drop yourself and I'll do it. It's blocking other packages.

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #21 from Mat Booth  2010-05-28 05:51:17 EDT ---
Sorry, I have been very busy this week. I can finish it at the weekend, if that
is ok.

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #22 from Mat Booth  2010-05-31 12:00:11 EDT ---
Hi,

This builds for me now finally, thanks.

Rpmlint output:

W: spelling-error Summary(en_US) decryption
  W: spelling-error %description -l en_US decryption

Ignore these spelling warnings, "decryption" is a valid noun form of the verb
"decrypt." What a terrible dictionary it's using.

W: non-conffile-in-etc /etc/maven/fragments/plexus-cipher

This is normal and may also be ignored.

W: no-documentation

Please include the NOTICE.txt file as documentation in the main package.

W: invalid-url URL: http://spice.sonatype.org/plexus-cipher HTTP Error 404:
Not Found
  W: invalid-url URL: http://spice.sonatype.org/plexus-cipher HTTP Error 404:
Not Found

Please include a valid URL in the URL tag. I've tried this in my browser, there
is definitely no page at this location.

---

I've been through the guidelines and the review check list and I believe the
package is acceptable except for the two items from the rpmlint output that
I've highlighted above.

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #23 from huwang  2010-05-31 21:32:37 EDT ---
(In reply to comment #22)
> Hi,
>
> This builds for me now finally, thanks.
>
> Rpmlint output:
>
> W: spelling-error Summary(en_US) decryption
>   W: spelling-error %description -l en_US decryption
>
> Ignore these spelling warnings, "decryption" is a valid noun form of the verb
> "decrypt." What a terrible dictionary it's using.
>
> W: non-conffile-in-etc /etc/maven/fragments/plexus-cipher
>
> This is normal and may also be ignored.
>
> W: no-documentation
>
> Please include the NOTICE.txt file as documentation in the main package.

Fixed.
> W: invalid-url URL: http://spice.sonatype.org/plexus-cipher HTTP Error 404:
> Not Found
>   W: invalid-url URL: http://spice.sonatype.org/plexus-cipher HTTP Error 404:
> Not Found
>
> Please include a valid URL in the URL tag. I've tried this in my browser, there
> is definitely no page at this location.

Fixed.
> I've been through the guidelines and the review check list and I believe the
> package is acceptable except for the two items from the rpmlint output that
> I've highlighted above.

Please review again, thanks.

Spec URL:
http://huwang.fedorapeople.org/packages/plexus_cipher/plexus-cipher.spec
SRPM URL:
http://huwang.fedorapeople.org/packages/plexus_cipher/plexus-cipher-1.5-3.sr...

here is the build link:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2221097

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

Mat Booth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #24 from Mat Booth  2010-06-01 04:56:53 EDT ---
Nice one, that looks fine to me.

APPROVED

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #25 from huwang  2010-06-01 06:05:54 EDT ---
New Package CVS Request
=======================
Package Name: plexus-cipher
Short Description: Plexus Cipher: encryption/decryption Component
Owners: huwang
Branches: 
InitialCC:

[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #26 from Kevin Fenzi  2010-06-03 16:13:49 EDT ---
CVS done (by process-cvs-requests.py).

Please don't put versions in the Summary of review tickets... ;)

[Bug 590522] Review Request: plexus-cipher - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |plexus-cipher-1.4-1  -      |plexus-cipher  - Plexus
                   |Plexus Cipher:              |Cipher:
                   |encryption/decryption       |encryption/decryption
                   |Component                   |Component

[Bug 590522] Review Request: plexus-cipher - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

--- Comment #27 from huwang  2010-06-03 21:57:53 EDT ---
Built in koji : http://koji.fedoraproject.org/koji/taskinfo?taskID=2228830

[Bug 590522] Review Request: plexus-cipher - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NOTABUG

[Bug 590522] Review Request: plexus-cipher - Plexus Cipher: encryption/decryption Component

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=590522

huwang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|NOTABUG                     |NEXTRELEASE