[Bug 2184724] New: Review Request: spirv-llvm15.0-translator - LLVM 15 to SPIRV Translator

https://bugzilla.redhat.com/show_bug.cgi?id=2184724

Bug ID: 2184724
           Summary: Review Request: spirv-llvm15.0-translator - LLVM 15 to
                    SPIRV Translator
           Product: Fedora
           Version: 38
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

SPEC:
https://download.copr.fedorainfracloud.org/results/frantisekz/intel-compute-...

SRPM:
https://download.copr.fedorainfracloud.org/results/frantisekz/intel-compute-...

Based on already existing packages: spirv-llvm-translator,
spirv-llvm8.0-translator

[Bug 2184724] Review Request: spirv-llvm15.0-translator - LLVM 15 to SPIRV Translator

https://bugzilla.redhat.com/show_bug.cgi?id=2184724

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/KhronosG
                   |                            |roup/SPIRV-LLVM-Translator

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5745890
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2184724] Review Request: spirv-llvm15.0-translator - LLVM 15 to SPIRV Translator

https://bugzilla.redhat.com/show_bug.cgi?id=2184724

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://github.com/KhronosG |
                   |roup/SPIRV-LLVM-Translator  |
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |POST
              Flags|                            |fedora-review+
                 CC|                            |[e-mail]

--- Comment #2 from Neal Gompa  ---
As this is a versioned variant of existing packages, it appears everything
looks good policy-wise and packaging-wise.

PACKAGE APPROVED.

[Bug 2184724] Review Request: spirv-llvm15.0-translator - LLVM 15 to SPIRV Translator

https://bugzilla.redhat.com/show_bug.cgi?id=2184724

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://github.com/KhronosG
                   |                            |roup/SPIRV-LLVM-Translator

[Bug 2184724] Review Request: spirv-llvm15.0-translator - LLVM 15 to SPIRV Translator

https://bugzilla.redhat.com/show_bug.cgi?id=2184724

--- Comment #3 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/spirv-llvm15.0-translator

[Bug 2184724] Review Request: spirv-llvm15.0-translator - LLVM 15 to SPIRV Translator

https://bugzilla.redhat.com/show_bug.cgi?id=2184724

František Zatloukal  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
   Fixed In Version|                            |spirv-llvm15.0-translator-1
                   |                            |5.0.0-1.fc39
        Last Closed|                            |2023-04-05 14:33:31

[Bug 2184724] Review Request: spirv-llvm15.0-translator - LLVM 15 to SPIRV Translator

https://bugzilla.redhat.com/show_bug.cgi?id=2184724

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Fabio Valentini  ---
(In reply to Neal Gompa from comment #2)
> As this is a versioned variant of existing packages, it appears everything
> looks good policy-wise and packaging-wise.
>
> PACKAGE APPROVED.

I'm confused. This package's name is clearly against the Naming Guidelines for
compat packages.
It should have been named spirv-llvm-translator15, just like the other new
compat packages (llvm15, lld15, clang15, etc.). Putting the compat version into
the *middle* of the name is awful (and using "15.0" for the compat "infix"
instead of "15" like the other LLVM packages is also needlessly diverging...)

[Bug 2184724] Review Request: spirv-llvm15.0-translator - LLVM 15 to SPIRV Translator

https://bugzilla.redhat.com/show_bug.cgi?id=2184724

--- Comment #5 from František Zatloukal  ---
(In reply to Fabio Valentini from comment #4)
> (In reply to Neal Gompa from comment #2)
> > As this is a versioned variant of existing packages, it appears everything
> > looks good policy-wise and packaging-wise.
> >
> > PACKAGE APPROVED.
>
> I'm confused. This package's name is clearly against the Naming Guidelines
> for compat packages.
> It should have been named spirv-llvm-translator15, just like the other new
> compat packages (llvm15, lld15, clang15, etc.). Putting the compat version
> into the *middle* of the name is awful (and using "15.0" for the compat
> "infix" instead of "15" like the other LLVM packages is also needlessly
> diverging...)

Yeah, sorry for that, I somehow had spirv-llvm8.0-translator in my muscle
memory (llvm was llvm8.0 back then), and didn't think about this. Shall we
create a new package and do the obsolete/provide fu? This isn't something user
would normally have to manually touch, and something that would go away once
intel-igc supports llvm 16.