Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
Summary: Review Request: xine-lib - The Xine library Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: gauret@free.fr QAContact: fedora-package-review@redhat.com
Spec URL: http://gauret.free.fr/fichiers/rpms/fedora/xine-lib.spec SRPM URL: http://gauret.free.fr/fichiers/rpms/fedora/xine-lib-1.1.2-12.src.rpm Description: This package contains the Xine library. Xine is a free multimedia player. It can play back various media. It also decodes multimedia files from local disk drives, and displays multimedia streamed over the Internet. It interprets many of the most common multimedia formats available - and some of the most uncommon formats, too. Non-default rpmbuild options: --without imagemagick: Disable ImageMagick support --with directfb: Enable DirectFB support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|ville.skytta@iki.fi | BugsThisDependsOn| |182235
------- Additional Comments From ville.skytta@iki.fi 2006-09-08 13:17 EST ------- This probably needs an ack from legal before it makes much sense to spend time on a review -> adding blocker on FE-Legal.
(Removing explicit Cc to me, I already receive the traffic through the fedora-package-review list.)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From dennis@ausil.us 2006-09-08 13:28 EST ------- as with other media packages you will need to use a modified tarball with all of the patented codec support removed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn|182235 | OtherBugsDependingO| |182235 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From ville.skytta@iki.fi 2006-09-08 13:39 EST ------- That is already done, see comments in the specfile. I think a legal ack is needed nevertheless.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From dennis@ausil.us 2006-09-08 13:54 EST ------- Source0: http://download.sourceforge.net/xine/%%7Bname%7D-%%7Bversion%7D.tar.bz2 Patch4: xine-lib-1.1.2-new-ffmpeg.patch
doesn't look like it
I see the comment in %prep it should be up with the sources.
# The tarball is generated from the upstream tarball using # the script in SOURCE1. It prunes potentially patented code
comment should be moved and id have a guess that the ffmpeg patch dropped
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From gauret@free.fr 2006-09-12 07:27 EST ------- Ah yes, sorry. This version actually builds...
* Tue Sep 12 2006 Aurelien Bompard abompard@fedoraproject.org 1.1.2-13 - drop patches 2 and 4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From gauret@free.fr 2006-09-12 07:29 EST ------- http://gauret.free.fr/fichiers/rpms/fedora/xine-lib-1.1.2-13.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From gauret@free.fr 2006-09-15 11:29 EST ------- Do you know how long the legal audit is likely to take ? Could we expect xine-lib in FC6, or is it much too close ? The SuSE specfile contains a mini-audit, if it can be of any help: http://gauret.free.fr/fichiers/rpms/fedora/xine-lib.suse.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From ville.skytta@iki.fi 2006-09-15 12:06 EST ------- No idea. Some packages have been waiting a long time, eg. mkvtoolnix 9+ months in bug 177134.
See also http://www.redhat.com/archives/fedora-extras-list/2006-August/msg00199.html
There was a word from someone that getting the legal queue moving would be put on the Board's agenda, but I haven't heard more about that, and summaries for the two last Board meetings seem to be missing from Wiki. Rex, any news?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From rdieter@math.unl.edu 2006-09-15 12:25 EST -------
Rex, any news?
Other than the last 2 FPB meetings weren't held (for various reasons). I'll make sure it's discussed by FPB at next opportunity.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From denis@poolshark.org 2006-09-15 12:31 EST ------- How is this package going to coexist with the various xine-libs available from "other repos" and legally used by people in countries with no software patents ? Since xine-lib has to be crippled to make it into Extras, won't it create an unnecessary annoyance ? Does it add real value to FE ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dennis@ausil.us
------- Additional Comments From dennis@ausil.us 2006-09-15 12:48 EST ------- xine-lib is the only viable engine on some arches for amarok. other repos should be able to have a xine-lib-extras package that has non free bits for those that can use them.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From rdieter@math.unl.edu 2006-09-15 12:48 EST ------- Re: comment #10
other repos
If this makes it in, there are plans to also make a xine-libs-extras-nonfree for "other" repos.
Does it add real value to FE ?
IMO, a *definite* yes. We'll be able to include apps that depend on xine-lib-devel to build (otherwise they wouldn't be included in Extras *at all*).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From denis@poolshark.org 2006-09-15 12:50 EST ------- Excellent! thanks for the clarification.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|182235 | nThis| |
------- Additional Comments From tcallawa@redhat.com 2006-10-14 17:59 EST ------- The liba52 code needs to go, it is patent encumbered and still present in the tarball. Otherwise, it looks ok. Lifting FE-Legal, on the grounds that the liba52 directory will be removed from the source.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From gauret@free.fr 2006-10-15 16:15 EST ------- Great news ! Thanks ! I've updated the pruning script to remove liba52 too : http://gauret.free.fr/fichiers/rpms/fedora/xine-lib.spec http://gauret.free.fr/fichiers/rpms/fedora/xine-lib-1.1.2-14.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |ville.skytta@iki.fi OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From ville.skytta@iki.fi 2006-10-16 16:46 EST ------- Preliminary review:
- src/libdts: most likely needs to be removed. The code contains links to http://www.videolan.org/dtsdec.html - check it out for more info.
- The option summary after ./configure contains lots of things containing the word "mpeg" - is it just the message or does the source tarball require further cleanup?
- The cleanup script removes src/libspudec twice, maybe the other one was supposed to remove something else?
- xine-lib-dxropts.patch is not needed because src/dxr3 is pruned.
- Build fails on x86_64: File not found: /var/tmp/xine-lib-1.1.2-14.fc5-buildroot/usr/lib64/xine/plugins/1.1.2/xineplug_decode_gdk_pixbuf.so File not found: /var/tmp/xine-lib-1.1.2-14.fc5-buildroot/usr/lib64/xine/plugins/1.1.2/xineplug_vo_out_vidix.so
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From mgarski@post.pl 2006-10-16 17:30 EST ------- (In reply to comment #16)
- src/libdts: most likely needs to be removed. The code contains links to
http://www.videolan.org/dtsdec.html - check it out for more info.
Probably need to be removed.
From libdts website: "Provisional Warning: DTS Inc. claims that use of libdca
software, to decode DTS compressed sound data on a DVD could violate DTS's patent rights. If you are unsure about the legality of using and distributing this code in your country, in particular in the USA, please consult your lawyer before downloading it".
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From gauret@free.fr 2006-10-16 17:44 EST ------- - removed libdts - fixed the cleanup script to remove libspudec only once - dropped dxr patch - listed xineplug_decode_gdk_pixbuf.so and xineplug_vo_out_vidix.so only on x86
http://gauret.free.fr/fichiers/rpms/fedora/xine-lib.spec http://gauret.free.fr/fichiers/rpms/fedora/xine-lib-1.1.2-15.src.rpm
The mpeg-related configure switches are there to skip the mpeg tests (saves me from hacking even more the configure script)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From ville.skytta@iki.fi 2006-10-16 18:16 EST ------- (In reply to comment #18)
- listed xineplug_decode_gdk_pixbuf.so and xineplug_vo_out_vidix.so only
on x86
This doesn't look like the correct fix to me. vidix is x86 only IIRC so that part is maybe ok, but gdk-pixbuf appears to be just a matter of missing BR: gtk2-devel.
The mpeg-related configure switches are there to skip the mpeg tests
Note that I was talking about the printed configuration summary after ./configure is run, not switches passed to it. Eg.
xine-lib summary: [...] * demultiplexer plugins: - avi - mpeg - mpeg_block - mpeg_audio - mpeg_elem - mpeg_pes - mpeg_ts - qt/mpeg-4 [...] etc
dts removal looks incomplete:
RPM build errors: File not found: /var/tmp/xine-lib-1.1.2-15.fc5-buildroot/usr/lib64/xine/plugins/1.1.2/xineplug_decode_dts.so
More later tomorrow - others' feel free to chime in on the review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From gauret@free.fr 2006-10-17 06:33 EST ------- You're right about gdk_pixbuf, I thought you meant you tried on both x86 and x86_64 and it failed only on the latter.
- add BR gtk2-devel - remove xineplug_decode_gdk_pixbuf.so from x86-only
http://gauret.free.fr/fichiers/rpms/fedora/xine-lib.spec http://gauret.free.fr/fichiers/rpms/fedora/xine-lib-1.1.2-16.src.rpm
find -name "*mpeg*" in the sources dir yields some results, but I don't think it's mpeg decoding code. It looks more like interfacing with ffmpeg or code for the mpg container. In any case, I trust Legal in this.
I tried to build the package in mock, and it fails because of an improper selinux label on /usr/lib/libSDL-1.2.so.0.7.2. Is it fixable ? Will it fail in the Fedora Buildsystem ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@redhat.com
------- Additional Comments From ville.skytta@iki.fi 2006-10-17 17:49 EST ------- Ok, getting closer. It now builds and a q'n'd-modified and rebuilt FE5 amarok works nicely with flacs on x86_64.
Just an observation: xine-lib appears to ship and use its private slightly customized copies of libmatroska and libmpcdec (and possibly other things), and doesn't provide an option to use the system ones. Not nice, but not a blocker IMO either.
The installed docs should be reviewed for usefulness, at least README.dxr3 and README.MINGWCROSS look like clear candidates for removal.
About some input plugins: are MMS, RTP, and RTSP ok to be included? AFAIK MMS is proprietary (libmms was not submitted to FE, I think Hans asked about it sometime ago), and a quick Googling session revealed these for the two latter. http://www.ietf.org/ietf/IPR/RTSP http://www1.ietf.org/ietf/IPR/microsoft-ipr-draft-ietf-avt-rtp-vc1-02.txt
spot, your thoughts on the above?
About the SDL issue, no idea. No problems building it for FC5 here, using mach.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From tcallawa@redhat.com 2006-10-17 18:17 EST ------- RTP looks ok because Microsoft is stating in that document that they are granting a "Royalty-Free, Reasonable, and Non-Discriminatory License to All Implementers" in that RFC. Likewise, the Real Networks document seems to cover RTSP sufficiently.
The MMS protocol implementation on the other hand is definitely not royalty-free, and needs to go.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From gauret@free.fr 2006-10-18 04:42 EST ------- - cleanup docs - remove mms - delete more source files in the cleanup script - drop patch3 (affecting mms)
About the 3rd line, I realized I did not remove all the source code files in the input plugins dir, so I changed the script to do that.
http://gauret.free.fr/fichiers/rpms/fedora/xine-lib.spec http://gauret.free.fr/fichiers/rpms/fedora/xine-lib-1.1.2-17.src.rpm
The failure in mock may be beacause my FC5 is a yum-upgraded FC4, I don't know.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From ville.skytta@iki.fi 2006-10-19 02:48 EST ------- Ok, looks even better. One more question about pruned stuff:
What's the problem with including the DVD reading functionality in this package? The capability to read data from encrypted DVDs is not implemented directly in xine-lib as far as I can tell. Based on some recent discussions in private mail with spot, that would be the only real problem with including DVD reading libraries in Fedora.
The ability to read unencrypted DVDs would be useful to have. And even though the actual MPEG data on them couldn't be decoded in software with packages in Fedora, there are hardware solutions to that, such as the em8300/dxr3 cards supported by the em8300* packages in FE, and probably full-featured DVB cards (ie. ones that have a MPEG decoder chip). Enabling libdvdnav in xine-lib would also allow enabling the dxr3 hardware MPEG decoding functionality in it.
The dxr3 functionality here is associated with libavcodec, rte, and fame, all of which can't be included in Fedora, but they're only used to re-encoded non-MPEG content to MPEG for feeding to the em8300 devices. MPEG playback with em8300 requires none of those.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From gauret@free.fr 2006-10-29 02:15 EST ------- At the moment, libdvdnav is not in Extras, so we need to review and accept it before enabling dvd support in xine-lib. Since the libdvdnav sumbission will have to go through Legal review, it may take some time. So I'd rather have xine-lib without dvdnav support imported in the close future, and add the support when libdvdnav is in Extras. Are you guys OK with that ?
Ville, would you like to co-maintain xine-lib with me in Extras ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
------- Additional Comments From ville.skytta@iki.fi 2006-10-29 04:20 EST ------- Yeah, feel free to add me as a co-maintainer when this goes in.
Note that xine-lib uses a bundled/modified libdvdnav by default, dunno how feasible would it be to try to convert it to use an external one. But yeah, that can be looked into later.
I have nothing to add here at the moment, so as far as I'm concerned, this is approved. I'll set this to FE-ACCEPT tomorrow in order to provide a bit of time in case someone (spot?) wishes to take one more look at the package contents. Please delay importing until this is in FE-ACCEPT state.
Oh, one little thing, I think xineplug_decode_gdk_pixbuf.so and xineplug_vo_out_caca.so are good candidates for moving into the list of plugins potentially to be moved to a xine-lib-extras subpackage later.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From ville.skytta@iki.fi 2006-10-30 12:00 EST ------- Moving to FE-ACCEPT.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
gauret@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From gauret@free.fr 2006-11-01 01:12 EST ------- Imported and built, thanks a lot !
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From ville.skytta@iki.fi 2007-08-14 07:35 EST ------- Package Change Request ====================== Package Name: xine-lib Updated Fedora Owners: abompard,scop Updated Fedora CC: [none]
I've been already co-maintaining this package for a while, so I suppose it wouldn't hurt to move me from initialcc to a real co-maintainer.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205798
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-08-14 15:58 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/show_bug.cgi?id=205798
ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From ville.skytta@iki.fi 2007-09-07 10:32 EST ------- Package Change Request ====================== Package Name: xine-lib New Branches: EL-5 Updated EPEL Owners: scop,abompard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xine-lib - The Xine library
https://bugzilla.redhat.com/show_bug.cgi?id=205798
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-09-07 14:39 EST ------- cvs done.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla