Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Coro - The only real threads in perl
https://bugzilla.redhat.com/show_bug.cgi?id=667171
Summary: Review Request: perl-Coro - The only real threads in perl Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: ppisar@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://ppisar.fedorapeople.org/perl-Coro/perl-Coro.spec SRPM URL: http://ppisar.fedorapeople.org/perl-Coro/perl-Coro-5.25-1.fc14.src.rpm Description: This module collection manages continuations in general, most often in the form of cooperative threads (also called coros, or simply "coro" in the documentation). They are similar to kernel threads but don't (in general) run in parallel at the same time even on SMP machines. The specific flavor of thread offered by this module also guarantees you that it will not switch between threads unless necessary, at easily-identified points in your program, so locking and parallel access are rarely an issue, making thread programming much safer and easier than using other thread models.
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2700995
$ rpmlint perl-Coro.spec ../SRPMS/perl-Coro-5.25-1.fc14.src.rpm ../RPMS/x86_64/perl-Coro-* perl-Coro.src: W: spelling-error %description -l en_US coros -> corps, coos, cores perl-Coro.x86_64: W: spelling-error %description -l en_US coros -> corps, coos, cores perl-Coro.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/Coro/CoroAPI.h 3 packages and 1 specfiles checked; 0 errors, 3 warnings.
The `coros' is a short term for `co-routine'. The header file is header for C binding for the perl module. The location is normal for perl packages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667171
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iarnell@gmail.com
--- Comment #1 from Iain Arnell iarnell@gmail.com 2011-01-05 02:56:23 EST --- There is already a perl-Coro review at bug #452521, which is blocked by perl-EV review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667171
Petr Sabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com AssignedTo|nobody@fedoraproject.org |psabata@redhat.com Flag| |fedora-review?
--- Comment #2 from Petr Sabata psabata@redhat.com 2011-01-05 03:27:40 EST --- Iain,
the EV support in Coro is not required and is currently not supported by Fedora. The old reviews are stalled. I'd like to get Coro to Fedora; also DBI development is apparently pro-Coro now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667171
Petr Sabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Petr Sabata psabata@redhat.com 2011-01-05 05:07:30 EST --- Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [1] [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Spec file is legible and written in American English. [x] Spec file lacks Packager, Vendor, PreReq tags. [x] Spec uses macros instead of hard-coded directory names. [x] Package consistently uses macros. [-] Macros in Summary, %description expandable at SRPM build time. [x] PreReq is not used. [x] Requires correct, justified where necessary. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [2] [-] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)). [-] Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the beginning of %install. [-] Package use %makeinstall only when ``make install DESTDIR=...'' doesn't work. [-] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [-] The spec file handles locales properly. [x] Changelog in prescribed format. [?] Rpmlint output is silent. [x] License field in the package spec file matches the actual license. [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [-] License file installed when any subpackage combination is installed. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [3,4] [x] Sources contain only permissible code or content. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 421ac184fe738b2b061dadca96f25946 MD5SUM upstream package : 421ac184fe738b2b061dadca96f25946 [x] Compiler flags are appropriate. [x] %build honors applicable compiler flags or justifies otherwise. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package does not own files or directories owned by other packages. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Each %files section contains %defattr. [x] No %config files under /usr. [-] %config files are marked noreplace or the reason is justified. [-] Package contains a properly installed %{name}.desktop using desktop-file-install file if it is a GUI application. [5] [-] Package contains a valid .desktop file. [x] Package contains code, or permissable content. [-] Package contains a SysV-style init script if in need of one. [x] File names are valid UTF-8. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [x] Package contains no bundled libraries. [?] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [x] Package contains no static executables. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Useful -debuginfo package or justification otherwise. [-] Rpath absent or only used for internal libs. [x] Package does not genrate any conflict. [x] Package does not contains kernel modules. [x] Package is not relocatable. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. [x] Package is not known to require ExcludeArch. [x] Package installs properly. [x] Package obeys FHS, except libexecdir and /usr/target. [x] Package meets the Packaging Guidelines. [6]
=== SUGGESTED ITEMS === [-] Package functions as described. [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [x] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] SourceX is a working URL. [-] SourceX / PatchY prefixed with %{name}. [x] Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x] %check is present and all tests pass. [-] Usually, subpackages other than devel should require the base package using a fully versioned dependency. [x] Reviewer should test that the package builds in mock. [x] Package should compile and build into binary rpms on all supported architectures. [x] Dist tag is present. [-] Spec use %global instead of %define. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files are correct. [x] No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x] Packages should try to preserve timestamps of original installed files. [-] File based requires are sane. [-] Man pages included for all executables. [x] Uses parallel make. [-] Patches link to upstream bugs/comments/lists or are otherwise justified.
=== Issues === 1. No issues except for a comment typo on line 33
=== Final Notes === 1. review+
================ *** APPROVED *** ================
[1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines [2] https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 [3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines [4] https://fedoraproject.org/wiki/Licensing:Main [5] https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files [6] https://fedoraproject.org/wiki/Packaging:Guidelines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667171
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |661471
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667171
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Petr Pisar ppisar@redhat.com 2011-01-05 06:28:25 EST --- New Package SCM Request ======================= Package Name: perl-Coro Short Description: The only real threads in perl Owners: ppisar mmaslano psabata kwizart Branches: InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667171
--- Comment #5 from Jason Tibbitts tibbs@math.uh.edu 2011-01-05 11:10:27 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667171
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Coro-5.25-1.fc15 Resolution| |RAWHIDE Last Closed| |2011-01-05 11:37:57
--- Comment #6 from Petr Pisar ppisar@redhat.com 2011-01-05 11:37:57 EST --- Thank you for review and repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667171
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kwizart@gmail.com
--- Comment #7 from Petr Pisar ppisar@redhat.com 2011-01-05 11:46:41 EST --- *** Bug 452521 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667171
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #8 from Petr Pisar ppisar@redhat.com 2011-01-20 05:32:44 EST --- Package Change Request ====================== Package Name: perl-Coro New Branches: el6 Owners: bochecha InitialCC: perl-sig
bochecha wants to create and maintain EPEL-6 branch. Let's do it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=667171
--- Comment #9 from Jason Tibbitts tibbs@math.uh.edu 2011-01-20 09:39:30 EST --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla