Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214872
Summary: Review Request: Ri-li - Arcade game where you drive a toy wood engine Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: j.w.r.degoede@hhs.nl QAContact: fedora-package-review@redhat.com
Spec URL: http://people.atrpms.net/~hdegoede/Ri-li.spec SRPM URL: http://people.atrpms.net/~hdegoede/Ri-li-2.0.0-1.fc7.src.rpm Description: You drive a toy wood engine in many levels and you must collect all the coaches to win. Full-featured: 18 languages, Colorful animated wood engine, 50 levels, 3 beautiful music tracks and many sound effects.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Ri-li - Arcade game where you drive a toy wood engine Alias: Ri-li
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214872
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |chris.stone@gmail.com OtherBugsDependingO|163776 |163778 nThis| | Alias| |Ri-li
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Ri-li - Arcade game where you drive a toy wood engine Alias: Ri-li
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214872
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From chris.stone@gmail.com 2006-11-13 21:26 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec filename matches %{name} - package meets packaging guidelines - package licensed with open source compatible license - license matches actual license - license file included in %doc - spec written in American english - spec legible - sources match upstream e6dfa35616f5c84eb14ff82517cea796 Ri-li-2.0.0.tar.bz2 - package successfully compiles and builds on FC6 x86_64 - all build dependencies are listed in BR - package does not use locales - no shared libraries - package is not relocatable - package owns all directories it creates - no duplicates in %files - file permissions set properly - contains proper %clean - macro usage consistent - contains code - no large documentation files - %doc does not affect runtime - no header files or static libraries - no pkgconfig files - no need for devel subpackage - no .la files - contains proper .desktop file - package does not own files or directories owned by other packages
APPROVED
==== SHOULD ==== - Remove SDL-devel from BR, SDL_Mixer-devel should pick it up
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Ri-li - Arcade game where you drive a toy wood engine Alias: Ri-li
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214872
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-14 02:34 EST ------- (In reply to comment #1)
==== SHOULD ====
- Remove SDL-devel from BR, SDL_Mixer-devel should pick it up
Done.
Thanks for the review, imported and build, closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Ri-li - Arcade game where you drive a toy wood engine Alias: Ri-li
https://bugzilla.redhat.com/show_bug.cgi?id=214872
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org