[Bug 709160] New: Review Request: activity-log-manager - Easily control what gets logged by Zeitgeist

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: activity-log-manager - Easily control what gets logged by Zeitgeist

https://bugzilla.redhat.com/show_bug.cgi?id=709160

Summary: Review Request: activity-log-manager - Easily control
                    what gets logged by Zeitgeist
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---

Spec URL: http://krakoa.dk/fedora/activity-log-manager.spec
SRPM URL: http://krakoa.dk/fedora/activity-log-manager-0.8.0-1.fc15.src.rpm
Description: Activity Log Manager is a graphical user interface which lets you
easily control what gets logged by Zeitgeist.

[Bug 709160] Review Request: activity-log-manager - Easily control what gets logged by Zeitgeist

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=709160

Fabian Affolter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Fabian Affolter  2011-06-04 10:31:31 EDT ---
Just some quick comments on your spec file.

- You are mixing %{buildroot} and $RPM_BUILD_ROOT

https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D...
- At least the COPYING file needs to go to %doc
- The language files are not handled correct
  https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

P.S. For reviewer it would be handier if the URL is filled with the real URL
and not a macros. Copy and paste ;-)

[Bug 709160] Review Request: activity-log-manager - Easily control what gets logged by Zeitgeist

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=709160

--- Comment #2 from Mads Villadsen  2011-06-05 10:00:07 EDT ---
I updated the files. They are still at the same urls:

Spec URL: http://krakoa.dk/fedora/activity-log-manager.spec
SRPM URL: http://krakoa.dk/fedora/activity-log-manager-0.8.0-1.fc15.src.rpm

I now only use %{buildroot}. I have added the COPYING file.

The build file didn't install the language files so I had to resort to cp -p -
but I think that should be alright.

And I changed the urls for easier copy/paste.