https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Bug ID: 1061732 Summary: Review Request: python-flask-restful - RESTful library for Flask Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jsedlak@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://jsedlak.fedorapeople.org/python-flask-restful.spec SRPM URL: http://jsedlak.fedorapeople.org/python-flask-restful-0.2.11-1.fc20.src.rpm Description: Flask-RESTful is Python library for writing RESTful APIs in Flask applications.
It has Python 3 support. Fedora Account System Username: jsedlak
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Jan Sedlák jsedlak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #1 from Jan Sedlák jsedlak@redhat.com --- Here is output from fedora-review package: http://jsedlak.fedorapeople.org/review-python-flask-restful/
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Jan Sedlák jsedlak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1059659
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1059659 [Bug 1059659] Review Request: python-aniso8601 - library for parsing dates in ISO8601 format
https://bugzilla.redhat.com/show_bug.cgi?id=1061732 Bug 1061732 depends on bug 1059659, which changed state.
Bug 1059659 Summary: Review Request: python-aniso8601 - library for parsing dates in ISO8601 format https://bugzilla.redhat.com/show_bug.cgi?id=1059659
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |msuchy@redhat.com Assignee|nobody@fedoraproject.org |msuchy@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #2 from Miroslav Suchý msuchy@redhat.com --- It is good habit (but not mandatory) to mark which BR are needed for tests. E.g:
# those are needed for tests: BuildRequires: python3-nose BuildRequires: python3-mock ...
AUTHORS.md, README.md examples and docs should be put in in doc dir. This should be enough in %files sections: %doc README.md AUTHORS.md examples docs
you are missing license in package. It should be either %doc LICENSE or rather %license LICENSE It should be in both packages.
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #3 from Miroslav Suchý msuchy@redhat.com --- Also the file utils/ordereddict.py is licensed under MIT (according its header) so license should be BSD and MIT. But in upstream this file is no longer present, so you may just rebase.
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #4 from Jan Sedlák jsedlak@redhat.com --- Ok, I will correct it and repackage to newest version.
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Igor Gnatenko i.gnatenko.brain@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i.gnatenko.brain@gmail.com
--- Comment #5 from Igor Gnatenko i.gnatenko.brain@gmail.com --- (In reply to Jan Sedlák from comment #4)
Ok, I will correct it and repackage to newest version.
ping?
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #6 from Jan Sedlák jsedlak@redhat.com --- I have updated flask-restful specfile. It uses newest version - 0.3.3.
Since there is a problem with logging into fedorapeople.org, I have uploaded specfile and srpm onto my Dropbox:
https://dl.dropboxusercontent.com/u/90503369/python-flask-restful/python-fla... https://dl.dropboxusercontent.com/u/90503369/python-flask-restful/python-fla...
There is also problem with fedora-review (namely licensecheck, bug 1240914) so I cannot run fedora-review on my package just yet.
I am using tag tarball (rather than release tarball), because since 0.3, they don't include documentation, tests and LICENSE in release tarball (see https://github.com/flask-restful/flask-restful/issues/475). I had to also delete one testcase with patch - this testcase works only with newer Werkzeug which isn't in repos.
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #7 from Jan Sedlák jsedlak@redhat.com --- fedora-review is now working (you have to use https://admin.fedoraproject.org/updates/devscripts-2.15.5-6.fc22), so here is its output:
https://www.dropbox.com/sh/qfno8oinv7sqq51/AADgw13JX8r3cAMOBLqbqKVra?dl=0
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #8 from Miroslav Suchý msuchy@redhat.com --- You are packaging .gitignore, which is wrong: python-flask-restful.noarch: E: version-control-internal-file /usr/share/doc/python-flask-restful/docs/_themes/.gitignore python3-flask-restful.noarch: E: version-control-internal-file /usr/share/doc/python3-flask-restful/docs/_themes/.gitignore
Otherwise it is good to me.
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #9 from Jan Sedlák jsedlak@redhat.com --- I have updated it to remove .gitignore before packaging.
Review: https://jsedlak.fedorapeople.org/review-python-flask-restful/ Specfile: https://jsedlak.fedorapeople.org/python-flask-restful.spec SRPM: https://jsedlak.fedorapeople.org/python-flask-restful-0.3.3-1.fc22.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) | Flags| |fedora-review+
--- Comment #10 from Miroslav Suchý msuchy@redhat.com --- Removing FE-NEEDSPONSOR as you were already sponsored by Ralph.
APPROVED
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Jan Sedlák jsedlak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #11 from Jan Sedlák jsedlak@redhat.com --- New Package SCM Request ======================= Package Name: python-flask-restful Short Description: Simple framework for creating REST APIs for Flask Upstream URL: https://www.github.com/twilio/flask-restful/ Owners: jsedlak Branches: f21 f22 f23 el6 epel7 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #12 from Kevin Fenzi kevin@scrye.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- python-flask-restful-0.3.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-13802
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- python-flask-restful-0.3.4-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-13803
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Jan Sedlák jsedlak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2015-08-31 04:35:44
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- python-flask-restful-0.3.4-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |0.3.4-1.fc23
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- python-flask-restful-0.3.4-3.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-7311b57ad7
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|NEXTRELEASE |--- Keywords| |Reopened
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- python-flask-restful-0.3.4-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update python-flask-restful' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-7311b57ad7
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- python-flask-restful-0.3.4-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1061732
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2015-08-31 04:35:44 |2015-11-30 18:25:13
package-review@lists.fedoraproject.org