[Bug 2351539] New: Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

Bug ID: 2351539
           Summary: Review Request: redisx - Free and independent Redis /
                    Valkey client library for C/C++
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...
Description: 
RedisX is a free, light-weight Redis client library for C/C++. As such, it
works with Redis forks / clones like Dragonfly or Valkey also. It supports both
interactive and pipelined Redis queries, managing and processing subscriptions,
atomic execution blocks, and LUA scripts loading. It can be used with multiple
Redis servers simultaneously also. RedisX is free to use, in any way you like,
without licensing restrictions.

Build for all Fedora supported platforms are available on Copr at
https://copr.fedorainfracloud.org/coprs/attipaci/redisx/build/8753167/

Fedora Account System Username: attipaci

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged
                URL|                            |https://smithsonian.github.
                   |                            |io/redisx

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8753234
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #2 from Attila Kovacs  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...

- Removed period at the end of the summary
 - Changed description to work around spell-checker
 - Added `%{_isa}` to dependent packages (maybe all should need it?)

-- A.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #3 from Attila Kovacs  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...

- Removed unneeded build dependency (`valkey`).
 - Added `%{_isa}` to ALL dependent library packages.

-- A.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #4 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8753347
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #5 from Fedora Review Service  ---
Created attachment 2079815
  --> https://bugzilla.redhat.com/attachment.cgi?id=2079815&action=edit
The .spec file difference from Copr build 8753347 to 8753385

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #6 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8753385
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #7 from Attila Kovacs  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...

- Removed unneeded explicit dependencies

-- A.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #8 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8753464
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #9 from Attila Kovacs  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...

- Oops, last spec changes were not pushed. Try again...

-- A.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #10 from Fedora Review Service  ---
Created attachment 2079847
  --> https://bugzilla.redhat.com/attachment.cgi?id=2079847&action=edit
The .spec file difference from Copr build 8753464 to 8753502

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #11 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8753502
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #12 from Attila Kovacs  ---
As for the two remaining rpmlint warnings:
> redisx.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libredisx.so.1 SSL_CTX_set_cipher_list
> redisx.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/libredisx.so.1

I will change upstream (next release candidate) to address these there. The
first one is for legacy OpenSSL support (<1.1.1), and can be completely
disabled when built against newer versions (openssl >= 1.1.1). The second will
be fixed by using `getaddrinfo()` instead.

-- A.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #13 from Attila Kovacs  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...

- Updated for new upstream release candidate (v1.0.0-rc3).

-- A.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #14 from Fedora Review Service  ---
Created attachment 2080520
  --> https://bugzilla.redhat.com/attachment.cgi?id=2080520&action=edit
The .spec file difference from Copr build 8753502 to 8772887

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #15 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8772887
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #16 from Attila Kovacs  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...

- Updated to latest upstream release candidate (1.0.0~rc4)

-- A.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #17 from Fedora Review Service  ---
Created attachment 2081857
  --> https://bugzilla.redhat.com/attachment.cgi?id=2081857&action=edit
The .spec file difference from Copr build 8772887 to 8816141

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #18 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8816141
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #19 from Attila Kovacs  ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-ra...

- Updated for upstream v1.0.0 release.

-- A.

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #20 from Fedora Review Service  ---
Created attachment 2088617
  --> https://bugzilla.redhat.com/attachment.cgi?id=2088617&action=edit
The .spec file difference from Copr build 8816141 to 9000609

[Bug 2351539] Review Request: redisx - Free and independent Redis / Valkey client library for C/C++

https://bugzilla.redhat.com/show_bug.cgi?id=2351539

--- Comment #21 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9000609
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.