[Bug 523756] New: Review Request: iwl1000-firmware - Firmware for Intel® PRO /Wireless 1000 B/G/N network adaptors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: iwl1000-firmware -  Firmware for Intel® PRO/Wireless 1000 B/G/N network adaptors

https://bugzilla.redhat.com/show_bug.cgi?id=523756

Summary: Review Request: iwl1000-firmware -  Firmware for
                    Intel® PRO/Wireless 1000 B/G/N network adaptors
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://linville.fedorapeople.org/iwl1000-firmware.spec
SRPM URL:
http://linville.fedorapeople.org/iwl1000-firmware-128.50.3.1-1.fc11.src.rpm
Description:

This package contains the firmware required by the iwlagn driver
for Linux to support the iwl1000 hardware.  Usage of the firmware
is subject to the terms and conditions contained inside the provided
LICENSE file. Please read it carefully.

[Bug 523756] Review Request: iwl1000-firmware - Firmware for Intel® PRO /Wireless 1000 B/G/N network adaptors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=523756

John W. Linville  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |483098

[Bug 523756] Review Request: iwl1000-firmware - Firmware for Intel® PRO /Wireless 1000 B/G/N network adaptors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=523756

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #1 from Jason Tibbitts   2009-09-23 03:24:19 EDT ---
I guess packages don't get much simpler than this.  It looks functionally
equivalent to the existing iwl5000-firmware package; since the licenses are
exactly the same I'm going to assume that everything is OK there.

This package, like the other firmware packages, have no dependencies.  I'm
going to assume that's OK as well, and that weird install-time ordering won't
somehow cause this package to be installed before udev (or if that nothing
suffers if that does manage to happen).

I haven't the hardware to test this, but I'm sure if anything doesn't work, it
wouldn't be due to the trivial packaging.

* source files match upstream.  sha256sum:                          
   7e81ddad18acec19364c9df22496e8afae99a2e1490b2b178e420b52d443728d
   iwlwifi-1000-ucode-128.50.3.1.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is acceptable for firmware.
* license text included in package.
* latest version is being packaged.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   iwl1000-firmware = 128.50.3.1-1.fc12
  =
   (none)

* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

[Bug 523756] Review Request: iwl1000-firmware - Firmware for Intel® PRO /Wireless 1000 B/G/N network adaptors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=523756

John W. Linville  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #2 from John W. Linville   2009-09-29 13:32:21 EDT ---
New Package CVS Request
=======================
Package Name: iwl1000-firmware
Short Description: Firmware for Intel® PRO/Wireless 1000 B/G/N network adaptors
Owners: linville
Branches: F-11 F-12
InitialCC: linville

[Bug 523756] Review Request: iwl1000-firmware - Firmware for Intel® PRO /Wireless 1000 B/G/N network adaptors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=523756

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #3 from Kevin Fenzi   2009-09-29 16:15:51 EDT ---
cvs done.

[Bug 523756] Review Request: iwl1000-firmware - Firmware for Intel® PRO /Wireless 1000 B/G/N network adaptors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=523756

--- Comment #4 from Fedora Update System   2009-09-30 11:05:57 EDT ---
iwl1000-firmware-128.50.3.1-1.fc11 has been submitted as an update for Fedora
11.
http://admin.fedoraproject.org/updates/iwl1000-firmware-128.50.3.1-1.fc11

[Bug 523756] Review Request: iwl1000-firmware - Firmware for Intel® PRO /Wireless 1000 B/G/N network adaptors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=523756

John W. Linville  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]           |[e-mail]

[Bug 523756] Review Request: iwl1000-firmware - Firmware for Intel® PRO /Wireless 1000 B/G/N network adaptors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=523756

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]         |[e-mail]

[Bug 523756] Review Request: iwl1000-firmware - Firmware for Intel® PRO /Wireless 1000 B/G/N network adaptors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=523756

--- Comment #5 from Fedora Update System   2009-10-03 15:00:22 EDT ---
iwl1000-firmware-128.50.3.1-1.fc11 has been pushed to the Fedora 11 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 523756] Review Request: iwl1000-firmware - Firmware for Intel® PRO /Wireless 1000 B/G/N network adaptors

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=523756

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |128.50.3.1-1.fc11
         Resolution|                            |ERRATA