Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: herbstluftwm - Tiling window manager
https://bugzilla.redhat.com/show_bug.cgi?id=812538
Summary: Review Request: herbstluftwm - Tiling window manager Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: corey@octayn.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://octayn.net/herbstluftwm.spec SRPM URL: http://octayn.net/herbstluftwm-0.3-1.fc16.src.rpm
Description: herbstluftwm is a manual tiling window manager for X, meaning frames are manually split into sub-frames, where windows can be placed. All configuration is done using IPC, so it is language-agnostic. The included herbstclient program provides a simple interface. Custom layouts are possible. Rules and hooks allow great flexibility. herbstluftwm can also float windows.
This is my first package and I need a sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812538
Corey Richardson (:Octayn) corey@octayn.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |corey@octayn.net Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812538
--- Comment #1 from Corey Richardson (:Octayn) corey@octayn.net 2012-04-17 14:10:43 EDT --- Thanks to some input from 'tipps' I've cleaned up the spec a bit. Removed an unnecessary line and made the paths in %files consistent. The new spec is live, and the new SRPM is at http://octayn.net/herbstluftwm-0.3-2.fc16.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812538
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review?
--- Comment #2 from Jason Tibbitts tibbs@math.uh.edu 2012-04-19 09:56:41 EDT --- Taking a look at this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812538
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu 2012-04-20 17:26:07 EDT --- OK, this builds fine (on rawhide); rpmlint has only one complaint:
herbstluftwm.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/herbstclient-completion This is fine; those files shouldn't be there, but that's not your fault.
The project makefile is annoying; it hides the actual compiler call (so we can't verify the compiler flags it is using), does not provide a verbose mode and inserts control sequences which look more like line noise in the build logs. I had to build with a quick patch to get that done properly:
diff -up ./rules.mk.orig ./rules.mk --- ./rules.mk.orig 2012-04-20 16:05:30.840050949 -0500 +++ ./rules.mk 2012-04-20 16:05:44.030637343 -0500 @@ -4,18 +4,14 @@ all: $(TARGET) rb: clean all
$(TARGET): $(OBJ) - $(call colorecho,LD,$(TARGET)) - @$(LD) -o $@ $(LDFLAGS) $(OBJ) $(LIBS) + $(LD) -o $@ $(LDFLAGS) $(OBJ) $(LIBS)
$(SRCDIR)/%.o: $(SRCDIR)/%.c $(HEADER) - $(call colorecho,CC,$<) - @$(CC) -c $(CFLAGS) -o $@ $< + $(CC) -c $(CFLAGS) -o $@ $<
clean: - $(call colorecho,RM,$(TARGET)) - @rm -f $(TARGET) - $(call colorecho,RM,$(OBJ)) - @rm -f $(OBJ) + rm -f $(TARGET) + rm -f $(OBJ)
info: @echo Some Info:
and the result is that indeed, the package isn't built with the proper Fedora compiler flags. Unfortunately the makefile doesn't allow you to pass your own, so I used the following in %prep:
sed -i -e 's/^CFLAGS =.*/CFLAGS = %{optflags} -std=c99 -pedantic ${INCS} -D _XOPEN_SOURCE=600/' config.mk
Still seems to build after that but you'll need to do some testing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812538
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu 2012-05-09 14:49:37 EDT --- Any progress here? Is there anything I can assist with? If something about the above is unclear, please let me know and I'll try to help.
https://bugzilla.redhat.com/show_bug.cgi?id=812538
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|fedora-review? | Last Closed| |2012-06-08 15:40:57
--- Comment #5 from Jason Tibbitts tibbs@math.uh.edu --- Well, it's been another month with no response, so I'll go ahead and close this out.
https://bugzilla.redhat.com/show_bug.cgi?id=812538
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com Resolution|NOTABUG |DUPLICATE
--- Comment #6 from Christopher Meng cickumqt@gmail.com ---
*** This bug has been marked as a duplicate of bug 1001407 ***
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla