https://bugzilla.redhat.com/show_bug.cgi?id=1648426
Bug ID: 1648426 Summary: Review Request: graphlcd-base - GraphLCD drivers and tools Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mgansser@online.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/graphlcd-base.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/graphlcd-base-1.0.1-1.fc29.sr...
Description: The GraphLCD base is a project to support graphical LC displays. It is mainly used by the graphlcd plugin for the Video Disc Recorder to display its information.
Fedora Account System Username: martinkg
rpmlint -i -v graphlcd-base.spec /home/martin/rpmbuild/SRPMS/graphlcd-base-1.0.1-1.fc29.src.rpm /home/martin/rpmbuild/RPMS/x86_64/glcddrivers-1.0.1-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/graphlcd-devel-1.0.1-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/glcdgraphics-1.0.1-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/glcdskin-1.0.1-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/graphlcd-common-1.0.1-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/graphlcd-tools-1.0.1-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/graphlcd-base-debugsource-1.0.1-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/graphlcd-base-debuginfo-1.0.1-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/glcddrivers-debuginfo-1.0.1-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/glcdgraphics-debuginfo-1.0.1-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/glcdskin-debuginfo-1.0.1-1.fc29.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/graphlcd-tools-debuginfo-1.0.1-1.fc29.x86_64.rpm graphlcd-base.spec: I: checking graphlcd-base.spec: I: checking-url https://projects.vdr-developer.org/git/graphlcd-base.git/snapshot/graphlcd-b... (timeout 10 seconds) graphlcd-base.src: I: checking graphlcd-base.src: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) graphlcd-base.src: I: checking-url https://projects.vdr-developer.org/git/graphlcd-base.git/snapshot/graphlcd-b... (timeout 10 seconds) glcddrivers.x86_64: I: checking glcddrivers.x86_64: W: spelling-error %description -l en_US graphlcd -> graphical The value of this tag appears to be misspelled. Please double-check.
glcddrivers.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) graphlcd-devel.x86_64: I: checking graphlcd-devel.x86_64: W: no-dependency-on graphlcd/graphlcd-libs/libgraphlcd graphlcd-devel.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) glcdgraphics.x86_64: I: checking glcdgraphics.x86_64: W: spelling-error %description -l en_US graphlcd -> graphical The value of this tag appears to be misspelled. Please double-check.
glcdgraphics.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) glcdskin.x86_64: I: checking glcdskin.x86_64: W: spelling-error %description -l en_US graphlcd -> graphical The value of this tag appears to be misspelled. Please double-check.
glcdskin.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) glcdskin.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
graphlcd-common.x86_64: I: checking graphlcd-common.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) graphlcd-common.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share.
graphlcd-tools.x86_64: I: checking graphlcd-tools.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) graphlcd-tools.x86_64: W: no-manual-page-for-binary convpic Each executable in standard binary directories should have a man page.
graphlcd-tools.x86_64: W: no-manual-page-for-binary crtfont Each executable in standard binary directories should have a man page.
graphlcd-tools.x86_64: W: no-manual-page-for-binary genfont Each executable in standard binary directories should have a man page.
graphlcd-tools.x86_64: W: no-manual-page-for-binary lcdtestpattern Each executable in standard binary directories should have a man page.
graphlcd-tools.x86_64: W: no-manual-page-for-binary showpic Each executable in standard binary directories should have a man page.
graphlcd-tools.x86_64: W: no-manual-page-for-binary showtext Each executable in standard binary directories should have a man page.
graphlcd-tools.x86_64: W: no-manual-page-for-binary skintest Each executable in standard binary directories should have a man page.
graphlcd-base-debugsource.x86_64: I: checking graphlcd-base-debugsource.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) graphlcd-base-debuginfo.x86_64: I: checking graphlcd-base-debuginfo.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) glcddrivers-debuginfo.x86_64: I: checking glcddrivers-debuginfo.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) glcdgraphics-debuginfo.x86_64: I: checking glcdgraphics-debuginfo.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) glcdskin-debuginfo.x86_64: I: checking glcdskin-debuginfo.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) graphlcd-tools-debuginfo.x86_64: I: checking graphlcd-tools-debuginfo.x86_64: I: checking-url http://projects.vdr-developer.org/projects/graphlcd (timeout 10 seconds) 13 packages and 1 specfiles checked; 0 errors, 13 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1648426
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1648444
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1648444 [Bug 1648444] Review Request: vdr-graphlcd - VDR plugin: Output to graphic LCD
https://bugzilla.redhat.com/show_bug.cgi?id=1648426
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://projects.vdr-develo | |per.org/git/graphlcd-base.g | |it/
https://bugzilla.redhat.com/show_bug.cgi?id=1648426
--- Comment #1 from MartinKG mgansser@online.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/graphlcd-base.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/graphlcd-base-1.0.1-2.fc29.sr...
%changelog * Sat Nov 10 2018 Martin Gansser martinkg@fedoraproject.org - 1.0.1-2 - Add %%{name}-Improved-trim-function.patch
https://bugzilla.redhat.com/show_bug.cgi?id=1648426
--- Comment #2 from MartinKG mgansser@online.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/graphlcd-base.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/graphlcd-base-1.0.2-1.fc29.sr...
%changelog * Sat Nov 10 2018 Martin Gansser martinkg@fedoraproject.org - 1.0.2-1 - Update to 1.0.2
https://bugzilla.redhat.com/show_bug.cgi?id=1648426
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- - To avoid unintentional soname bump, please don't glob the major soname version. Be more specific instead:
%{_libdir}/libglcddrivers.so.2* %{_libdir}/libglcdgraphics.so.2* %{_libdir}/libglcdskin.so.2*
- [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define shortname graphlcd
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License", "GPL (v2 or later) (with incorrect FSF address)", "*No copyright* GNU General Public License", "Unknown or generated". 56 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/graphlcd-base/review- graphlcd-base/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 163840 bytes in 31 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in glcddrivers , graphlcd-devel , glcdgraphics , glcdskin , graphlcd- common , graphlcd-tools , graphlcd-base-debuginfo , graphlcd-base- debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define shortname graphlcd [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: glcddrivers-1.0.2-1.fc30.x86_64.rpm graphlcd-devel-1.0.2-1.fc30.x86_64.rpm glcdgraphics-1.0.2-1.fc30.x86_64.rpm glcdskin-1.0.2-1.fc30.x86_64.rpm graphlcd-common-1.0.2-1.fc30.x86_64.rpm graphlcd-tools-1.0.2-1.fc30.x86_64.rpm graphlcd-base-debuginfo-1.0.2-1.fc30.x86_64.rpm graphlcd-base-debugsource-1.0.2-1.fc30.x86_64.rpm graphlcd-base-1.0.2-1.fc30.src.rpm glcddrivers.x86_64: W: spelling-error %description -l en_US graphlcd -> graphical graphlcd-devel.x86_64: W: no-dependency-on graphlcd/graphlcd-libs/libgraphlcd glcdgraphics.x86_64: W: spelling-error %description -l en_US graphlcd -> graphical glcdskin.x86_64: W: spelling-error %description -l en_US graphlcd -> graphical glcdskin.x86_64: W: no-documentation graphlcd-common.x86_64: W: only-non-binary-in-usr-lib graphlcd-tools.x86_64: W: no-manual-page-for-binary convpic graphlcd-tools.x86_64: W: no-manual-page-for-binary crtfont graphlcd-tools.x86_64: W: no-manual-page-for-binary genfont graphlcd-tools.x86_64: W: no-manual-page-for-binary lcdtestpattern graphlcd-tools.x86_64: W: no-manual-page-for-binary showpic graphlcd-tools.x86_64: W: no-manual-page-for-binary showtext graphlcd-tools.x86_64: W: no-manual-page-for-binary skintest 9 packages and 0 specfiles checked; 0 errors, 13 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1648426
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- Also you must install the COPYING file as %license.
License is GPLv2+, not GPL+.
https://bugzilla.redhat.com/show_bug.cgi?id=1648426
--- Comment #5 from MartinKG mgansser@online.de --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/graphlcd-base.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/graphlcd-base-1.0.2-2.fc29.sr...
%changelog * Mon Nov 19 2018 Martin Gansser martinkg@fedoraproject.org - 1.0.2-2 - Avoid unintentional soname bump, be more specific - Use %%global instead of %%define unless justified - Install COPYING file as %%license - License is GPLv2+, not GPL+
https://bugzilla.redhat.com/show_bug.cgi?id=1648426
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #6 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1648426
--- Comment #8 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/graphlcd-base
https://bugzilla.redhat.com/show_bug.cgi?id=1648426
--- Comment #7 from MartinKG mgansser@online.de --- Many Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1648426
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2018-11-19 14:00:15
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com