https://bugzilla.redhat.com/show_bug.cgi?id=2219149
Bug ID: 2219149 Summary: Review Request: rocthrust - A ROCm parallel algorithm library Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: trix@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://trix.fedorapeople.org/rocthrust.spec SRPM URL: https://trix.fedorapeople.org/rocthrust-5.5.1-1.fc39.src.rpm FAS: trix Description: Thrust is a parallel algorithm library. This library has been ported to HIP/ROCm platform, which uses the rocPRIM library.
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2219149
Tom Rix trix@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |alexjnewt@fastmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=2219149
Jeremy Newton alexjnewt@fastmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #1 from Jeremy Newton alexjnewt@fastmail.com --- Looks good, but there's some things to fix.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
I think you should make this noarch like rocPrim right?
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "MIT License", "Boost Software License 1.0", "Boost Software License 1.0 Apache License 2.0", "Public domain", "MIT License Apache License 2.0", "BSD 2-Clause License Apache License 2.0", "BSD 3-Clause License". 500 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/rocthrust/licensecheck.txt
You should probably note all the licenses
[!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec.
The licensing looks complex, you should make a breakdown in the spec file comments as the NOTICES file isn't complete, see: https://download.copr.fedorainfracloud.org/results/mystro256/rocm-hip/fedora...
[!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc/rocthrust [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/rocthrust
Self explanatory, I think we had a similar issue in the rocPrim review
[x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged.
Please update to 5.6.0 and if you can, retest if you have the HW for it.
[x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass.
I'm just assuming that non-x86 doesn't work at this point, but I didn't test on real HW yet
[x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
The only thing of note is the duplicate files, but it's not large enough to trigger an error, so I would ignore.
[x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
https://bugzilla.redhat.com/show_bug.cgi?id=2219149
--- Comment #2 from Tom Rix trix@redhat.com --- Spec URL: https://trix.fedorapeople.org/rocthrust.spec SRPM URL: https://trix.fedorapeople.org/rocthrust-5.6.0-1.fc39.src.rpm
yes this is a headers only package like rocprim. For %check, the tests build and execute. i do not trust my hw gfx803 to work correctly.
from: https://sep5.readthedocs.io/en/latest/Installation_Guide/Installation-Guide....
"The following list of GPUs are enabled in the ROCm software, though full support is not guaranteed:
GFX8 GPUs “Polaris 11” chips, such as on the AMD Radeon RX 570 and Radeon Pro WX 4100
“Polaris 12” chips, such as on the AMD Radeon RX 550 and Radeon RX 540"
I have rx 550, its better than a 540 ;)
https://bugzilla.redhat.com/show_bug.cgi?id=2219149
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/ROCmSoft | |warePlatform
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6135019 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2219149
Jeremy Newton alexjnewt@fastmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Jeremy Newton alexjnewt@fastmail.com ---
%dir %{_datadir}/cmake/%{name}/
This is actually redundant, but not harmful
Also there really ought to be a license breakdown, but we can fix this later.
I'll test on real HW after I'm done with Tensile/rocblas.
Approved
https://bugzilla.redhat.com/show_bug.cgi?id=2219149
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rocthrust
https://bugzilla.redhat.com/show_bug.cgi?id=2219149
Jeremy Newton alexjnewt@fastmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|POST |CLOSED Last Closed| |2023-07-07 19:57:06
https://bugzilla.redhat.com/show_bug.cgi?id=2219149
--- Comment #6 from Jeremy Newton alexjnewt@fastmail.com --- Tom side note, please make sure you use the *-static in the build requires instead of the -devel package, as per:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header...
Packages which use the header library must BuildRequire: foo-static, so that the usage can be tracked.
I should probably fix a few of my own packages, as I missed this.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com