[Bug 221010] New: Review Request: librfid - Free Software RFID library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221010

Summary: Review Request: librfid - Free Software RFID library
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://freeshell.in/~kushal/librfid.spec
SRPM URL: http://freeshell.in/~kushal/librfid-0.1.0-1.src.rpm
Description: librfid is a Free Software RFID library. It implements the PCD (reader) side protocol stack of ISO 14443 A, ISO 14443 B, ISO 15693, 
Mifare Ultralight and Mifare Classic. Support for iCODE and other 13.56MHz based transponders is planned.

[Bug 221010] Review Request: librfid - Free Software RFID library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librfid - Free Software RFID library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221010

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: librfid -   |Review Request: librfid -
                   |Free Software RFID library  |Free Software RFID library
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

[Bug 221010] Review Request: librfid - Free Software RFID library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librfid - Free Software RFID library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221010

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-12-30 14:25 EST -------
MD5Sum:
695e7f30f570a08407e42ed278ca2fe3  librfid-0.1.0.tar.bz2

Good:
* Source URL is canonical.
* License field in spec, match tarball license.
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros.
* All necessary BuildRequires listed.
* Files have appropriate permissions and owners.
* Package name conforms to the Fedora Naming Guidelines.
* rpmlint produces no errors.
* Package builds in Mock fine.
* Package install and uninstalls cleanly on FC6.

Minor:
* I really don't think you need to add the same docs that are in the main
package to the devel package.  This isn't a blocker, but I would drop them.

+1 APPROVED

[Bug 221010] Review Request: librfid - Free Software RFID library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librfid - Free Software RFID library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221010

------- Additional Comments From [e-mail]  2006-12-30 17:52 EST -------
One thing to consider:

The %{_bindir}/send_script in the main package has a very generic
file name and bears the risk of creating a conflict with other
packages. The upstream authors are advised to choose a more unique
file name.

[Bug 221010] Review Request: librfid - Free Software RFID library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librfid - Free Software RFID library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221010

------- Additional Comments From [e-mail]  2006-12-31 03:18 EST -------
(In reply to comment #1)
> Minor:
> I really don't think you need to add the same docs that are in the main
>
> package to the devel package.  This isn't a blocker, but I would drop them.
>
> +1 APPROVED

Done :)

[Bug 221010] Review Request: librfid - Free Software RFID library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librfid - Free Software RFID library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221010

------- Additional Comments From [e-mail]  2006-12-31 03:19 EST -------
(In reply to comment #2)
> One thing to consider:
>
> The %{_bindir}/send_script in the main package has a very generic
> file name and bears the risk of creating a conflict with other
> packages. The upstream authors are advised to choose a more unique
> file name.

Will inform the upstream authors.

[Bug 221010] Review Request: librfid - Free Software RFID library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librfid - Free Software RFID library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221010

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 221010] Review Request: librfid - Free Software RFID library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librfid - Free Software RFID library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221010

------- Additional Comments From [e-mail]  2006-12-31 04:27 EST -------
(I'm the upstream author):

The send_script program has been renamed into librfid_send_script in our SVN
tree. The next release of the library will reflact that change.

Thanks for letting us know.

[Bug 221010] Review Request: librfid - Free Software RFID library

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: librfid - Free Software RFID library

https://bugzilla.redhat.com/show_bug.cgi?id=221010

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide