[Bug 2129837] New: Review Request: perl-Alien-Build-Plugin-Download-GitLab - Alien::Build plugin to download from GitLab
https://bugzilla.redhat.com/show_bug.cgi?id=2129837
Bug ID: 2129837 Summary: Review Request: perl-Alien-Build-Plugin-Download-GitLab - Alien::Build plugin to download from GitLab Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jplesnik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jplesnik.fedorapeople.org/perl-Alien-Build-Plugin-Download-GitLab/pe... SRPM URL: https://jplesnik.fedorapeople.org/perl-Alien-Build-Plugin-Download-GitLab/pe... Description: This plugin is designed for downloading assets from a GitLab instance.
Fedora Account System Username: jplesnik@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2129837
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2129628
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2129628 [Bug 2129628] perl-Alien-Libxml2-0.19 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2129837
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Flags| |fedora-review? Assignee|nobody@fedoraproject.org |ppisar@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2129837
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar ppisar@redhat.com --- URL and Source0 addresses are usable. Ok. TODO: Remove a trailing slash from URL tag value.
Source archive (SHA-512: 5a1a1dcefbec09732e377c47a961d57cc21a54fef154158dbad1738a93a143348ddc69430b35207d9db111a74592a7120b2abf2f7045818a74a6397bbf07fb06) is original. Ok. Summary verified from lib/Alien/Build/Plugin/Download/GitLab.pm. Ok. Description verified from lib/Alien/Build/Plugin/Download/GitLab.pm. Ok. License verified from lib/Alien/Build/Plugin/Download/GitLab.pm, dist.ini, README, LICENSE. Ok. No XS code, noarch BuildArch is Ok. Build-requires are Ok. All tests pass. Ok.
$ rpmlint perl-Alien-Build-Plugin-Download-GitLab.spec ../SRPMS/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.src.rpm ../RPMS/noarch/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.noarch.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3
========= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ======== rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.noarch.rpm drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/doc/perl-Alien-Build-Plugin-Download-GitLab -rw-r--r-- 1 root root 115 Sep 24 00:11 /usr/share/doc/perl-Alien-Build-Plugin-Download-GitLab/Changes -rw-r--r-- 1 root root 1931 Sep 24 00:11 /usr/share/doc/perl-Alien-Build-Plugin-Download-GitLab/README drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/licenses/perl-Alien-Build-Plugin-Download-GitLab -rw-r--r-- 1 root root 18344 Sep 24 00:11 /usr/share/licenses/perl-Alien-Build-Plugin-Download-GitLab/LICENSE -rw-r--r-- 1 root root 2069 Sep 29 18:16 /usr/share/man/man3/Alien::Build::Plugin::Download::GitLab.3pm.gz drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/perl5/vendor_perl/Alien drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/perl5/vendor_perl/Alien/Build drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/perl5/vendor_perl/Alien/Build/Plugin drwxr-xr-x 2 root root 0 Sep 29 18:16 /usr/share/perl5/vendor_perl/Alien/Build/Plugin/Download -rw-r--r-- 1 root root 5963 Sep 24 00:11 /usr/share/perl5/vendor_perl/Alien/Build/Plugin/Download/GitLab.pm File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(:VERSION) >= 5.8.4 1 perl(Alien::Build::Plugin) 1 perl(Carp) 1 perl(File::Basename) 1 perl(JSON::PP) 1 perl(Path::Tiny) 1 perl(strict) 1 perl(URI) 1 perl(URI::Escape) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.noarch.rpm | sort -f | uniq -c 1 perl(Alien::Build::Plugin::Download::GitLab) = 0.01 1 perl-Alien-Build-Plugin-Download-GitLab = 0.01-1.fc38 Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Alien-Build-Plugin-Download-GitLab-0.01-1.fc38.noarch.rpm Binary dependencies are resolvable. Ok.
The package builds in Fedora 38 (https://koji.fedoraproject.org/koji/taskinfo?taskID=92421764). Ok.
The package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2129837
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- https://pagure.io/releng/fedora-scm-requests/issue/47843
https://bugzilla.redhat.com/show_bug.cgi?id=2129837
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-Build-Plugin-Download-GitLab
https://bugzilla.redhat.com/show_bug.cgi?id=2129837
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |perl-Alien-Build-Plugin-Dow | |nload-GitLab-0.01-1.fc38
--- Comment #4 from Jitka Plesnikova jplesnik@redhat.com --- Thank you for review and repository.
https://bugzilla.redhat.com/show_bug.cgi?id=2129837
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|ASSIGNED |CLOSED Last Closed| |2022-10-03 09:48:08
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com