https://bugzilla.redhat.com/show_bug.cgi?id=1103226
Bug ID: 1103226 Summary: Review Request: antlr32 - ANother Tool for Language Recognition Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mat.booth@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://fedorapeople.org/~mbooth/reviews/antlr32.spec SRPM URL: http://fedorapeople.org/~mbooth/reviews/antlr32-3.2-1.fc21.src.rpm Description: ANother Tool for Language Recognition, is a grammar parser generator. This package is compatibility package containing an older version of in order to support jython. No other packages should declare a dependency on this one.
Fedora Account System Username: mbooth
https://bugzilla.redhat.com/show_bug.cgi?id=1103226
--- Comment #1 from Mat Booth mat.booth@redhat.com --- Here is a rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6911674
This package bootstraps itself using a previous build. Once built for rawhide, I will bump the release number and rebuild it with the bootstrap flag disabled to generate a fully self-hosted version.
https://bugzilla.redhat.com/show_bug.cgi?id=1103226
Pete MacKinnon pmackinn@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pmackinn@redhat.com Assignee|nobody@fedoraproject.org |pmackinn@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1103226
Pete MacKinnon pmackinn@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1103226
--- Comment #2 from Pete MacKinnon pmackinn@redhat.com --- MUST: [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/java/antlr32
SHOULD: [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. It would be nice to have a link to the JIRA where Java 8 patch originated.
[!]: %check is present and all tests pass. Test failures noted at %mvn_build -f with provided comment.
Will approve once dir ownership corrected.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/pmackinn/rpmbuild/1103226-antlr32/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL - This seems like a Java package, please install fedora-review-plugin-java to get additional checks
===== MUST items =====
Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 13 files have unknown license. Detailed output of licensecheck in /home/pmackinn/rpmbuild/1103226-antlr32/licensecheck.txt [X]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/java/antlr32 [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [X]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven: [X]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in antlr32 -maven-plugin , antlr32-tool , antlr32-java , antlr32-javadoc [X]: Package functions as described. [-]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
Java: [X]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: antlr32-maven-plugin-3.2-1.fc20.noarch.rpm antlr32-tool-3.2-1.fc20.noarch.rpm antlr32-java-3.2-1.fc20.noarch.rpm antlr32-javadoc-3.2-1.fc20.noarch.rpm antlr32-3.2-1.fc20.src.rpm antlr32-maven-plugin.noarch: W: spelling-error Summary(en_US) parsers -> parser, parses, parers antlr32-maven-plugin.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr32-tool.noarch: W: spelling-error Summary(en_US) parsers -> parser, parses, parers antlr32-tool.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr32-java.noarch: W: spelling-error Summary(en_US) parsers -> parser, parses, parers antlr32-java.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr32.src: W: spelling-error Summary(en_US) ANother -> Another, Anther, An other antlr32.src: W: spelling-error %description -l en_US ANother -> Another, Anther, An other antlr32.src: W: spelling-error %description -l en_US jython -> python, Python antlr32.src: W: file-size-mismatch antlr-3.1.3.jar = 893923, http://repo1.maven.org/maven2/org/antlr/antlr/3.1.3/antlr-3.1.3.jar = 893842 5 packages and 0 specfiles checked; 0 errors, 10 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint antlr32-maven-plugin antlr32-tool antlr32-javadoc antlr32-java antlr32-maven-plugin.noarch: W: spelling-error Summary(en_US) parsers -> parser, parses, parers antlr32-maven-plugin.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr32-tool.noarch: W: spelling-error Summary(en_US) parsers -> parser, parses, parers antlr32-tool.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers antlr32-java.noarch: W: spelling-error Summary(en_US) parsers -> parser, parses, parers antlr32-java.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers 4 packages and 0 specfiles checked; 0 errors, 6 warnings. # echo 'rpmlint-done:'
Requires -------- antlr32-maven-plugin (rpmlib, GLIBC filtered): antlr32-tool java jpackage-utils mvn(org.antlr:antlr) mvn(org.apache.maven:maven-plugin-api) mvn(org.apache.maven:maven-project) mvn(org.codehaus.plexus:plexus-compiler-api)
antlr32-tool (rpmlib, GLIBC filtered): antlr32-java java jpackage-utils mvn(org.antlr:antlr-runtime)
antlr32-javadoc (rpmlib, GLIBC filtered): jpackage-utils
antlr32-java (rpmlib, GLIBC filtered): java jpackage-utils mvn(org.antlr:stringtemplate) stringtemplate
Provides -------- antlr32-maven-plugin: antlr32-maven-plugin mvn(org.antlr:antlr3-maven-plugin)
antlr32-tool: antlr32-tool mvn(org.antlr:antlr)
antlr32-javadoc: antlr32-javadoc
antlr32-java: antlr32-java mvn(org.antlr:antlr-master) mvn(org.antlr:antlr-master:pom:) mvn(org.antlr:antlr-runtime)
Source checksums ---------------- http://repo1.maven.org/maven2/org/antlr/antlr/3.1.3/antlr-3.1.3.jar : CHECKSUM(SHA256) this package : d2e3fdca6bb3e21cbdabae96cf9a9db7ff98249531baf9d156df71f0503653b2 CHECKSUM(SHA256) upstream package : b7e22e20c4cb9733269d69089881a35be407d648e824412c13275e5ec6938a49 http://repo1.maven.org/maven2/org/antlr/antlr/3.1.3/antlr-3.1.3.pom : CHECKSUM(SHA256) this package : 4f3182cf91c955f9ec4c9b4e4fdbfa1faae82d98f7e44b0f573830d30b22c80d CHECKSUM(SHA256) upstream package : 4f3182cf91c955f9ec4c9b4e4fdbfa1faae82d98f7e44b0f573830d30b22c80d http://www.antlr3.org/download/antlr-3.2.tar.gz : CHECKSUM(SHA256) this package : 01548fa03ef1f0ed05a93f0749b65db8a35a191ad7ad34e1e6a6a2529ca2ef45 CHECKSUM(SHA256) upstream package : 01548fa03ef1f0ed05a93f0749b65db8a35a191ad7ad34e1e6a6a2529ca2ef45 http://repo1.maven.org/maven2/org/antlr/antlr-master/3.1.3/antlr-master-3.1.... : CHECKSUM(SHA256) this package : e2c4d35418a94696bc65cd2053c8c2289d724a2d22c7b1afa006755761ef467d CHECKSUM(SHA256) upstream package : e2c4d35418a94696bc65cd2053c8c2289d724a2d22c7b1afa006755761ef467d http://repo1.maven.org/maven2/org/antlr/antlr3-maven-plugin/3.1.3-1/antlr3-m... : CHECKSUM(SHA256) this package : 57357f118a105cb439a28aa1e147d733d9d777842b1296b53af03059b2cf6c57 CHECKSUM(SHA256) upstream package : 57357f118a105cb439a28aa1e147d733d9d777842b1296b53af03059b2cf6c57 http://repo1.maven.org/maven2/org/antlr/antlr3-maven-plugin/3.1.3-1/antlr3-m... : CHECKSUM(SHA256) this package : 85b54ff92b88f532e03d5da6d7e4ea1b26f505bfb048ce85dbcc5bc4868c4996 CHECKSUM(SHA256) upstream package : 85b54ff92b88f532e03d5da6d7e4ea1b26f505bfb048ce85dbcc5bc4868c4996 http://repo1.maven.org/maven2/org/antlr/antlr-runtime/3.1.3/antlr-runtime-3.... : CHECKSUM(SHA256) this package : 4beb8f7fc1396ec7ebfd10ab785b80c38d0f5098cc484177b0552a99048e7549 CHECKSUM(SHA256) upstream package : 4beb8f7fc1396ec7ebfd10ab785b80c38d0f5098cc484177b0552a99048e7549 http://repo1.maven.org/maven2/org/antlr/antlr-runtime/3.1.3/antlr-runtime-3.... : CHECKSUM(SHA256) this package : d2c8a9d10a6f6aa554796ed55733ab725c2e56318e77a39971d7f79f7373a9eb CHECKSUM(SHA256) upstream package : d2c8a9d10a6f6aa554796ed55733ab725c2e56318e77a39971d7f79f7373a9eb diff -r also reports differences
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1103226 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
https://bugzilla.redhat.com/show_bug.cgi?id=1103226
--- Comment #3 from Mat Booth mat.booth@redhat.com --- Thanks for the review.
(In reply to Pete MacKinnon from comment #2)
MUST: [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/java/antlr32
Hmm, I'm not sure why this is reported, the java subpackage should own this. In the spec file, you should see this:
%files java -f .mfiles-java %doc tool/LICENSE.txt %dir %{_datadir}/java/%{name}
The %dir line should expand to /usr/share/java/antlr32
Do you have any thoughts about what is wrong here?
SHOULD: [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. It would be nice to have a link to the JIRA where Java 8 patch originated.
Good point, I will add a link to the upstream commit.
https://bugzilla.redhat.com/show_bug.cgi?id=1103226
Pete MacKinnon pmackinn@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Pete MacKinnon pmackinn@redhat.com --- $ rpm -qf /usr/share/java/antlr32 antlr32-java-3.2-1.fc20.noarch
Hmm, false positive from fedora-review 0.5.1 for some reason. Sorry about that...
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1103226
Mat Booth mat.booth@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Mat Booth mat.booth@redhat.com --- New Package SCM Request ======================= Package Name: antlr32 Short Description: ANother Tool for Language Recognition Upstream URL: http://www.antlr3.org/ Owners: mbooth Branches: f20 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1103226
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1103226
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1103226
Mat Booth mat.booth@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |antlr32-3.2-3.fc21 Resolution|--- |NEXTRELEASE Last Closed| |2014-06-02 11:28:22
--- Comment #7 from Mat Booth mat.booth@redhat.com --- Successfully built: http://koji.fedoraproject.org/koji/buildinfo?buildID=520948
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla