[Bug 428250] New: Review Request: gpicview - A simple fast image viewer - package-review

List overview All Threads
Download

newer

[Bug 428250] New: Review Request: gpicview - A simple fast image viewer

older

[Bug 458054] Review Request: arm4...

[Bug 214236] New: Review Request:...

Red Hat Bugzilla

10 Jan 2008 10 Jan '08

12:52 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=428250

Summary: Review Request: gpicview - A simple fast image viewer Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: marc@mwiriadi.id.au QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview.spec SRPM URL: http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview-0.1.7-1.fc8.src.... Description: Gpicview is an image viewer that is: Extremely lightweight and fast with low memory usage Very suitable for default image viewer of desktop system Simple and intuitive interface Minimal lib dependency: Only pure GTK+ is used Desktop independent: Doesn't require any specific desktop environment

RPM Lint: On RPM file [marc@Strike-Lap i386]$ rpmlint gpicview-0.1.7-1.fc8.i386.rpm gpicview.i386: E: zero-length /usr/share/doc/gpicview-0.1.7/README gpicview.i386: E: zero-length /usr/share/doc/gpicview-0.1.7/NEWS gpicview.i386: E: zero-length /usr/share/doc/gpicview-0.1.7/TODO gpicview.i386: E: zero-length /usr/share/doc/gpicview-0.1.7/ChangeLog gpicview.i386: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/de_DE/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/pt_BR/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/sk/LC_MESSAGES/gpicview.mo gpicview.i386: W: file-not-in-%lang /usr/share/locale/zh_TW/LC_MESSAGES/gpicview.mo On SRPM: Nothing

Only issue I have thats severe is the *.mo files and I'm not to sure how to fix it. I can compile it in F-8 yet mock building it in devel doesn't build claiming that the *mo files do not exist.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by thread

Red Hat Bugzilla

10 Jan 10 Jan

1:09 p.m.

New subject: [Bug 428250] Review Request: gpicview - A simple fast image viewer

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gpicview - A simple fast image viewer

https://bugzilla.redhat.com/show_bug.cgi?id=428250

panemade@gmail.com changed:

------- Additional Comments From panemade@gmail.com 2008-01-10 07:09 EST ------- 1) You are not using http://fedoraproject.org/wiki/Packaging/Guidelines#head-8c605ebf8330f6d505f3...

2) remove .mo from %files

3) add gettext as BR

4) you don't need pkgconfig as BR

5) remove empty files README NEWS TODO Changelog

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1:48 p.m.

New subject: [Bug 428250] Review Request: gpicview - A simple fast image viewer

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gpicview - A simple fast image viewer

https://bugzilla.redhat.com/show_bug.cgi?id=428250

------- Additional Comments From marc@mwiriadi.id.au 2008-01-10 07:48 EST ------- Fixed.

http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview.spec http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview-0.1.7-2.fc8.src....

Thanks for the link I had read it but missed that part I've bookmarked it now.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11 Jan 11 Jan

7:18 a.m.

New subject: [Bug 428250] Review Request: gpicview - A simple fast image viewer

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gpicview - A simple fast image viewer

https://bugzilla.redhat.com/show_bug.cgi?id=428250

------- Additional Comments From panemade@gmail.com 2008-01-11 01:18 EST ------- Created an attachment (id=291354) --> (https://bugzilla.redhat.com/attachment.cgi?id=291354&action=view) Some Cleanups to SPEC

I did some changes to description, desktop-file-install command. Use this SPEC and provide new update for review.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:21 a.m.

New subject: [Bug 428250] Review Request: gpicview - A simple fast image viewer

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gpicview - A simple fast image viewer

https://bugzilla.redhat.com/show_bug.cgi?id=428250

------- Additional Comments From marc@mwiriadi.id.au 2008-01-11 04:21 EST ------- Done http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview.spec http://mwiriadi.fedorapeople.org/packages/gpicview/gpicview-0.1.7-3.fc8.src....

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12:09 p.m.

New subject: [Bug 428250] Review Request: gpicview - A simple fast image viewer

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gpicview - A simple fast image viewer

https://bugzilla.redhat.com/show_bug.cgi?id=428250

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From panemade@gmail.com 2008-01-11 06:09 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url a1e70f726dbdb4c2aa456a50a3f535fd gpicview-0.1.7.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + desktop file installed correctly. + no duplicates in %files. + file permissions are appropriate. + Desktop file handled correctly. + GUI app.

APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:53 p.m.

New subject: [Bug 428250] Review Request: gpicview - A simple fast image viewer

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gpicview - A simple fast image viewer

https://bugzilla.redhat.com/show_bug.cgi?id=428250

marc@mwiriadi.id.au changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From marc@mwiriadi.id.au 2008-01-11 10:53 EST ------- ======================= Package Name: gpicview Short Description: A simple fast image viewer Owners: mwiriad Branches: F-7 F-8 devel InitialCC: mwiriad Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:59 p.m.

New subject: [Bug 428250] Review Request: gpicview - A simple fast image viewer

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gpicview - A simple fast image viewer

https://bugzilla.redhat.com/show_bug.cgi?id=428250

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-01-11 16:59 EST ------- cvs done. (with corrected owner account name)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12 Jan 12 Jan

10:08 a.m.

New subject: [Bug 428250] Review Request: gpicview - A simple fast image viewer

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gpicview - A simple fast image viewer

https://bugzilla.redhat.com/show_bug.cgi?id=428250

marc@mwiriadi.id.au changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1 Dec 1 Dec

1:40 p.m.

New subject: [Bug 428250] Review Request: gpicview - A simple fast image viewer

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=428250

Patrice Dumas pertusus@free.fr changed:

--- Comment #8 from Patrice Dumas pertusus@free.fr 2008-12-01 07:40:42 EDT --- Package Change Request ====================== Package Name: gpicview New Branches: EL-5 Owners: pertusus

Marc agreed by mail that I could be the EL-5 maintainer. He should be able to confirm here.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:59 p.m.

New subject: [Bug 428250] Review Request: gpicview - A simple fast image viewer

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=428250

--- Comment #9 from Marc Wiriadisastra marc@mwiriadi.id.au 2008-12-01 07:59:39 EDT --- I have agreed for Patrice to be the EL-5 maintainer I'm in the process of adding him in pkgdb

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:03 p.m.

New subject: [Bug 428250] Review Request: gpicview - A simple fast image viewer

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=428250

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #10 from Kevin Fenzi kevin@tummy.com 2008-12-01 17:03:35 EDT --- cvs done.

(you likely need the EL-5 branch before pkgdb will show it to add him. ;)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

6078

Age (days ago)

6404

Last active (days ago)

package-review@lists.fedoraproject.org

11 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla