[Bug 2116066] New: Review Request: rust-primal-estimate - State-of-the-art estimation of upper and lower bounds for π(n) (the number of primes below n) and p_k (the k-th prime)

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

Bug ID: 2116066
           Summary: Review Request: rust-primal-estimate -
                    State-of-the-art estimation of upper and lower bounds
                    for π(n) (the number of primes below n) and p_k (the
                    k-th prime)
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://orion.fedorapeople.org/rust-primal-estimate.spec
SRPM URL:
https://orion.fedorapeople.org/rust-primal-estimate-0.3.1-1.fc37.src.rpm
Description:

State-of-the-art estimation of upper and lower bounds for π(n) (the number of
primes below n) and p_k (the k-th prime)

Fedora Account System Username: orion

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90541929

[Bug 2116066] Review Request: rust-primal-estimate - State-of-the-art estimation of upper and lower bounds for π(n) (the number of primes below n) and p_k (the k-th prime)

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2116081

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2116081
[Bug 2116081] Review Request: rust-primal-slowsieve - Simple sieve of
Eratosthenes designed for testing faster sieves

[Bug 2116066] Review Request: rust-primal-estimate - State-of-the-art estimation of upper and lower bounds for π(n) (the number of primes below n) and p_k (the k-th prime)

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2116083

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2116083
[Bug 2116083] Review Request: rust-primal - `primal` puts raw power into prime
numbers

[Bug 2116066] Review Request: rust-primal-estimate - State-of-the-art estimation of upper and lower bounds for π(n) (the number of primes below n) and p_k (the k-th prime)

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Fabio Valentini  ---
Please open an issue with upstream to remind them that redistributed code (i.e.
also the crates they individually publish and redistribute via crates.io) need
to contain license files for MIT and Apache-2.0 licenses.

For reference, I've opened dozens of similar issues for other crates, like
here: https://github.com/danieldg/ordered-stream/issues/1

[Bug 2116066] Review Request: rust-primal-estimate - State-of-the-art estimation of upper and lower bounds for π(n) (the number of primes below n) and p_k (the k-th prime)

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

--- Comment #2 from Orion Poplawski  ---
I've filed https://github.com/huonw/primal/issues/42

[Bug 2116066] Review Request: rust-primal-estimate - State-of-the-art estimation of upper and lower bounds for π(n) (the number of primes below n) and p_k (the k-th prime)

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

--- Comment #3 from Orion Poplawski  ---
Upstream now provides the license files.

Spec URL: https://orion.fedorapeople.org/rust-primal-estimate.spec
SRPM URL:
https://orion.fedorapeople.org/rust-primal-estimate-0.3.2-1.fc38.src.rpm

[Bug 2116066] Review Request: rust-primal-estimate - State-of-the-art estimation of upper and lower bounds for π(n) (the number of primes below n) and p_k (the k-th prime)

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED

--- Comment #4 from Fabio Valentini  ---
Looks like you didn't regenerate the spec file with rust2rpm for 0.3.2?
> # Upstream license specification: MIT/Apache-2.0

This line is no longer generated, it looks like upstream changed this to "MIT
OR Apache-2.0" with v0.3.2.

Another (small) issue is the overly long Summary tag. Please shorten it so
sensible length, something like

Summary:        Estimation of the number of primes below n and the k-th prime
instead of
Summary:        State-of-the-art estimation of upper and lower bounds for π(n)
(the number of primes below n) and p_k (the k-th prime)

The summary shouldn't be longer than ~70 characters.

Other than that, the package looks good, and I'll approve it once those two are
cleaned up.

PS: Please make sure you don't "fedpkg import" the SRPM file that you uploaded,
but either copy the files manually into the new dist-git repo, or rebuild the
SRPM with "rpmbuild -bs" first (which doesn't mangle rpmautospec macros).

[Bug 2116066] Review Request: rust-primal-estimate - State-of-the-art estimation of upper and lower bounds for π(n) (the number of primes below n) and p_k (the k-th prime)

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

--- Comment #5 from Orion Poplawski  ---
Okay, I believe I've fixed those issues.

[Bug 2116066] Review Request: rust-primal-estimate - State-of-the-art estimation of upper and lower bounds for π(n) (the number of primes below n) and p_k (the k-th prime)

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #6 from Fabio Valentini  ---
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
x test suite is run and all unit tests pass (tests are disabled to break a
dependency loop)
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable
for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Looks good to me now (you might want to update the bug title to match the new
summary in the .spec file).
You'll need to re-disable the tests before importing the package to Fedora,
this modification seems to have been lost when you re-ran rust2rpm.

Just as an FYI, for Rust crates which have disabled test suites to break
circular dependencies, we usually just leave the tests disabled permanently.
Doing bootstrap builds is usually not worth it.

[Bug 2116066] Review Request: rust-primal-estimate - Estimation of upper and lower bounds for π(n) and p_k

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |rust-primal-estimate -      |rust-primal-estimate -
                   |State-of-the-art estimation |Estimation of upper and
                   |of upper and lower bounds   |lower bounds for π(n) and
                   |for π(n) (the number of     |p_k
                   |primes below n) and p_k     |
                   |(the k-th prime)            |

[Bug 2116066] Review Request: rust-primal-estimate - Estimation of upper and lower bounds for π(n) and p_k

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

--- Comment #7 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-primal-estimate

[Bug 2116066] Review Request: rust-primal-estimate - Estimation of upper and lower bounds for π(n) and p_k

https://bugzilla.redhat.com/show_bug.cgi?id=2116066

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
   Fixed In Version|                            |rust-primal-estimate-0.3.2-
                   |                            |1.fc38
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2022-09-03 03:02:55

--- Comment #8 from Orion Poplawski  ---
Checked in and built.