[Bug 833154] New: Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts - package-review

List overview All Threads
Download

newer

[Bug 833154] New: Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

older

[Bug 832810] New: Review Request:...

[Bug 822491] New: Review Request:...

Red Hat Bugzilla

18 Jun 2012 18 Jun '12

12:45 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Bug ID: 833154 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: gerard@ryan.lt Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora

Spec URL: http://galileo.fedorapeople.org/eclipse-wtp-jeetools/3.4.0/0.1.20120618cvs/e...

SRPM URL: http://galileo.fedorapeople.org/eclipse-wtp-jeetools/3.4.0/0.1.20120618cvs/e...

Description: The Java EE Tools Project is a set of Eclipse plugins that provides frameworks and tools focused on the development of J2EE artifacts.

Fedora Account System Username: galileo

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

18 Jun 18 Jun

5:53 p.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

--- Comment #1 from Gerard Ryan gerard@ryan.lt --- Note: the following additional license files exist:

./plugins/org.eclipse.jst.j2ee/license/berkeley_license.html ./plugins/org.eclipse.jst.jee/license/berkeley_license.html

but I haven't been able to find any code licensed under anything besides the EPL. I don't know why these files are here, and I haven't included them.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

19 Jun 19 Jun

9:03 p.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Gerard Ryan gerard@ryan.lt changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |833641

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

22 Jun 22 Jun

1:52 a.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Krzysztof Daniel kdaniel@redhat.com changed:

--- Comment #2 from Krzysztof Daniel kdaniel@redhat.com --- I'll review this one.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:52 a.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Krzysztof Daniel kdaniel@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?

--- Comment #3 from Krzysztof Daniel kdaniel@redhat.com ---

Package Review ==============

Key: - = N/A x = Pass ! = Fail ? = Not evaluated

==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [z]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [!]: MUST Package installs properly. Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch (/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch) Requires: osgi(org.eclipse.wst.wsdl) Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch (/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch) Requires: osgi(org.eclipse.wst.ws.explorer) Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch (/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch) Requires: osgi(org.eclipse.wst.ws) Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch (/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch) Requires: osgi(org.eclipse.wst.command.env.core) Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch (/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch) Requires: eclipse-wtp-webservices Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch (/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch) Requires: osgi(org.eclipse.wst.wsdl.validation) Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch (/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch) Requires: osgi(org.eclipse.wst.ws.parser) Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch (/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch) Requires: osgi(org.eclipse.wst.ws.ui) Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch (/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch) Requires: osgi(org.eclipse.wst.command.env)

[!]: MUST Requires correct, justified where necessary. Eclipse bundles should have version specified (as they are very version sensitive).

[x]: MUST Rpmlint output is silent.

rpmlint eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.src.rpm

eclipse-wtp-jeetools.src: W: invalid-url Source0: eclipse-wtp-jeetools-3.4.0-HEAD-20120618cvs.tar.xz 1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. Package has no sources or they are generated by developer [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source1: fetch-wtp-jeetools.sh (fetch-wtp-jeetools.sh) Patch0: jeetools-fix-javax-wsdl-versions.patch (jeetools-fix-javax-wsdl- versions.patch) Patch1: jeetools-jst.enterprise_core-fix-featurexml.patch (jeetools-jst.enterprise_core-fix-featurexml.patch) Patch2: jeetools-fix- jst-enterpriseui-featurexml.patch (jeetools-fix-jst-enterpriseui- featurexml.patch) Patch3: jeetools-jem.proxy-fix-getTypeClass- method.patch (jeetools-jem.proxy-fix-getTypeClass-method.patch) Patch4: jeetools-jst.j2ee.webservice-manifest.patch (jeetools-jst.j2ee .webservice-manifest.patch) [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.

==== Java ==== [x]: MUST If source tarball includes bundled jar/class files these need to be removed prior to building [x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils [x]: MUST Fully versioned dependency in subpackages, if present. [-]: MUST Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present [-]: MUST Javadoc subpackages have Requires: jpackage-utils [-]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present [x]: SHOULD Package has BuildArch: noarch (if possible) [x]: SHOULD Package uses upstream build method (ant/maven/etc.)

==== Maven ==== [x]: MUST Old add_to_maven_depmap macro is not being used [x]: MUST If package contains pom.xml files install it (including depmaps) even when building with ant

Issues: (1) Installation issues - missing dependencies on f18 (2) Majority of patches have incorrect names. (3) Unversioned 'Requires'.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:11 a.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

--- Comment #4 from Gerard Ryan gerard@ryan.lt --- Thanks for taking this!

Regarding Issue (1): Is this relating to the errors in this part?: [!]: MUST Package installs properly.

All of the osgi packages that give an error there, are from eclipse-wtp-webservices, and indeed eclipse-wtp-webservices is throwing an error here. I don't understand this, as eclipse-wtp-webservices is already in rawhide[1]. Is it not finding this package, or am I misunderstanding the issue?

[1] http://koji.fedoraproject.org/koji/packageinfo?packageID=14110

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

8:37 a.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

--- Comment #5 from Gerard Ryan gerard@ryan.lt --- Issue (3): For the eclipse bundles, I understand that the versions for the osgi bundles are specified in the MANIFEST.MF files for each plugin. At the moment, they look like this by default:

org.eclipse.wst.wsdl;bundle-version="[1.2.0,1.3.0)"

- is that enough or should they require the exact bundle that's packaged in Fedora? In which case the above example would look like: org.eclipse.wst.wsdl;bundle-version="1.2.300"

The default in that example seems to work fine[1]. I don't know why none of that stuff was being picked up when you tried to build.

[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=4187879

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4:50 p.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

--- Comment #6 from Gerard Ryan gerard@ryan.lt --- Spec URL: http://galileo.fedorapeople.org/eclipse-wtp-jeetools/3.4.0/0.2.20120618cvs/e... SRPM URL: http://galileo.fedorapeople.org/eclipse-wtp-jeetools/3.4.0/0.2.20120618cvs/e...

- changed the patch names to be properly prefixed by %{name} - added min versions to all BR/R except java and jpackage-utils

In your first review, it seems that eclipse-wtp-webservices wasn't included as a dependency for some reason, even though it's in rawhide, as linked in comment #4 above. Any ideas why that might be? Is there something I haven't done with that package that's preventing it?

Thanks again for your time!

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

25 Jun 25 Jun

3:17 a.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Krzysztof Daniel kdaniel@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #7 from Krzysztof Daniel kdaniel@redhat.com --- Thanks, for the package.

APPROVED.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:40 a.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Gerard Ryan gerard@ryan.lt changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #8 from Gerard Ryan gerard@ryan.lt --- New Package SCM Request ======================= Package Name: eclipse-wtp-jeetools Short Description: A set of Eclipse plugins that provides frameworks and tools focused on the development of J2EE artifacts Owners: galileo Branches: f17 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

10:07 p.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Gerard Ryan gerard@ryan.lt changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |835338

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

26 Jun 26 Jun

10:05 a.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

27 Jun 27 Jun

6:14 p.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

6:15 p.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- eclipse-wtp-jeetools-3.4.0-0.2.20120618cvs.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/eclipse-wtp-jeetools-3.4.0-0.2.20120...

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

28 Jun 28 Jun

7:59 p.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Gerard Ryan gerard@ryan.lt changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|833641 |

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

8:06 p.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Gerard Ryan gerard@ryan.lt changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|835338 |

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

30 Jun 30 Jun

3:26 a.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- eclipse-wtp-jeetools-3.4.0-0.2.20120618cvs.fc17 has been pushed to the Fedora 17 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7 Jul 7 Jul

4:55 p.m.

New subject: [Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts

https://bugzilla.redhat.com/show_bug.cgi?id=833154

Fedora Update System updates@fedoraproject.org changed:

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- eclipse-wtp-jeetools-3.4.0-0.2.20120618cvs.fc17 has been pushed to the Fedora 17 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug.

4763

Age (days ago)

4782

Last active (days ago)

package-review@lists.fedoraproject.org

17 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla