Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: jboss-msc - JBoss Modular Service Container
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Summary: Review Request: jboss-msc - JBoss Modular Service Container Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mgoldman@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://goldmann.fedorapeople.org/package_review/jboss-msc/1/jboss-msc.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/jboss-msc/1/jboss-msc-1.0.0-... Description: This package contains the JBoss Modular Service Container.
$ rpmlint ./jboss-msc.spec ./jboss-msc.spec: W: invalid-url Source0: jboss-msc-1.0.0.GA.tar.xz 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
$ rpmlint jboss-msc-1.0.0-1.fc15.src.rpm jboss-msc.src: I: enchant-dictionary-not-found en_US jboss-msc.src: W: invalid-url URL: http://www.jboss.org HTTP Error 403: Forbidden jboss-msc.src: W: invalid-url Source0: jboss-msc-1.0.0.GA.tar.xz 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183(FE-JAVASIG) Depends on| |726351, 728171, 723875, | |728158
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |728208
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Bug 728202 depends on bug 723875, which changed state.
Bug 723875 Summary: Review Request: byteman - Java agent-based bytecode injection tool https://bugzilla.redhat.com/show_bug.cgi?id=723875
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Bug 728202 depends on bug 726351, which changed state.
Bug 726351 Summary: Review Request: jboss-logging - JBoss Logging Framework https://bugzilla.redhat.com/show_bug.cgi?id=726351
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Tomas Radej tradej@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tradej@redhat.com AssignedTo|nobody@fedoraproject.org |tradej@redhat.com Flag| |fedora-review?
--- Comment #1 from Tomas Radej tradej@redhat.com 2011-10-04 05:50:39 EDT --- Taking this one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
--- Comment #2 from Tomas Radej tradej@redhat.com 2011-10-06 08:46:46 EDT --- Created attachment 526696 --> https://bugzilla.redhat.com/attachment.cgi?id=526696 Patch to fix missing dependencies
Package Review ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [x] Rpmlint output: jboss-msc.src: W: invalid-url URL: http://www.jboss.org HTTP Error 403: Forbidden jboss-msc.src: W: invalid-url Source0: jboss-msc-1.0.0.GA.tar.xz 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[x] Package is named according to the Package Naming Guidelines[1]. [x] Spec file name must match the base package name, in the format %{name}.spec. [x] Package meets the Packaging Guidelines[2]. [!] Package successfully compiles and builds into binary rpms. << Dependencies missing [x] Buildroot definition is not present [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4]. [x] License field in the package spec file matches the actual license. License type: LGPLv2+ [-] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [-] All independent sub-packages have license of their own [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. [!] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5]. << Deps are missing, see Issues [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] File sections do not contain %defattr(-,root,root,-) unless changed with good reason [x] Permissions on files are set properly. [x] Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore) [x] Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing) [x] Package contains code, or permissable content. [-] Fully versioned dependency in subpackages, if present. [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Javadoc documentation files are generated and included in -javadoc subpackage [!] Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) << Folder copied is apidocs, should be apidocs/* [x] Packages have proper BuildRequires/Requires on jpackage-utils [x] Javadoc subpackages have Require: jpackage-utils [x] Package uses %global not %define [x] If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...) [-] If source tarball includes bundled jar/class files these need to be removed prior to building [x] All filenames in rpm packages must be valid UTF-8. [x] Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details) [x] If package contains pom.xml files install it (including depmaps) even when building with ant [x] pom files has correct add_maven_depmap
=== Maven === [x] Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms [x] If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment [-] If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment [x] Package DOES NOT use %update_maven_depmap in %post/%postun [x] Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro
=== Other suggestions === [x] If possible use upstream build method (maven/ant/javac) [x] Avoid having BuildRequires on exact NVR unless necessary [x] Package has BuildArch: noarch (if possible) [!] Latest version is packaged. << Version 1.0.1.GA is available
*** ISSUES *** - Javadocs - folder copied is apidocs, should be apidocs/* - Build dependencies missing: maven-injection-plugin, jboss-modules, apiviz << Apply attached patch
*** NOTES *** - Version 1.0.1.GA is available upstream - Does not build due to lack of jboss-thread, jboss-logging tools and jboss-vfs. When these packages are pre-installed in mock, builds fine - Not sure if the empty %doc macro is necessary
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
--- Comment #3 from Marek Goldmann mgoldman@redhat.com 2011-10-07 07:34:44 EDT --- Thanks for the patch, applied. Packaged 1.0.1.GA, removed empty doc macro and fixed the apidocs.
Spec URL: http://goldmann.fedorapeople.org/package_review/jboss-msc/2/jboss-msc.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/jboss-msc/2/jboss-msc-1.0.1-...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
--- Comment #4 from Tomas Radej tradej@redhat.com 2011-10-10 04:40:26 EDT --- Sorry, but the source RPM seems not to be on the specified address. Could you, please, correct it? Thank you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
--- Comment #5 from Marek Goldmann mgoldman@redhat.com 2011-10-10 06:33:11 EDT --- Tomas, you are right, I put correct packages under above links.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Bug 728202 depends on bug 728171, which changed state.
Bug 728171 Summary: Review Request: jboss-logging-tools - JBoss Logging I18n Tools https://bugzilla.redhat.com/show_bug.cgi?id=728171
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Bug 728202 depends on bug 728158, which changed state.
Bug 728158 Summary: Review Request: jboss-vfs - JBoss Virtual File System https://bugzilla.redhat.com/show_bug.cgi?id=728158
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Bug 728202 depends on bug 728208, which changed state.
Bug 728208 Summary: Review Request: jboss-threads - JBoss Threads https://bugzilla.redhat.com/show_bug.cgi?id=728208
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Tomas Radej tradej@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #6 from Tomas Radej tradej@redhat.com 2011-10-19 09:23:40 EDT --- Sorry it took so long.
*** APPROVED ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Marek Goldmann mgoldman@redhat.com 2011-10-19 09:40:33 EDT --- Thanks for review!
New Package SCM Request ======================= Package Name: jboss-msc Short Description: JBoss Modular Service Container Owners: goldmann
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
--- Comment #8 from Jon Ciesla limb@jcomserv.net 2011-10-19 09:50:22 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=728202
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks|652183(FE-JAVASIG) | Resolution| |RAWHIDE Last Closed| |2011-10-19 10:31:18
--- Comment #9 from Marek Goldmann mgoldman@redhat.com 2011-10-19 10:31:18 EDT --- Thanks for git, closing.
package-review@lists.fedoraproject.org