https://bugzilla.redhat.com/show_bug.cgi?id=1955985
Bug ID: 1955985 Summary: Review Request: rubygem-ffi-yajl - Ruby FFI wrapper around YAJL 2.x Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: dcavalca@fb.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rubygem-ffi-yajl/rubygem-ffi-yajl.s... SRPM URL: https://dcavalca.fedorapeople.org/review/rubygem-ffi-yajl/rubygem-ffi-yajl-2...
Description: Ruby FFI wrapper around YAJL 2.x.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=1955985
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |823344, 823352, 1133213 CC| |jdunn@aquezada.com
--- Comment #2 from Davide Cavalca dcavalca@fb.com --- *** Bug 1114146 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=823344 [Bug 823344] Review Request: rubygem-ohai - detects data about your system, exports as JSON for use with Chef https://bugzilla.redhat.com/show_bug.cgi?id=823352 [Bug 823352] Review Request: rubygem-chef - a client for the Chef config management system https://bugzilla.redhat.com/show_bug.cgi?id=1133213 [Bug 1133213] rubygem-chef-zero-15.0.1 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1955985
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |michel@michel-slm.name Assignee|nobody@fedoraproject.org |michel@michel-slm.name Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #3 from Michel Alexandre Salim michel@michel-slm.name --- Taking this review.
Some initial issues:
Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ - Pure Ruby package must be built as noarch - Package contains Requires: ruby(release). - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file MIT-LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text
Installation errors ------------------- Error: Problem: conflicting requests - nothing provides libyajl.so.2()(x86-64) needed by rubygem-ffi-yajl-2.4.0-1.fc35.x86_64
Is libyajl being reviewed? It should probably be marked as a blocker
https://bugzilla.redhat.com/show_bug.cgi?id=1955985
--- Comment #4 from Michel Alexandre Salim michel@michel-slm.name --- Ah, you want this:
$ sudo dnf repoquery --repo rawhide --provides yajl libyajl.so.2 libyajl.so.2()(64bit) yajl = 2.1.0-16.fc34 yajl(x86-32) = 2.1.0-16.fc34 yajl(x86-64) = 2.1.0-16.fc34
Not sure what's best here. either hardcode whether you're matching agaist 64-bit or 32-bit based on %ifarch, or... just don't specify the architecture at all.
https://bugzilla.redhat.com/show_bug.cgi?id=1955985
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #5 from Vít Ondruch vondruch@redhat.com --- This is the way vetted by RPM folks:
https://src.fedoraproject.org/rpms/rubygem-ruby-vips/blob/rawhide/f/rubygem-... https://bugzilla.redhat.com/show_bug.cgi?id=1870208#c5
https://bugzilla.redhat.com/show_bug.cgi?id=1955985
--- Comment #6 from Vít Ondruch vondruch@redhat.com --- (In reply to Vít Ondruch from comment #5)
This is the way vetted by RPM folks:
https://src.fedoraproject.org/rpms/rubygem-ruby-vips/blob/rawhide/f/rubygem- ruby-vips.spec#_16 https://bugzilla.redhat.com/show_bug.cgi?id=1870208#c5
And this should be probably used also as a BR instead of the yajl-devel.
Any volunteer to formalize this method via some macro and documenting it in packaging guidelines? ;)
https://bugzilla.redhat.com/show_bug.cgi?id=1955985
--- Comment #7 from Davide Cavalca dcavalca@fb.com --- Spec URL: https://dcavalca.fedorapeople.org/review/rubygem-ffi-yajl/rubygem-ffi-yajl.s... SRPM URL: https://dcavalca.fedorapeople.org/review/rubygem-ffi-yajl/rubygem-ffi-yajl-2...
Changelog: - Fix requires for yail - Add missing requires on ruby(release) - Install additional license file
https://bugzilla.redhat.com/show_bug.cgi?id=1955985
--- Comment #8 from Davide Cavalca dcavalca@fb.com --- Note: /usr/bin/ffi-yajl-bench doesn't actually run as it requires a bunch of other gems that aren't packaged yet (oj, yajl-ruby, and something called "perftools.rb" I can't find anywhere). I'm looking into that now.
https://bugzilla.redhat.com/show_bug.cgi?id=1955985
--- Comment #9 from Vít Ondruch vondruch@redhat.com --- (In reply to Davide Cavalca from comment #8)
Note: /usr/bin/ffi-yajl-bench doesn't actually run
This sounds as some development tool. Should it even be installed by default?
Product: Fedora Version: rawhide Component: Package Review
Package Review package-review@lists.fedoraproject.org has canceled Package Review package-review@lists.fedoraproject.org's request for Michel Alexandre Salim michel@michel-slm.name's needinfo: Bug 1955985: Review Request: rubygem-ffi-yajl - Ruby FFI wrapper around YAJL 2.x https://bugzilla.redhat.com/show_bug.cgi?id=1955985
--- Comment #11 from Package Review package-review@lists.fedoraproject.org --- This is an automatic action taken by review-stats script.
The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com