Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: gooddata-cl - GoodData integration toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=609012
Summary: Review Request: gooddata-cl - GoodData integration toolkit Product: Fedora Version: 13 Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lkundrak@v3.sk QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Depends on: 594414,594416,609011 Estimated Hours: 0.0 Classification: Fedora
SPEC: http://v3.sk/~lkundrak/SPECS/gooddata-cl.spec SRPM: http://v3.sk/~lkundrak/gooddata-cli/gooddata-cl-1.0-0.1.20100628git.fc13.src...
Description:
This is GoodData data integration toolkit. The toolkit contains data modeling, transformation and loading utilities that work on top of the GoodData REST APIs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
--- Comment #1 from Lubomir Rintel lkundrak@v3.sk 2010-06-29 04:09:22 EDT --- Builds only in Fedora 14 now. The complete stack with necessary dependencies runnable on Fedora 13 is here: http://v3.sk/~lkundrak/gooddata-cli/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
Bug 609012 depends on bug 594414, which changed state.
Bug 594414 Summary: Review Request: ezmorph - Object transformation library for Java https://bugzilla.redhat.com/show_bug.cgi?id=594414
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
Bug 609012 depends on bug 594416, which changed state.
Bug 594416 Summary: Review Request: json-lib - JSON library for Java https://bugzilla.redhat.com/show_bug.cgi?id=594416
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
Bug 609012 depends on bug 609011, which changed state.
Bug 609011 Summary: Review Request: derby - Relational database implemented entirely in Java https://bugzilla.redhat.com/show_bug.cgi?id=609011
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
--- Comment #2 from Lubomir Rintel lkundrak@v3.sk 2010-09-21 05:42:17 EDT --- SPEC: http://v3.sk/~lkundrak/SPECS/gooddata-cl.spec SRPM: http://v3.sk/~lkundrak/gooddata-cli/gooddata-cl-1.1.4-1.fc13.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
--- Comment #3 from Lubomir Rintel lkundrak@v3.sk 2010-09-21 05:42:42 EDT --- SPEC: http://v3.sk/~lkundrak/SPECS/gooddata-cl.spec SRPM: http://v3.sk/~lkundrak/SRPMS/gooddata-cl-1.1.4-1.fc13.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
R P Herrold herrold@owlriver.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |herrold@owlriver.com
--- Comment #4 from R P Herrold herrold@owlriver.com 2010-09-21 11:09:48 EDT --- the URL in the .spec file returns a dead link -- perhaps replace it with: http://developer.gooddata.com/
-- Russ herrold
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
Marek Mahut mmahut@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mmahut@redhat.com AssignedTo|nobody@fedoraproject.org |mmahut@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
Michal Ingeli mi@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mi@v3.sk AssignedTo|mmahut@redhat.com |mi@v3.sk
--- Comment #5 from Michal Ingeli mi@v3.sk 2010-11-04 11:58:26 EDT --- * description and spec file clean, no useless comments
- URL contains a dead link. - Project name and package name consistency GoodData-CL Vs. gooddata-cl - Build failed for f13 [1] and also f14 [2]. - rpmlint errors:
gooddata-cl.src: W: invalid-url Source0: gooddata-cl-1.1.4.tar.gz * sources from git repo - OK
gooddata-cl.src: W: no-buildroot-tag * if this package is intended to be build for EPEL, it should contain buildroot tag.
gooddata-cl.src: W: strange-permission gooddata-cli 0755L * file listed in %{_bindir}, rpmlint shouldn't be complaining
- missing BuildDeps reported by koji:
DEBUG util.py:260: No Package Found for axis >= 1.4 DEBUG util.py:260: No Package Found for javacc-maven-plugin DEBUG util.py:260: No Package Found for xpp3-minimal >= 1.1.3.8-3.4 DEBUG util.py:260: No Package Found for xstream >= 1.3.1 DEBUG util.py:260: No Package Found for json-lib DEBUG util.py:260: No Package Found for gdata-java > 1.39
[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=2576436 [2] http://koji.fedoraproject.org/koji/taskinfo?taskID=2576466
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
--- Comment #6 from Lubomir Rintel lkundrak@v3.sk 2010-11-04 12:43:36 EDT --- (In reply to comment #5)
- description and spec file clean, no useless comments
- URL contains a dead link.
Fixed
- Project name and package name consistency GoodData-CL Vs. gooddata-cl
- Build failed for f13 [1]
F13 is too old.
and also f14 [2].
Fixed.
gooddata-cl.src: W: no-buildroot-tag
- if this package is intended to be build for EPEL, it should contain
buildroot tag.
EPEL is even more ancient.
gooddata-cl.src: W: strange-permission gooddata-cli 0755L
- file listed in %{_bindir}, rpmlint shouldn't be complaining
Well this is about the Source file. Fixed.
- missing BuildDeps reported by koji:
DEBUG util.py:260: No Package Found for axis >= 1.4 DEBUG util.py:260: No Package Found for javacc-maven-plugin DEBUG util.py:260: No Package Found for xpp3-minimal >= 1.1.3.8-3.4 DEBUG util.py:260: No Package Found for xstream >= 1.3.1 DEBUG util.py:260: No Package Found for json-lib DEBUG util.py:260: No Package Found for gdata-java > 1.39
This is on F13. That's too old.
SPEC: http://v3.sk/~lkundrak/SPECS/gooddata-cl.spec SRPM: http://v3.sk/~lkundrak/SRPMS/gooddata-cl-1.1.4-2.fc14.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
--- Comment #7 from Lubomir Rintel lkundrak@v3.sk 2010-11-04 12:43:54 EDT --- Built: http://koji.fedoraproject.org/koji/taskinfo?taskID=2576732
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
--- Comment #8 from Michal Ingeli mi@v3.sk 2010-11-05 06:20:39 EDT --- (In reply to comment #6)
(In reply to comment #5)
- Project name and package name consistency GoodData-CL Vs. gooddata-cl
- Build failed for f13 [1]
F13 is too old.
and also f14 [2].
Fixed.
Ok. Builds fine.
gooddata-cl.src: W: strange-permission gooddata-cli 0755L
- file listed in %{_bindir}, rpmlint shouldn't be complaining
Well this is about the Source file. Fixed.
OK.
- missing BuildDeps reported by koji:
DEBUG util.py:260: No Package Found for axis >= 1.4 DEBUG util.py:260: No Package Found for javacc-maven-plugin DEBUG util.py:260: No Package Found for xpp3-minimal >= 1.1.3.8-3.4 DEBUG util.py:260: No Package Found for xstream >= 1.3.1 DEBUG util.py:260: No Package Found for json-lib DEBUG util.py:260: No Package Found for gdata-java > 1.39
This is on F13. That's too old.
Ok. So this package is not stated for F13 and older, EL5 and older.
- License OK. - Packager is not using and installing maven dependency maps, so [1] is not required. - Missing buildroot tag is OK, package is NOT for ancient releases.
* few more rpmlint warnings:
* E: explicit-lib-dependency json-lib Can rpm figure out the dependency by itself?
* W: non-conffile-in-etc /etc/gooddata-cl/log4j.configuration Consider adding %config
* W: class-path-in-manifest /usr/share/java/gooddata-cl/cli-1.1.4.jar
[1] http://fedoraproject.org/wiki/Packaging/Java#maven
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
--- Comment #9 from Lubomir Rintel lkundrak@v3.sk 2010-11-05 09:49:36 EDT --- (In reply to comment #8)
few more rpmlint warnings:
- E: explicit-lib-dependency json-lib
Can rpm figure out the dependency by itself?
This is a rpmlint glitch. "lib" in the name here does not imply that the package provides a .so shared library that would be discovered by the rpm autoreq generator.
- W: non-conffile-in-etc /etc/gooddata-cl/log4j.configuration
Consider adding %config
Done.
- W: class-path-in-manifest /usr/share/java/gooddata-cl/cli-1.1.4.jar
Fixed
SPEC: http://v3.sk/~lkundrak/SPECS/gooddata-cl.spec SRPM: http://v3.sk/~lkundrak/SRPMS/gooddata-cl-1.1.4-3.fc14.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
Michal Ingeli mi@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #10 from Michal Ingeli mi@v3.sk 2010-11-05 10:10:50 EDT --- (In reply to comment #9)
(In reply to comment #8)
few more rpmlint warnings:
- E: explicit-lib-dependency json-lib
Can rpm figure out the dependency by itself?
This is a rpmlint glitch. "lib" in the name here does not imply that the package provides a .so shared library that would be discovered by the rpm autoreq generator.
OK
SPEC: http://v3.sk/~lkundrak/SPECS/gooddata-cl.spec SRPM: http://v3.sk/~lkundrak/SRPMS/gooddata-cl-1.1.4-3.fc14.src.rpm
Builds OK. Installs OK.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #11 from Lubomir Rintel lkundrak@v3.sk 2010-11-05 10:26:08 EDT --- New Package SCM Request ======================= Package Name: gooddata-cl Short Description: GoodData Integration toolkit Owners: lkundrak Branches: f14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
--- Comment #12 from Jason Tibbitts tibbs@math.uh.edu 2010-11-05 13:17:21 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=609012
Lubomir Rintel lkundrak@v3.sk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2010-11-05 14:25:21
--- Comment #13 from Lubomir Rintel lkundrak@v3.sk 2010-11-05 14:25:21 EDT --- Thanks! Imported and built.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla