https://bugzilla.redhat.com/show_bug.cgi?id=2266450
Bug ID: 2266450 Summary: Review Request: rust-fts-sys - File hierarchy traversal functions (FTS) Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/specs/rust-fts-sys.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust-fts-sys-0.2.8-1.fc39.src.rpm
Description: File hierarchy traversal functions (FTS).
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2266450
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2266451
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2266451 [Bug 2266451] Review Request: rust-uu_chcon - chcon ~ (uutils) change file security context
https://bugzilla.redhat.com/show_bug.cgi?id=2266450
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/ft | |s-sys
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7066109 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2266450
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Status|NEW |ASSIGNED
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package looks fine, just one weird thing I noticed in Cargo.toml:
links = "c"
This looks wrong. I don't think this crate should claim that it has exclusive rights to link against "c". Or is it a typo and it should be "libc"? Even then, it would be wrong, I think.
https://bugzilla.redhat.com/show_bug.cgi?id=2266450
--- Comment #4 from Michel Lind michel@michel-slm.name --- huh, yes. It sounds like it should be libc which explains the dependency on glibc-devel anyway? I wonder how it got transitively pulled in.
https://bugzilla.redhat.com/show_bug.cgi?id=2266450
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- From what I can tell:
- remove `links = "c"` from Cargo.toml - add glibc-devel as build dependency and dependency for the -devel package
from the cargo docs:
Primarily, Cargo requires that there is at most one package per links value. In other words, it is forbidden to have two packages link to the same native library.
ref. https://doc.rust-lang.org/cargo/reference/build-scripts.html#the-links-manif...
I'm pretty sure this means that `links = "c"` should be removed from upstream as well, and that this is only working by accident, because not even the "libc" crate (*the* libc bindings) claims to link with libc: https://github.com/rust-lang/libc/blob/main/Cargo.toml
package-review@lists.fedoraproject.org